Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp577217rwr; Thu, 27 Apr 2023 05:40:09 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7WFsozl/9Cy/Jnk9mudmpfb8ryYtpne7HqM3J4pZlNwuJneO+dANsgbYUKeSQtthEseTPS X-Received: by 2002:a05:6a00:2d93:b0:63d:344c:f123 with SMTP id fb19-20020a056a002d9300b0063d344cf123mr2055866pfb.1.1682599208803; Thu, 27 Apr 2023 05:40:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682599208; cv=none; d=google.com; s=arc-20160816; b=0cOh1jqPmzUcZrB9flHQAjPIxeVibYQ2skgjzAC34/ckTohJnOrQ40GvLlFKIdUkrj KLIDga1mLcqmx5UWmI4m5y+b2WQUwpdxgRVeT/hpgmFETIwSUsvBTmMJTF22m/O47v/2 q7R+BIbPrf7FXDxmMORV73A5NrfEb/Frt7WGSl7d5CgLO6JYnpB1rYmmjoP9Jz5EaELq 3Kpq+24POI9bTHzTNjzLeOvwvkx0nnR0qVpT9Xn+UKQu3+BBjnNsh/qtuyEdJIpRKmXv CH4puCLOiua69SMqA8e8OPgzOOFRJVrsbaFCCPWJve3mVWBsRne5ElnbY/vvbaehKyeq bD0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZKyLvoJ2fNug57URvpaiOBCAIlqtWrGQ11WQPzruF9Y=; b=XXWeMej9zEq7hRhm3RHDD5ycOnJ1Te9XjlCKVhxUE7G643jMXwprQEZg0luzcX29ak JKAG+59WgJWfyQZP1HeTripvA60rT4ixzoz/G4NG9o0z49LR/5kyZzkxUlef6Q5nQqqZ QO8i5WCViWnrie8p7VAjAH7oWdw3wc/Vy0u+ptCis9dkwuL1EKZC1aqd+nmeEIeUeLuf jvBCUn0iFuuvHDg2vXuWXX6b6+qywVKlguEw/AGiIYzsixdcoDAssfPL2BHAwHHU9GgD kxOPZx2Zyx1TpvL2QBI7wEqCLSpj32mUcqOjTH2atj5ViNEzfTpzQTAREIRnyD8vpR1O knZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=tPmc5ryw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y129-20020a626487000000b0063b61b49a30si18108435pfb.253.2023.04.27.05.39.47; Thu, 27 Apr 2023 05:40:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=tPmc5ryw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243980AbjD0M2b (ORCPT + 99 others); Thu, 27 Apr 2023 08:28:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243406AbjD0M23 (ORCPT ); Thu, 27 Apr 2023 08:28:29 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A473D4C39; Thu, 27 Apr 2023 05:28:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ZKyLvoJ2fNug57URvpaiOBCAIlqtWrGQ11WQPzruF9Y=; b=tPmc5rywTjzIgXh7NuHKYYAfh8 WaHBxGay50P5YmPGUgMZ0h3v47yqGkxs7rI0flhlcC1FhvY+Emiwb940Zoy5yb8Op3dBkeEZn5Ajh MYp7zgDY1WPuwcSD/jKcUEZbuCncyojBm90oIjNB0ivJuFUk2eSuSjHkAc7kzI6Ima2E=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ps0jD-00BLpu-C9; Thu, 27 Apr 2023 14:28:03 +0200 Date: Thu, 27 Apr 2023 14:28:03 +0200 From: Andrew Lunn To: Hayes Wang Cc: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH net v2 3/3] r8152: move setting r8153b_rx_agg_chg_indicate() Message-ID: <2209d5a9-31ea-4ca1-a2e8-f1a64290b2d2@lunn.ch> References: <20230426122805.23301-400-nic_swsd@realtek.com> <20230427121057.29155-405-nic_swsd@realtek.com> <20230427121057.29155-408-nic_swsd@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230427121057.29155-408-nic_swsd@realtek.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 27, 2023 at 08:10:57PM +0800, Hayes Wang wrote: > Move setting r8153b_rx_agg_chg_indicate() for 2.5G devices. The > r8153b_rx_agg_chg_indicate() has to be called after enabling tx/rx. > Otherwise, the coalescing settings are useless. > > Fixes: 195aae321c82 ("r8152: support new chips") > Signed-off-by: Hayes Wang Reviewed-by: Andrew Lunn Andrew