Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Apr 2023 13:36:48 +0100
From:   Gary Guo <gary@garyguo.net>
To:     Ariel Miculas <amiculas@cisco.com>
Cc:     rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com,
        boqun.feng@gmail.com, bjorn3_gh@protonmail.com,
        benno.lossin@proton.me
Subject: Re: [PATCH v3] rust: helpers: sort includes alphabetically in
 rust/helpers.c
Message-ID: <20230427133648.01c7bc13.gary@garyguo.net>
In-Reply-To: <20230426204923.16195-1-amiculas@cisco.com>
References: <CANiq72nm-tWGPHMaNF11baVRDFpk8ruvTAVDEWKfraEzADWqQQ@mail.gmail.com>
        <20230426204923.16195-1-amiculas@cisco.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NLVLm0DF3PwXb3mpLe/rRrW5iXye5M7i0LHSR3XoHUhMtcQp9QXO9qZgNmyx?=
 =?us-ascii?Q?lQ4jwrDMNn4YV5jHFH7anlzrpp8rZnViYc2YwgRYaQR6r5RHBH4/CyzqFwY6?=
 =?us-ascii?Q?506j0ylIpYSbWN+dc1qWChrgsNRQfwRjZESLrqjN/dKcX6NaLvjpEYJyNWui?=
 =?us-ascii?Q?cnxKOHPiBavkSwSDoYPYYkIR5VYt6JvEhkvZ4Fz6AtkgRVYRLRRAmbrElNMp?=
 =?us-ascii?Q?NMMeYePm9XGn6NmhQ+1DSIRX1DkYzHB7P33XuQNSO9Y0EGUXZI7H+jEp3U8h?=
 =?us-ascii?Q?t7YXqsSg6bMJR72ziy0jFRCj46F5rfnZEF2sqmG6XJZ4NGu2eij7cCqMO98m?=
 =?us-ascii?Q?YQjJFBlS/K6y9+ipQlxhD5p0F2sDa+x6/vS/RymSDmnEqqjLu4DzoQtiRaN3?=
 =?us-ascii?Q?gSM9YHPO5CvTf+8mu9+yQbxMp0oHHGjixgdqUpXGDlOXcSRsU+HbA8bKQSqs?=
 =?us-ascii?Q?4xaf22uJSskrm915Od3uPc2+MDU34HrIsfmwfwmBMPuanB35uCFRFXITs3lV?=
 =?us-ascii?Q?1hDEy3GBZAK+D8fFuYQSrQxcBOAP4g7Gu7quanzKSPQhBFVKX/gzh6FYGIDB?=
 =?us-ascii?Q?4jTaVBa6FqJgPHM2sIhkDTrRnKUrAHOc5Z5VTxwYMZ95KdpkswHHN1xwgOuu?=
 =?us-ascii?Q?8zuJ6rfroljhDzLHUAmo+RmwtHlm1pLIAqvTowOU5Rf7lFZSf4LA+LizgMh3?=
 =?us-ascii?Q?7JKPl6i1WOCWH9QkQ7lLlsqiqjMgFKz+NSBsdKS7vW+VsIVXkyhyguMCQ3rJ?=
 =?us-ascii?Q?NIohHdwvJyUC0PXGjwKc6sd9T0DSv0tnZkugydYjvgkhy6i/qqPJieMEMnP6?=
 =?us-ascii?Q?sImZp5rqo5ZtRr1L+jdQLxxtTkvnCKihmzTB8k2iBZOexC2HsrkjtVDOZGDO?=
 =?us-ascii?Q?1YWryMuSvdrFQvhKiLq+HJEjhsEWYpSMsOz1RX0eYC3Ex5QBlKR35NYO3cxu?=
 =?us-ascii?Q?3sEE1ckF+WTxl4Vwl6XAyPPOJdPrB2+o0eKqbAwoy0/KshN5YKfOjr/xDDNU?=
 =?us-ascii?Q?L4w1XWwXjbxgsJHJjV7m1hxiXtMobU7ZA1oEp4SmWt+pvHgZlsPyITPMITxl?=
 =?us-ascii?Q?eo0i7BTXva3hFiH1PJaqKqN13aNBCB23+eyt9SJY1dniMA7j84xCX2xXcrFO?=
 =?us-ascii?Q?pe+wmpt5W61OckSi0GeDG9XrnZbnZahN2l1k9Zn8+t0mNSQVDHLTgpoev7HR?=
 =?us-ascii?Q?DAShd1n0e87qA4K2l55oGgpinwinUtSKFS/KplKxb3zcqI3kxI1PCu8yCRFB?=
 =?us-ascii?Q?c5nNu7r8ZbNWqRGkLim4XrcAyrgx/PSF76yELDdBG6SaYjhQAqpQ3ZGv4L6N?=
 =?us-ascii?Q?3gls72SLgeAIwHPHWtKtAiOVW+uzE7nHDxbHm67hnNz44Z0B+Pzw+9i4KBdi?=
 =?us-ascii?Q?M4pOvu/9YFRXH6HA2My1JW0m4QnlnDKwovlvKg6kX0pv97E19Z2gJw5m4oev?=
 =?us-ascii?Q?vClg7hXzg7jattBRGk1BXhIM0DtSpdDe8807ms1nGHcXbXFM7QO7vqnqGig0?=
 =?us-ascii?Q?aSsGKPFZiZNFu22g0OArqKFI1Yg30tBU5VR9tc7Uz40644C4toaxiKhzoOoD?=
 =?us-ascii?Q?prtuSWftJ9+plkw71TM=3D?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: c5747221-6445-4b79-79de-08db471c13a3
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2023 12:36:51.8678
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 40szWhuLcQGwOTBTwvyrM+tgDz41KDNftXlSL5L+bWuMWpn/Wtd5XGrkFrQ5Rgt9GS2ZMswtvH0cBMfmwp61cg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LOYP265MB2221
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 26 Apr 2023 23:49:23 +0300
Ariel Miculas <amiculas@cisco.com> wrote:

> Sort the #include directives of rust/helpers.c alphabetically and add a
> comment specifying this. The reason for this is to improve readability
> and to be consistent with the other files with a similar approach within
> 'rust/'.
> 
> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1003
> Signed-off-by: Ariel Miculas <amiculas@cisco.com>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/helpers.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/rust/helpers.c b/rust/helpers.c
> index 81e80261d597..73c01db0c828 100644
> --- a/rust/helpers.c
> +++ b/rust/helpers.c
> @@ -16,15 +16,17 @@
>   *
>   * All symbols are exported as GPL-only to guarantee no GPL-only feature is
>   * accidentally exposed.
> + *
> + * Sorted alphabetically.
>   */
>  
>  #include <linux/bug.h>
>  #include <linux/build_bug.h>
>  #include <linux/err.h>
> -#include <linux/refcount.h>
>  #include <linux/mutex.h>
> -#include <linux/spinlock.h>
> +#include <linux/refcount.h>
>  #include <linux/sched/signal.h>
> +#include <linux/spinlock.h>
>  #include <linux/wait.h>
>  
>  __noreturn void rust_helper_BUG(void)