Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <a6dd47dd-6dfc-787b-43ed-edda0cc0e51f@roeck-us.net>
Date:   Thu, 27 Apr 2023 07:12:39 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: watchdog: pcwd driver updates (was: No subject)
Content-Language: en-US
To:     Oliver Neukum <oneukum@suse.com>, wim@linux-watchdog.org,
        linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230427133350.31064-1-oneukum@suse.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20230427133350.31064-1-oneukum@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Oliver,

On 4/27/23 06:33, Oliver Neukum wrote:
> This fixes some long standing deficiencies in error handling,
> several race conditions and disconnect handling.
> Finally a cleanup as we now can get the device easily
> from the interface.
> 

This series is a no-go. If you want to improve the driver, please
convert it to use the watchdog subsystem API.

Please note that the subject of your patches should start with
"watchdog: pcwd:"

Thanks,
Guenter