Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3c412c83-75a0-b7ac-4c43-2305732c1a0c@ti.com>
Date:   Thu, 27 Apr 2023 19:51:05 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [EXTERNAL] Re: [PATCH v14 3/8] arm64: dts: ti:
 k3-j721s2-mcu-wakeup: Add support of OSPI
Content-Language: en-US
To:     Roger Quadros <rogerq@kernel.org>, <nm@ti.com>, <afd@ti.com>,
        <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <s-vadapalli@ti.com>,
        <vaishnav.a@ti.com>, <r-gunasekaran@ti.com>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230331090028.8373-1-r-gunasekaran@ti.com>
 <20230331090028.8373-4-r-gunasekaran@ti.com>
 <2b74bc3f-85c7-1d2f-d597-968a914c4e6e@kernel.org>
From:   Ravi Gunasekaran <r-gunasekaran@ti.com>
In-Reply-To: <2b74bc3f-85c7-1d2f-d597-968a914c4e6e@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Roger,

On 4/25/2023 5:02 PM, Roger Quadros wrote:
> Hi,
>
> On 31/03/2023 12:00, Ravi Gunasekaran wrote:
>> From: Aswath Govindraju <a-govindraju@ti.com>
>>
>> Add support for two instance of OSPI in J721S2 SoC.
>>
>> Reviewed-by: Vaishnav Achath <vaishnav.a@ti.com>
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>> Signed-off-by: Matt Ranostay <mranostay@ti.com>
>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
>> ---

[...]

>> +			clocks = <&k3_clks 109 5>;
>> +			assigned-clocks = <&k3_clks 109 5>;
>> +			assigned-clock-parents = <&k3_clks 109 7>;
>> +			assigned-clock-rates = <166666666>;
>> +			power-domains = <&k3_pds 109 TI_SCI_PD_EXCLUSIVE>;
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +
>> +			status = "disabled"; /* Needs pinmux */
>> +		};
>> +
>> +		ospi1: spi@47050000 {
>> +			compatible = "ti,am654-ospi", "cdns,qspi-nor";
>> +			reg = <0x00 0x47050000 0x00 0x100>,
>> +			      <0x07 0x00000000 0x01 0x00000000>;
>> +			interrupts = <GIC_SPI 841 IRQ_TYPE_LEVEL_HIGH>;
>> +			cdns,fifo-depth = <256>;
>> +			cdns,fifo-width = <4>;
>> +			cdns,trigger-address = <0x0>;
>> +			clocks = <&k3_clks 110 5>;
> What about clock parent and clock rate assignment like it was done for osip0?

ospi1 uses default values.

>> +			power-domains = <&k3_pds 110 TI_SCI_PD_EXCLUSIVE>;
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +
>> +			status = "disabled"; /* Needs pinmux */
>> +		};
>> +	};
>>  };
> cheers,
> -roger