Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Apr 2023 16:21:53 +0100
From:   Lee Jones <lee@kernel.org>
To:     Maarten Zanders <maarten.zanders@mind.be>
Cc:     Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 2/2] leds: lp55xx: configure internal charge pump
Message-ID: <20230427152153.GY50521@google.com>
References: <20230421075305.37597-1-maarten.zanders@mind.be>
 <20230421075305.37597-3-maarten.zanders@mind.be>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230421075305.37597-3-maarten.zanders@mind.be>
Precedence: bulk

On Fri, 21 Apr 2023, Maarten Zanders wrote:

> The LP55xx range of devices have an internal charge pump which
> can (automatically) increase the output voltage towards the
> LED's, boosting the output voltage to 4.5V.
> 
> Implement this option from the devicetree. When the setting
> is not present it will operate in automatic mode as before.
> 
> Tested on LP55231. Datasheet analysis shows that LP5521, LP5523
> and LP8501 are identical in topology and are modified in the
> same way.
> 
> Signed-off-by: Maarten Zanders <maarten.zanders@mind.be>
> ---
> 
> Notes:
>     v1: implement as bool to disable charge pump
>     v2: rewrite to use string configuration, supporting all modes
>     v3: simplification by replacing string from DTS by constant
>     v4: added notes
>     v5: property type to u32
>     v6: cleanup parsing of DT paramter
>     v7: formatting
> 
>  drivers/leds/leds-lp5521.c                | 11 +++++------
>  drivers/leds/leds-lp5523.c                | 14 +++++++++-----
>  drivers/leds/leds-lp55xx-common.c         |  9 +++++++++
>  drivers/leds/leds-lp8501.c                |  8 +++++---
>  include/linux/platform_data/leds-lp55xx.h |  3 +++
>  5 files changed, 31 insertions(+), 14 deletions(-)

Applied, thanks

-- 
Lee Jones [李琼斯]