Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <27e8289e-21a4-7d7a-231f-4a27334dd1f9@kunbus.com>
Date:   Thu, 27 Apr 2023 17:33:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] tpm: Re-enable TPM chip boostrapping non-tpm_tis TPM
 drivers
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>,
        Pengfei Xu <pengfei.xu@intel.com>
Cc:     linux-integrity@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
        Jason Gunthorpe <jgg@ziepe.ca>, linux-kernel@vger.kernel.org,
        heng.su@intel.com
References: <20230426185833.289868-1-jarkko@kernel.org>
 <ZEnWykDF6kbZ8nVi@xpf.sh.intel.com>
 <a258fcd353d67e918a0c86a59e27bf1332764a7b.camel@kernel.org>
From:   Lino Sanfilippo <l.sanfilippo@kunbus.com>
In-Reply-To: <a258fcd353d67e918a0c86a59e27bf1332764a7b.camel@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1pYY1BlQ0lBWHR5eXpsNTAyM2VXRTZtZXdILy8rVFJkT1ZrMEhIMm1lRWRz?=
 =?utf-8?B?N09SdnlZbkNObHBrRW9jMDdvdksyVmRTY2VIby9sS1hZS2pjSmE5czBPSzBo?=
 =?utf-8?B?MGZ1QS9mQ3YxdWZzWVgyOUM4Tk9GNXR1YWdmRGVvS0lGaThybGVTOTFyRE4z?=
 =?utf-8?B?aEtVRHBDQnJ5ZmZCaTN0V1dRS3BvSk5LUVM3MzNuOWdOczdGejUvQzZiWWEr?=
 =?utf-8?B?eVE3eUJhZGt5dXMxZDQzTWZmYzlZMkpBNzA5RDAvaUk4VFhFajVEcXRXOGFs?=
 =?utf-8?B?d0JhS1hSbWpabXBwTGZOdzNaZThaYVZDOWg3eks4M0pxdWxGUVVzd3pReFpT?=
 =?utf-8?B?dnpUdUdtdkgyUnB0SDc5N1ZHZ1d0QWl4c1Y2VUhBWC9lMkZVNUFXYmdMY0lh?=
 =?utf-8?B?UERvU2VCTGs1NFhGRmhMTlk2S2VFSVpNVHluK1BsTjRNL0pDZ1QvVSttSzN2?=
 =?utf-8?B?TEVaUWJ0Y05lOHBWdmd1L1FRYTdMZjMrdzZJVllxQWpaMFg0UDd4empsUVBZ?=
 =?utf-8?B?VGw0K1dmR2tTMUlUSWhjanEwZ0pXT0V3cklqL2ZubzEzNEZzQnQzUUFteFZ5?=
 =?utf-8?B?Y3JWMGlSTzdaSWU3OVlOMDRKWEluUTdJdWdxZ3FaQ0xtTUt3dm02VG5RTUxF?=
 =?utf-8?B?dnlkTWE4d1N2bEplL0ZOZ2YwOFE0SzFOS1NRRHRwMHdUWVdwMUpaK29JNjd6?=
 =?utf-8?B?dEJVQ2JFaFZYanFyOVM3VDA3czJuSnJSc1hZQmNidk56VEtqeVAyRDlzUWNO?=
 =?utf-8?B?VkFjRnFYaWlEK3hEUzRwR2E3UmFPOGVnUVBjc0FJYzJSbWlDTmZXTkhmeUtw?=
 =?utf-8?B?bVI0MmhXeUdqUUxOZ0VWRldwT2hybG5XS2ZPOEZqRXJTT0haUUhsTFIzWVF6?=
 =?utf-8?B?OWtZUW5ZTmZRdnQ5RjM5VTZKbm1xYjN5cU4xNjZlUHBWZnRyUXY2N2srWktx?=
 =?utf-8?B?SjNPNGRwNS9xZnhETGVSZWo0TUlFR1FxSnNtUHhyblN1UW00Z3dueXo2MXZ4?=
 =?utf-8?B?TERFV25iWTBNMFUwM0JjNkZmQ3Uwd0hDa3g4WVROUGh1amJUdENqY2xURVkz?=
 =?utf-8?B?MDZObUhRYjFPVzNtVE1CRk1TQ2dGWVR0Vnc1eC9JcGtBL2dWbk5PZEtGOFRo?=
 =?utf-8?B?cWZpVkVhVjNrL0g0VFpWcWNzYlM2SEdYQ1Z2NTBTNVpvaStzNWRnZVJhSFhv?=
 =?utf-8?B?VGVybTZxUnBUYzk4QnVOTGIwdjF4aW9aZDBPQWNXRExSWlBzTG5haWpWMTVa?=
 =?utf-8?B?d1pXa0RwV2c4aEFINmlGdWVGME9sVUFLb1FqTnJPcGpCU0lkN1BOSzdSeXE0?=
 =?utf-8?B?L1YxTWtVNVhtL2pCcEZWUCtia1ExSG91NnJmaWxzdEtKTVVlRnR6RnhmcXEw?=
 =?utf-8?B?aHR4Mk15UEhNYTdzNWg2OEpsVHBpcW5iVDgzV2wrTnJmdExLblVUZFl1UGhi?=
 =?utf-8?B?S2J1OXA5R2N3b0tjMXl1THgzL2Z3Ymc1cTlITjlRM1ZLZW1xTUlodWpuWG0z?=
 =?utf-8?B?d1ZwMlZXT3RObUlaRGdhb3VxRFhXMmZIMVBVZTJIWkM3Tk9lQk9IcWxoaWp4?=
 =?utf-8?B?aW0vcjVFa2M2N3ByVGVvc09RRCs1ZUN2SGVmTG0xUDVLTERVQ24zZDhwU2Vt?=
 =?utf-8?B?U0srZlBqTGFIYkpSemo1ME1hN0JwSXpITUZqVmd3ODd2Qm9ucDQvOThRUTB4?=
 =?utf-8?B?M3lndEYwVUxuYjg2YmVNVncwZGpqWFpYRlB2Qlc0bDBUM1c0a1A5dHNQaFR5?=
 =?utf-8?B?TklIbmkzdVdFVkt0RXVrYUdnK2RhY2NhR2NpaE5XWFk2dGJ5d3djOWtwcnZZ?=
 =?utf-8?B?bU9SQmtPNDlNdndwb1dhSTdJVDcvWlg5ZUVxaXRlQjRNMjZFK0REWVFFYlY2?=
 =?utf-8?B?WFIzN2Q4RlpJY25MUk5GaHBmOWFWSXV0dU1TeTM4bHA0ZWlhZ3QvQnVHV1lz?=
 =?utf-8?B?T3dydEY5cWQydGRJUzZqSS8yRFozVGswVEtiQlRIcVBwOVdiZWtYaTNKaGdU?=
 =?utf-8?B?Ni9Ec3ZyL3N1Z05UNFE1NWhsbnYyeHl3Qkk5Y2s5Qm1lb2FkeDVzZkZHQXZI?=
 =?utf-8?B?WVlkbWtWOHFNaWRXaUl3T0R2TXhramhIRjlYUlVoUWVNV1FVSGV6OTVGbmdQ?=
 =?utf-8?B?ZHhPUHBjaWxvajlXMm9jUWtTUkhvYWRMZW5kM21aTHF0aUdnZXkvMGFhWkFC?=
 =?utf-8?Q?CCkobXqs0V/ivJMbrYTzGyBUdCEmho4v9GBd4qmAQKVw?=
X-OriginatorOrg: kunbus.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 613b5baf-df9b-401f-fed0-08db4734c0ff
X-MS-Exchange-CrossTenant-AuthSource: VI1P193MB0413.EURP193.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2023 15:33:30.6539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: aaa4d814-e659-4b0a-9698-1c671f11520b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AwaY+K6KvrB1FbHL8LjVDhqQLeqtBREQ7n69k0Ow6KT5lY/IoISSLlJbMLp5o1U36Ac5BPpk/4WDiQp60OYIyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P193MB1024
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Jarkko,

On 27.04.23 12:52, Jarkko Sakkinen wrote:
> ATTENTION: This e-mail is from an external sender. Please check attachments and links before opening e.g. with mouseover.
> 
> 
> On Thu, 2023-04-27 at 09:58 +0800, Pengfei Xu wrote:
>> On 2023-04-26 at 21:58:33 +0300, Jarkko Sakkinen wrote:
>>> TPM chip bootstrapping was removed from tpm_chip_register(), and it
>>> was relocated to tpm_tis_core. This breaks all drivers which are not
>>> based on tpm_tis because the chip will not get properly initialized.
>>>
>>> Take the corrective steps:
>>> 1. Rename tpm_chip_startup() as tpm_chip_bootstrap() and make it one-shot.
>>> 2. Call tpm_chip_bootstrap() in tpm_chip_register(), which reverts the
>>>    things  as tehy used to be.
>>            ^ two space and one typo "they"
>>          Thanks for your fixed patch in short time!
>>
>>   And I tested this patch, it could not be reproduced in 155s, and the patch
>>   fixed this issue.
>>   Fixed dmesg is in attached.
>>
>> Tested-by: Pengfei Xu <pengfei.xu@intel.com>
> 
> Thanks a lot! I'll take immediate action to send PR to Linus.
> 
> Lino: no worries. It was expected that such a large refactorization
> could break a thing or two. You did a good job in any case.
> 
> BR, Jarkko

I guess you are right, there will probably be more issues showing up
in the next time. I will try my best to help fixing them.
Thank you very much (also for fixing this issue)!

Best regards,
Lino