Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Apr 2023 18:00:53 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     Simon Guinot <simon.guinot@sequanux.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Hans de Goede <hdegoede@redhat.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Xing Tong Wu <xingtong.wu@siemens.com>
Subject: Re: [PATCH 1/1] gpio-f7188x: fix pin count on nct6116d bank 7
Message-ID: <20230427180053.512864e2@md1za8fc.ad001.siemens.net>
In-Reply-To: <20230427112106.697dd352@md1za8fc.ad001.siemens.net>
References: <20230425153911.32135-1-henning.schild@siemens.com>
        <20230425153911.32135-2-henning.schild@siemens.com>
        <ZEoydXMDRONgbhY8@76cbfcf04d45>
        <20230427112106.697dd352@md1za8fc.ad001.siemens.net>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VsTTqwiT1UkkadTttZck34Rfu7VLhnR+AwsUkxKbawlrxLuMTDfGhJLAZEPv?=
 =?us-ascii?Q?Fs9+BrlMgWxHu3qQoYRkFuAyGT8nQ6LjM3JDM70d/OBYjagAWtgeqUyXTIlD?=
 =?us-ascii?Q?AIu1Uw/0VC+c9zt38YaP0+X0CspKdTEqIoAXbPX0a5mwtHwxePYVlgJDdsLp?=
 =?us-ascii?Q?tz4B58J79qY0Is0v2uQVq4E5eFf1g0hgc7ehI5G72MZriHdC0aFUWy3KFFgm?=
 =?us-ascii?Q?ZAbJ1oJUTekH7DDW5c3E7JkYHnHbbrVD1FTDEGczrRafhljj/aBD9oCyxGuO?=
 =?us-ascii?Q?R005idXJkykliuDpjLCeietH1BPs+PdZ2N2Z+UVY4g+DxVcteEt6OiKEQ68j?=
 =?us-ascii?Q?sKOdIS6jr1j7HEaKWbBLoFX+0umpvuwUBIxj0ngIoi9OP/FJIQETm933AsQB?=
 =?us-ascii?Q?0RBhznxlGLidyHEtGBZSbo7CGdqvW/UYh+FWfiY/MPRirEOsjaeMzkJmKFNq?=
 =?us-ascii?Q?nYH3Rxn0eXx8UWPPOy8OlwuVD/ahAVBVtyEWQC94q17NGFPx86/9UDiuYmSj?=
 =?us-ascii?Q?VqYHIp/luuqN/xYlr7seZ/uFIlEBrahZlftkr5PLWXfGAm6qAHDNWs8APUwi?=
 =?us-ascii?Q?Rt4p34M9lIZmEutLY5mlpnlcfj9ojpoG/Cs5n2nYPGLygkcjZ92PCObeIbN4?=
 =?us-ascii?Q?VoHuiuCvRJ790PSyzk5JobmPT46Lg4K17oJM8lNSUhJVL+wJ1wmEdRfYJe0J?=
 =?us-ascii?Q?6rTax714fp7Ie5N1wBwp3kCOtqB6HLDtwAKJ9v/3aqcjPPcWx3kQGAG6wzGY?=
 =?us-ascii?Q?43r3/kOm5H53dtx3K2Qe6XyqJcW5/jzELQwMJeFPkKmNYi2NE3WwXS8tZL3y?=
 =?us-ascii?Q?D7I4gEqM9pTQCmlBscfbzkE//FO8fhhPMVZ6/VJytBolVu16UgxVZrfVQlqK?=
 =?us-ascii?Q?fX4tkRxFM6WjlLhy5Nbrrga9sWYPOx460GQ86ZsK4jAYCXxzV90xgIyPpaOK?=
 =?us-ascii?Q?GhdjdQp7cPLRw7C4Yg+F5khf2vwS67VldiXsnen+Elaa/LxhRXZYJPuejFMm?=
 =?us-ascii?Q?qW9Xe09yWG6lSuCSYWVbG5+hBY+ZbRvLNqmxWC+lzqsL1qfJ6+5fKEpI1TWp?=
 =?us-ascii?Q?iccMkA9l6fOio3kHAuQlMKdjOfFzInT3x5zN76bVPodiE6cwz16CF9EoFcHT?=
 =?us-ascii?Q?TSerIBuOFZxt65NZZAidZirk1of4lAUNiBbtgQazyz166elqclKW83Qx763j?=
 =?us-ascii?Q?9co8OjaoDEgHyTWa34vdo/natToUc28/7SIfQExnV1zX7VqyfEq6fNhlgLAO?=
 =?us-ascii?Q?36adkR9L+orZVoDX9eCkGPVjGndLJCJi+kvCSx7wBb8wGuYmNyAqy62wBq57?=
 =?us-ascii?Q?Ujb7fKXb+P30jVjt3HnVO8DsoIMSUJc1JSHykpMWukiSH2AlitVJbhzXV74T?=
 =?us-ascii?Q?J/BTq586yx8pOSE2gZcv60cLY4Ozyptv5pY9v6ngKgFyQTYzNeOBDBIMIVuT?=
 =?us-ascii?Q?sMdibYld9/jtbxHEBtZquxSApirSHuL9i6KmQAmc+sdZ6CDCeISOthqrElOg?=
 =?us-ascii?Q?KUAqVrFm0D3eD5GwTLAPzyNu+RVEy++RB0Bfnz2zE2FC5U3blv4VUbvPihVL?=
 =?us-ascii?Q?+00St19oGJuiTOljH9n02x4ouGIPpgiF6Abf2KsIhX6e7aP0q4ZVuHOafOfb?=
 =?us-ascii?Q?nA=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ed17cf9-59f2-40fc-0681-08db47389932
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2023 16:01:02.2522
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7pezoLWS1Vz5smMZjJZL66BeW1WKkt3a6iUb6G6t/8uoZoZRwgJLlBIIpnc062JveVlotuhVrEojhsGPXTbUQ+eNU+ja/2v38qsgBG5VcM8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR10MB5733
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Thu, 27 Apr 2023 11:21:06 +0200
schrieb Henning Schild <henning.schild@siemens.com>:

> Am Thu, 27 Apr 2023 10:29:41 +0200
> schrieb Simon Guinot <simon.guinot@sequanux.org>:
> 
> > On Tue, Apr 25, 2023 at 05:39:11PM +0200, Henning Schild wrote:  
> > > The count was wrong because i looked at the wrong spec for the
> > > chip in question. I now got access to the spec for that very chip
> > > and group7 has all 8 pins, just like the other groups.    
> > 
> > Did you use the NCT6102D / NCT6106D datasheet in a first place ?  
> 
> I do not remember which one, but one of the few one could find online.
> Now i have datasheets for two chips directly from the vendor, both
> files not publicly available and i am afraid i can not share.
> 
> > If the only difference with NCT6116D is the number of pins on port
> > GPIO-7, then maybe we should handle it and claim support for this
> > models as well ?  
> 
> Please hold this patch back until i confirm again. It might be that i
> got the model name wrong as well and might have to fix some strings. I
> basically started my journey with a preliminary driver i got from
> Nuvoton, which maybe made me think i was looking at a NCT6116D while i
> was not.

I just sent a v2. I indeed have a 6126D on all of the three boards, and
never had a 6116D. So that v2 does change that name and the pin count
on the last bank.

Henning

> 
> At least that is what the chip IDs from the specs seem to strongly
> suggest.
> 
> I am sorry for the confusion and will try to clean that up.
> 
> Now having access to some of those specs, i can offer to add more
> variants without testing. Such support would be in patches on top, not
> subject to fixing what we have in stable already. But i would only do
> this on demand and have a weird feeling about it, the code might be
> trivial but i have no means of testing.
> 
> Henning
> 
> > Simon
> >    
> > > 
> > > Fixes: d0918a84aff0 ("gpio-f7188x: Add GPIO support for Nuvoton
> > > NCT6116") Reported-by: Xing Tong Wu <xingtong.wu@siemens.com>
> > > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > > ---
> > >  drivers/gpio/gpio-f7188x.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpio/gpio-f7188x.c
> > > b/drivers/gpio/gpio-f7188x.c index 9effa7769bef..05c0edc4778f
> > > 100644 --- a/drivers/gpio/gpio-f7188x.c
> > > +++ b/drivers/gpio/gpio-f7188x.c
> > > @@ -282,7 +282,7 @@ static struct f7188x_gpio_bank
> > > nct6116d_gpio_bank[] = { F7188X_GPIO_BANK(40, 8, 0xF0, DRVNAME
> > > "-4"), F7188X_GPIO_BANK(50, 8, 0xF4, DRVNAME "-5"),
> > >  	F7188X_GPIO_BANK(60, 8, 0xF8, DRVNAME "-6"),
> > > -	F7188X_GPIO_BANK(70, 1, 0xFC, DRVNAME "-7"),
> > > +	F7188X_GPIO_BANK(70, 8, 0xFC, DRVNAME "-7"),
> > >  };
> > >  
> > >  static int f7188x_gpio_get_direction(struct gpio_chip *chip,
> > > unsigned offset) -- 
> > > 2.39.2    
>