Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp913744rwr; Thu, 27 Apr 2023 09:40:16 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7fvDwji1VKjDu9hUYmdpq0jRXDCx6BYFAlJSuU0cqGH1WJ9fC/0rIjVKQjyOkG4cSRfrAV X-Received: by 2002:a17:90a:1d3:b0:246:fa2b:91be with SMTP id 19-20020a17090a01d300b00246fa2b91bemr2139483pjd.3.1682613616186; Thu, 27 Apr 2023 09:40:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682613616; cv=none; d=google.com; s=arc-20160816; b=Wb3jy1hqPN+btQ2MkyN3LU+9cw5roht9uJ367fTnL+1Rj8zfy1dwjLqvgfu1oWTEaE nrRq1RxWtPbWV85ipAYdcQ83EXcLXLPr7je5IaLW2C2xqwGWXK+S1SmPtKMAtFVGvYIy sHgm0RMDzkU+JYwptc713ITPnPOCSzqcIT7ap/ikCxbC6rJG0ji9k+m3zlNfdDXEFu1h F0LV/QqVu61u79pSc7nyV4s/z0YaYkrLTTLKtKRfl6raKKCRc+afO6B+kzLmZOTQIIWG 0C5wMYja0PUmomwgj2XMC4UMKi8n4tm/BmMnzNDtCrt0K4TfoKzEoDQOkSfZvTBjKUuF eyDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ovY5SMBcqEU+CyT1KhOmMG7PTkkNuLj7MmOlbE1w+WY=; b=uj/t4LFUXSMlu74tm0RpcHjvcWBt3NZk8xyhQ0MvZnkJhw2aLU3hlvOaDmmqvJVtpx LwJy5/gmbasFxtXs/hV57JBJEWVaTKPJJmaYjEehhsgY0mudtQnPgT7KEnxu+6ejH012 5SCN/ZIzt5OSfnmfEBq3xWJIhKsOFpJwo6QZSJAbX3qfG0JRlRv/Sl9Wv+Lh91aUGMAd VyjLBEQ1wLxVWjoEuWR49RbukVim82Zc6j4T8QHwBuvRGJpCeGq2dyfZaBQlqBzwPaoX 8KZ4OObjrzGBJVfuqPE3CScKK+mOJ2gC6Zfwi8JinK7XT3mbK1+Rc7vMllJVo9BVYfem gT7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tFjZdV7z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w16-20020a17090a8a1000b0023adb22068csi28165pjn.81.2023.04.27.09.40.02; Thu, 27 Apr 2023 09:40:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tFjZdV7z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244129AbjD0Q2F (ORCPT + 99 others); Thu, 27 Apr 2023 12:28:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233236AbjD0Q2E (ORCPT ); Thu, 27 Apr 2023 12:28:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABEDB10E; Thu, 27 Apr 2023 09:28:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 465A360F51; Thu, 27 Apr 2023 16:28:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D74BC433D2; Thu, 27 Apr 2023 16:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682612882; bh=sygxyc6bJpU/G8GGd4Uas2ekQmIkPh/RJ/FhruQwGxM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tFjZdV7zhl9uUumZNfu0wBVvnGeZ2hwcuYdUN4cf//dFpowtme6rbXEsEHLh0YcRK vU5p9Kzih3lZmZRRAj1SbjOi3YRch9UCalQ5Bh9EzjKrjEwZ35lrNsCEHRhn5DGrFZ LU38paKFxKW0TjPidBaqC25hjJO5Z/+QIb8uXcfLVQgdcssXoxGd2MqSvWpBd18ZMz dqU5CwLLn/8kT1jvVgKHx5gB78yePAFm+ObHhRtGGYbRURiXn0Rw2m4VdYWnrH+jaX OBqdRS6XqwMn99jLMcKHqI1I+a9Q1ZljRMmASgfnIvLx5VY3fqDP1DmCoMUj1+PbRu DpT4sC3ILgVGw== Date: Thu, 27 Apr 2023 09:28:00 -0700 From: Jaegeuk Kim To: Dan Carpenter Cc: Christophe JAILLET , Chao Yu , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH] f2fs: remove some dead code Message-ID: References: <523ec4b037d064e92e19203e3ab9a161e3d9aa71.1681764681.git.christophe.jaillet@wanadoo.fr> <2867d5b3-c6cb-49fa-854a-0f58f9a5adb5@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2867d5b3-c6cb-49fa-854a-0f58f9a5adb5@kili.mountain> X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/18, Dan Carpenter wrote: > On Mon, Apr 17, 2023 at 10:51:46PM +0200, Christophe JAILLET wrote: > > > > - ret2 = filemap_check_errors(NODE_MAPPING(sbi)); > > - if (!ret) > > - ret = ret2; > > + ret = filemap_check_errors(NODE_MAPPING(sbi)); > > > > return ret; > > Let's get rid of "ret" as well: > > return filemap_check_errors(NODE_MAPPING(sbi)); Applied with this modification. Thanks. > > regards, > dan carpenter