Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230424-acpi-prop-v1-1-ffa9a300b1cd@marcan.st>
In-Reply-To: <20230424-acpi-prop-v1-1-ffa9a300b1cd@marcan.st>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Thu, 27 Apr 2023 18:51:52 +0200
Message-ID: <CAJZ5v0hGyiUztmKkhZe9Hp4jaS0_iyOgnpVBRv8SLAre2nTOmw@mail.gmail.com>
Subject: Re: [PATCH] ACPI / property: Support strings in Apple _DSM props
To:     Hector Martin <marcan@marcan.st>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, asahi@lists.kernel.dev,
        Lukas Wunner <lukas@wunner.de>,
        Linus Walleij <linus.walleij@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Mon, Apr 24, 2023 at 8:47 AM Hector Martin <marcan@marcan.st> wrote:
>
> The Wi-Fi module in x86 Apple machines has a "module-instance" device
> property that specifies the platform type and is used for firmware
> selection. Its value is a string, so add support for string values in
> acpi_extract_apple_properties().
>
> Reviewed-by: Lukas Wunner <lukas@wunner.de>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
>  drivers/acpi/x86/apple.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/x86/apple.c b/drivers/acpi/x86/apple.c
> index 8812ecd03d55..45d0f16f374f 100644
> --- a/drivers/acpi/x86/apple.c
> +++ b/drivers/acpi/x86/apple.c
> @@ -71,13 +71,16 @@ void acpi_extract_apple_properties(struct acpi_device *adev)
>
>                 if ( key->type != ACPI_TYPE_STRING ||
>                     (val->type != ACPI_TYPE_INTEGER &&
> -                    val->type != ACPI_TYPE_BUFFER))
> +                    val->type != ACPI_TYPE_BUFFER &&
> +                    val->type != ACPI_TYPE_STRING))
>                         continue; /* skip invalid properties */
>
>                 __set_bit(i, valid);
>                 newsize += key->string.length + 1;
>                 if ( val->type == ACPI_TYPE_BUFFER)
>                         newsize += val->buffer.length;
> +               else if (val->type == ACPI_TYPE_STRING)
> +                       newsize += val->string.length + 1;
>         }
>
>         numvalid = bitmap_weight(valid, numprops);
> @@ -119,6 +122,12 @@ void acpi_extract_apple_properties(struct acpi_device *adev)
>                 newprops[v].type = val->type;
>                 if (val->type == ACPI_TYPE_INTEGER) {
>                         newprops[v].integer.value = val->integer.value;
> +               } else if (val->type == ACPI_TYPE_STRING) {
> +                       newprops[v].string.length = val->string.length;
> +                       newprops[v].string.pointer = free_space;
> +                       memcpy(free_space, val->string.pointer,
> +                              val->string.length);
> +                       free_space += val->string.length + 1;
>                 } else {
>                         newprops[v].buffer.length = val->buffer.length;
>                         newprops[v].buffer.pointer = free_space;
>
> ---

Applied as 6.4-rc material, thanks!