Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <61bc7bc0-4e1d-247f-14ab-2a677af5aace@gmail.com>
Date:   Thu, 27 Apr 2023 10:05:54 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2 net-next 1/6] dt-bindings: net: brcm,unimac-mdio: Add
 asp-v2.0
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>, Justin Chen <justinpopo6@gmail.com>
Cc:     netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        bcm-kernel-feedback-list@broadcom.com, justin.chen@broadcom.com,
        f.fainelli@gmail.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com,
        krzysztof.kozlowski+dt@linaro.org, opendmb@gmail.com,
        andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
        richardcochran@gmail.com, sumit.semwal@linaro.org,
        christian.koenig@amd.com
References: <1682535272-32249-1-git-send-email-justinpopo6@gmail.com>
 <1682535272-32249-2-git-send-email-justinpopo6@gmail.com>
 <20230427170354.GA3163369-robh@kernel.org>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <20230427170354.GA3163369-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/27/23 10:03, Rob Herring wrote:
> On Wed, Apr 26, 2023 at 11:54:27AM -0700, Justin Chen wrote:
>> The ASP 2.0 Ethernet controller uses a brcm unimac.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> Signed-off-by: Justin Chen <justinpopo6@gmail.com>
>> ---
>>   Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
>> index 0be426ee1e44..6684810fcbf0 100644
>> --- a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
>> +++ b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
>> @@ -22,6 +22,8 @@ properties:
>>         - brcm,genet-mdio-v3
>>         - brcm,genet-mdio-v4
>>         - brcm,genet-mdio-v5
>> +      - brcm,asp-v2.0-mdio
>> +      - brcm,asp-v2.1-mdio
> 
> How many SoCs does each of these correspond to? SoC specific compatibles
> are preferred to version numbers (because few vendors are disciplined
> at versioning and also not changing versions with every Soc).

So far there is a 1:1 mapping between the number of versions and the 
number of SoCs, and the older SoC uses v2.0, while the newer one uses v2.1.
-- 
Florian