Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1681443714.git.yu.c.chen@intel.com>
In-Reply-To: <cover.1681443714.git.yu.c.chen@intel.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Thu, 27 Apr 2023 19:02:35 +0200
Message-ID: <CAJZ5v0hdmL=pM7QPcox3+m9CBs9SA_sMf+HFbo11W4ho_+vHCw@mail.gmail.com>
Subject: Re: [PATCH v3 0/2] Fix test_resume failure by openning swap device non-exclusively
To:     Chen Yu <yu.c.chen@intel.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <len.brown@intel.com>, Ye Bin <yebin10@huawei.com>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Pavankumar Kondeti <quic_pkondeti@quicinc.com>,
        Yifan Li <yifan2.li@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Fri, Apr 14, 2023 at 6:14 AM Chen Yu <yu.c.chen@intel.com> wrote:
>
> test_resume does not work in current kernel when using swapfile for hibernation.
> This is because the swap device should be openned non-exclusively in test_resume mode.
>
> Patch 1 is a preparation to turn snapshot_test into a global variable.
> Patch 2 is the fix to open swap device non-exclusively only for test_resume mode.
>
> Change since v2:
> Adjust the initialization of fmode and refine the commit message
> per Rafael's suggestion.
>
> Change since v1:
> Turn snapshot_test into global variable and do not introduce parameters for swsusp_check()
> nor load_image_and_restore().
>
> Chen Yu (2):
>   PM: hibernate: Turn snapshot_test into global variable
>   PM: hibernate: Do not get block device exclusively in test_resume mode
>
>  kernel/power/hibernate.c | 15 ++++++++++++---
>  kernel/power/power.h     |  1 +
>  kernel/power/swap.c      |  8 ++++++--
>  3 files changed, 19 insertions(+), 5 deletions(-)
>
> --

Both applied as 6.4-rc material, thanks!