Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp961784rwr; Thu, 27 Apr 2023 10:17:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5p6IXKYoelN/is1YcCL6oWoktdV3gVgonnZ0Ld7n98p2gfZW6J4TCnd5cVzn2Mmj+ZzOwU X-Received: by 2002:a05:6a21:32a2:b0:f3:d92:a209 with SMTP id yt34-20020a056a2132a200b000f30d92a209mr2757492pzb.0.1682615833448; Thu, 27 Apr 2023 10:17:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682615833; cv=none; d=google.com; s=arc-20160816; b=Nc6Kkni7oqqfS/I9co6RHR7KPez14T8xHFQMwrOaALq+SkmKLO5mYt9fKcINb6Es7B i6cJQ/tKjwuLdsYRCzrFqflvY1lNL79XDZ7ylddLMnA3/zfu4DLkKnDNxnryrZpRYzLy +MUa5Kp6/+itxvwC2JvUggpvL024nzWzrphENKv5/2AuOWa4bawweIacKdZ3aCQJDFi9 0E4fy5apePb4BeoLFk/1qF3wdeUOT+i9KJ+VoqHnFL9LL8efj8OLlhUCwMHQYo4rO1Qk J5rWqjL7uLPKJsxh9Gy6PhaFYIRw+fJHc7fqpJWPkdnGgN9GoCd1usHHnoukTD83iaih vU4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=XtVz+kmhD4ZEQCfgeBRduaYDGwcynWpM2tKyFsOPXbU=; b=BldlPzTDuQRWrdoy+RPJ7/K9LJ6MFnBZII+DzKpWKoMf8zn0HjtKVdV1AAFyb1XS02 5ttgUS0QLvIxVsWQEyJAkEOVvNJl4H0CaQcuhgEkqd699PbpWiDR8X+xAFVbU9L/XJCZ wwPFgLIu7eMcHDZljuem8fDp034XhgkR6Xsh9yFFMJ/fZQRYHbYv+KQv93Wz7QbAC+NT 8D0zRjXIsenOjyo2K+HCpZmrvIUDC2hur7iqPxWsKcLnXG+9tLN5vYFTRnjsAU67/sfa yDG0uDJE8Dwsy8t4qhRyKDF2lFjHLIS0uylvtOKBpsoKiYlg0MOD2C+a9QDUejWvl4oz bj7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T1pfzL4m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y23-20020a17090a105700b00246bdd45f1csi117706pjd.33.2023.04.27.10.17.01; Thu, 27 Apr 2023 10:17:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T1pfzL4m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244351AbjD0RPw (ORCPT + 99 others); Thu, 27 Apr 2023 13:15:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243894AbjD0RPv (ORCPT ); Thu, 27 Apr 2023 13:15:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD31B1993; Thu, 27 Apr 2023 10:15:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4B33963BB9; Thu, 27 Apr 2023 17:15:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B5ABC4339E; Thu, 27 Apr 2023 17:15:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682615749; bh=6lphV+9yp+4j33QChmFrKQxUY8ArwGcehoykxFMj7QU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T1pfzL4mwgyxQN6l2n2mNG8FVUxAqYlre5o1+veoWSGdtDsrOuCSCKnXwI2486SKW BzkN3jVHdx81+gNh9VWnGcZkr788fptNJXiG5h2+YNf4PXeXNC/m8WjSmQBoUDSQRR 60fEt/SOURAFBZRNIaFXqZCheH6XEU77uX+HfuaWursAcb3sIaIcYjXbFstLgoqGox Tsa1aUEQl6Y4y2/LbM9BQe4caqngSMZOi3SGam/ud9/CYtNLKBwd5wx4ldJsZB4BR7 ZwI8ngMpIN4thRLHYlRnpt0vPCt2CbHjhCg76KVPVLUAibhNFEpcl8DAONcmKwIwPT tKP6nNaC7Jjjg== Date: Thu, 27 Apr 2023 18:15:44 +0100 From: Lee Jones To: "larry.lai" Cc: andriy.shevchenko@linux.intel.com, linus.walleij@linaro.org, pavel@ucw.cz, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-leds@vger.kernel.org, GaryWang@aaeon.com.tw, musa.lin@yunjingtech.com, jack.chang@yunjingtech.com, noah.hung@yunjingtech.com, michael.wang@yunjingtech.com Subject: Re: [RFC RESEND 3/3] leds: Add support for UP board CPLD onboard LEDS Message-ID: <20230427171544.GF620451@google.com> References: <20230425152135.30745-1-larry.lai@yunjingtech.com> <20230425152135.30745-4-larry.lai@yunjingtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230425152135.30745-4-larry.lai@yunjingtech.com> X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Apr 2023, larry.lai wrote: > The UP boards come with a few FPGA-controlled onboard LEDs: > * UP Board: yellow, green, red > * UP Squared: blue, yellow, green, red > > This patch depends on patch "mfd: Add support for UP board CPLD/FPGA". > > Reviewed-by: Andy Shevchenko > Reviewed-by: Lee Jones Definitely not. Please try again after reading: Documentation/process/submitting-patches.rst > Signed-off-by: larry.lai > --- > RFC 2022/11/23 --> RFC 2023/04/25: Refer 2022/12/08 Lee Jones review, > cleaned up coding style. > PATCH V3 -> RFC 2022/11/23: Update the changes Copyright. > PATCH V1 -> V3: There is no change. > PATCH --> PATCH V1: Refer 2022/10/03 Andy Shevchenko review, cleaned up > coding style. > --- > --- > drivers/leds/Kconfig | 10 +++++ > drivers/leds/Makefile | 1 + > drivers/leds/leds-upboard.c | 79 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 90 insertions(+) > create mode 100644 drivers/leds/leds-upboard.c -- Lee Jones [李琼斯]