Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Thu, 27 Apr 2023 20:26:43 +0300
Message-Id: <CS7PQGHNLIGG.1PDQ1S2D9QG79@wks-101042-mac.ad.tuni.fi>
Subject: Re: [PATCH] tpm: Re-enable TPM chip boostrapping non-tpm_tis TPM
 drivers
From:   "Jarkko Sakkinen" <jarkko@kernel.org>
To:     "Lino Sanfilippo" <l.sanfilippo@kunbus.com>,
        "Pengfei Xu" <pengfei.xu@intel.com>
Cc:     <linux-integrity@vger.kernel.org>,
        "Peter Huewe" <peterhuewe@gmx.de>,
        "Jason Gunthorpe" <jgg@ziepe.ca>, <linux-kernel@vger.kernel.org>,
        <heng.su@intel.com>
References: <20230426185833.289868-1-jarkko@kernel.org>
 <ZEnWykDF6kbZ8nVi@xpf.sh.intel.com>
 <a258fcd353d67e918a0c86a59e27bf1332764a7b.camel@kernel.org>
 <27e8289e-21a4-7d7a-231f-4a27334dd1f9@kunbus.com>
In-Reply-To: <27e8289e-21a4-7d7a-231f-4a27334dd1f9@kunbus.com>
Precedence: bulk

On Thu Apr 27, 2023 at 6:33 PM EEST, Lino Sanfilippo wrote:
>
> Hi Jarkko,
>
> On 27.04.23 12:52, Jarkko Sakkinen wrote:
> > ATTENTION: This e-mail is from an external sender. Please check attachm=
ents and links before opening e.g. with mouseover.
> >=20
> >=20
> > On Thu, 2023-04-27 at 09:58 +0800, Pengfei Xu wrote:
> >> On 2023-04-26 at 21:58:33 +0300, Jarkko Sakkinen wrote:
> >>> TPM chip bootstrapping was removed from tpm_chip_register(), and it
> >>> was relocated to tpm_tis_core. This breaks all drivers which are not
> >>> based on tpm_tis because the chip will not get properly initialized.
> >>>
> >>> Take the corrective steps:
> >>> 1. Rename tpm_chip_startup() as tpm_chip_bootstrap() and make it one-=
shot.
> >>> 2. Call tpm_chip_bootstrap() in tpm_chip_register(), which reverts th=
e
> >>>    things  as tehy used to be.
> >>            ^ two space and one typo "they"
> >>          Thanks for your fixed patch in short time!
> >>
> >>   And I tested this patch, it could not be reproduced in 155s, and the=
 patch
> >>   fixed this issue.
> >>   Fixed dmesg is in attached.
> >>
> >> Tested-by: Pengfei Xu <pengfei.xu@intel.com>
> >=20
> > Thanks a lot! I'll take immediate action to send PR to Linus.
> >=20
> > Lino: no worries. It was expected that such a large refactorization
> > could break a thing or two. You did a good job in any case.
> >=20
> > BR, Jarkko
>
> I guess you are right, there will probably be more issues showing up
> in the next time. I will try my best to help fixing them.
> Thank you very much (also for fixing this issue)!

Yeah, no worries, that is my responsibility in the end to take care of
whatever I accept :-) And yeah, this was complicated change to do, I
think you did your best and that is good enough as far as I'm concerned.

BR, Jarkko