Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Apr 2023 13:25:44 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Peng Zhang <perlyzhang@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        maple-tree@lists.infradead.org,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 25/34] maple_tree: Clear up index and last setting in
 single entry tree
Message-ID: <20230427172544.4vef5cr52elebiom@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Peng Zhang <perlyzhang@gmail.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, maple-tree@lists.infradead.org,
        Andrew Morton <akpm@linux-foundation.org>
References: <20230425140955.3834476-1-Liam.Howlett@oracle.com>
 <20230425140955.3834476-26-Liam.Howlett@oracle.com>
 <578db833-e20a-cec8-c00f-5cd1e8959ccf@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <578db833-e20a-cec8-c00f-5cd1e8959ccf@gmail.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVV1T2NVeXhVcjFld3hKUnRBMS8zdEY0VTJ4UVlPSDBYMmgzZWc1RDM0RVF2?=
 =?utf-8?B?dDNaMFYxblF0RUNPNldrdXFkcXlvOEltdldRS0t3NXdrS2lKMDAwQkkxU3lV?=
 =?utf-8?B?eUF0VjNuQmhRcVF1MS9OZXFIK2t5TDJxclNMUXNwK1FnTDdmMVFJTUg2L25W?=
 =?utf-8?B?dk1oUExSYjJEWTRjOUgyTEtrOWl3UkhOMklsTmM5cWo3NUZhdk1iZ3U5MUJJ?=
 =?utf-8?B?ZEs1cDFzUWk4S1pIOFBZbmNLaVhIWm9LcG1JdlZZS3lwdnJpaC8zYWJOQWRO?=
 =?utf-8?B?OUUveUxEL1V5dVREelNFcnlGS2psSGdOK1JKcUJDYU1TK2F6bnRyRTV2S1Uy?=
 =?utf-8?B?NmJmUVJrTS84aHV3WGw0NGdBYkZKZGFyQUZrdHBnT1dLSWoyV25udWFKZHk4?=
 =?utf-8?B?WklwRlZicnJXTytJOFlzYk5aQXZTLzBMQTg5eEhSaEZoRTAxNm56SEhlazlC?=
 =?utf-8?B?MmJKODFCbHkvbHY3WHkraVMwR1FhenR4cFFhN2htY2F6S0VQUDN5ZHJ4VXlT?=
 =?utf-8?B?REY5d3JSUXFYWTFHa2JKaHM5ZXFCaFlNY2hIM3JBTG1ER1ZwanhzaFlEemhq?=
 =?utf-8?B?MGxHWXZ1Rm9xQnNOMlU1dVZPWHJ6M3BpRUFoSUg1WkJOVjhIUm5vNVBXQkhv?=
 =?utf-8?B?d2JCaEVOMWgwVkJhK1IrRlBjZFRkZFBkMmR1LzBsendJWXlCRi9RVUp3WFg4?=
 =?utf-8?B?TE5MUi94SkovWHpyOUZEWm9DcHE2TnprTTRzNnhWTlpjZ3gvTDdOV29sTUdn?=
 =?utf-8?B?ejgrUVhwM1RLbHFyOEhJc09pdWNDU3hFNGN6dWc5d3hKbk5DeVVKMysvTVJy?=
 =?utf-8?B?TWNra0hlMVpNWncrc1lxSkZIcEo3VFk5amxGbDI4QkM1dDJpVmNCV2ZiRWhW?=
 =?utf-8?B?QjZtelpkQjF1c1hwRlV2ZHk0b1RFOExoSG9Rc2Q1d0hUS3Y1TzZlbUZCNjRG?=
 =?utf-8?B?ODdibVpqV1o2RnA4aUk5S2ZpMGlMQjR5aDlIQm51ZmpMYXFQZnllM05JMkJK?=
 =?utf-8?B?RGdGM2dBU1lPazk2WnpkaEMyRVYzN1RlemU5UzhaejhaTzRINmpKTnBselRS?=
 =?utf-8?B?cUFxSmJqTk02d0EwMDZCSzFNWkl1OWs5RDRXL1I5YjRrdEcrVkVzQitQUE1C?=
 =?utf-8?B?VGR0WS90b0JDZGx3bE0zSDcrSlZxb2t1TGh0a3NicG9TNUJCeHk2aEQzYmt1?=
 =?utf-8?B?cElKZkkvaGQ5S2g1dWNkVWRnamQ0N1FBeVdCaFBSS3dNMmhvWGJZNmIwNkkv?=
 =?utf-8?B?RXJyeE4vbFZDTXJieExSdFRUbmJWZTR2MGZOTlZvazdYWnIrRmtWaVVnL0pQ?=
 =?utf-8?B?V1NiYkxKT3A4UTBhaGtsWHR3NTQ4MVNuWXRrOE9NdFJHR3AvU3dYNWNLNmpF?=
 =?utf-8?B?b0dGL1ROYTgxRmZ2ZkFNSW5lUnlLanRGZEEwUWNqa1IzMTFyV05WdVhKc3M0?=
 =?utf-8?B?RjNKR1hHS1VLM01ING1Jc3phbENpZHhvOUthUWJoZDlxbjFjeDdoYmNyNW5B?=
 =?utf-8?B?cklLdnA1YUYvWXROd0R3bWR1a01nc2IxK1RXOVhCbVhrM3NLbDlzV083LzBC?=
 =?utf-8?B?Tm0zNUpuUnAwLzRZSDRMaTUycjBlQjVicGkrQTdhVjl2amltNnZqT25Nd0Np?=
 =?utf-8?B?S1RIamE5b2JvMW9JdHFsL1UxZ0pzU1djV0phT3IrbUxqOWpqMU9MdmRZWjBE?=
 =?utf-8?B?OW9CWC9QNmkvNUlVeEFXZTZya2F4MnkwbXpzYkxjNDdxaUxIY1A1ODB0TkF6?=
 =?utf-8?B?S2dsT3RiQ05PVW9jVUFkVG1PeGRBUzExSzlDTmp3QkJ6ZUljeWd6MG02TytM?=
 =?utf-8?B?Zm9HUyt6N1VwYkxnam54MisvUzFLYUFJRkZqWExIYTdwK3BkdUtNYkVndTBO?=
 =?utf-8?B?UU1GWEhxcVZXVWtXK0I0VUhhV0NMamtZT0RsdmNFYWlOOFE0YmZuaDYzbnZT?=
 =?utf-8?B?K3dnNGIwLzRrYnp3eWNIOWwwL2xVKzVMZXZtakNsMmIrbUJweHU0YWc1RGVB?=
 =?utf-8?B?dEpsdHExbUJIK0dnU1dwM3hxbUJ0QkpCSmpZcjR1M0hlOWNxTDlVcGM2R0dB?=
 =?utf-8?B?Ujh0b0V0MnVJYmkrVUx0bVFqNnEwS0pnTVJZMDhRNXYwYzIrTmJLRzZQL3ZW?=
 =?utf-8?B?Qm5aNU1MUEo2cGlsR2tPdS9ZRWk5MDhFY29aanIydUVxSXRRS0IrcGpHc29T?=
 =?utf-8?B?Znc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 74pT9nMzQu4z34P9IDyZhZWXYDCcRLBH6Dx8MdD1O459cBUfQua9G55ftjgxJT2VeiehHLOQCgsaN6Jktw26Q/tPjl8NO/7HdmXUqMNwFvOHBDioTsPQvTUGrFjOQrCo/YkEBKXlx58jEm7SMrzSO5VJUb9alzvNFIbPy8b7iCt9iBIs61d+jMIClhJm0hPUH7aEapCURwEArONLCfkxPV1ZFLXmA+zD0x/DeAylaVtcjyJ7Dg4B53+WFu4YJ/YienlPUb4iSyvIJPA6+NLXUpehzbG5iLgzAwsm59rBoz/RgQiXTSkte1e9IT6s5qMo5zM6pDEXel0pMPKYmIy/r6p0o3YZxJCdWemraHqfPUMaGQSS8mmIk6Jmd5E9ZkjlwoSVMatR6ZwXMtOimgOAMVWhJ9VvArPp/G+Tl722THoqeq8z3hpocUI6vy4FXtTLAhVS3/vp3a/cxeB7Gy80hrrc7lRbBL3giiP+GQoU16ij3DZSsso/mpkWmE8MzWRtFOmdv/cLZqwYEhopkVV2uAmMZsqDk1M+K0xiM5Mq3dlMRDKvJATqBJCYrUOmlHqnOmNqdbbYdtG13pAy36x+JENJwQZriHDNjYe/Z4jhOg3JLhkL54JoLKspBp3lh6Vlv5Q0rpwMNbpTtUTtAQiO2W8wyD2U3m4RVh317qUSj9dffdc4J9VFQGhMIMLxqj+hdOp83JHBI1iTbEcGO6HTKPlFuR6LLiKV+Dy6qQeOKYXazDgNZHX/7C5yCiGl3uZwUwvrgUuKnfCjFyEJfzCY985+pxBajAmQvgV1vZDjgYGOpUJCNJrmlnnRhJcIWvzQcDwetNCr+Xum8LRUyNO5L6NVngpWH+QxGrkk3rP6Y3qv3HIbWM9a4xKy8fxA1qIpSCO2nMoh1pcYtN2/9lfCrl3OXXUt+cG/HldJ1xv/xbw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fc49d20-c292-4381-7e66-08db474470c4
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2023 17:25:48.1831
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2pisDvyv9+gBuMIf8Ba0QGFw/7Av7GNEyD+m7O7cBfNB5xy2DTkDwdelSrXhMoApdR1QhcrCfVevXi1BZAQbow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5704
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-27_07,2023-04-27_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=994 suspectscore=0
 malwarescore=0 mlxscore=0 spamscore=0 adultscore=0 phishscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304270152
X-Proofpoint-GUID: tvDum-IWKy8KgHxaLZ_zl_Kydv4uAE4V
X-Proofpoint-ORIG-GUID: tvDum-IWKy8KgHxaLZ_zl_Kydv4uAE4V
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Peng Zhang <perlyzhang@gmail.com> [230427 07:20]:
>=20
>=20
> =E5=9C=A8 2023/4/25 22:09, Liam R. Howlett =E5=86=99=E9=81=93:
> > When there is a single entry tree (range of 0-0 pointing to an entry),
> > then ensure the limit is either 0-0 or 1-oo, depending on where the use=
r
> > walks.  Ensure the correct node setting as well; either MAS_ROOT or
> > MAS_NONE.
> >=20
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> > ---
> >   lib/maple_tree.c | 21 +++++++++++----------
> >   1 file changed, 11 insertions(+), 10 deletions(-)
> >=20
> > diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> > index 20f0a10dc5608..31cbfd7b44728 100644
> > --- a/lib/maple_tree.c
> > +++ b/lib/maple_tree.c
> > @@ -5099,24 +5099,25 @@ void *mas_walk(struct ma_state *mas)
> >   {
> >   	void *entry;
> > +	if (mas_is_none(mas) || mas_is_paused(mas))
> > +		mas->node =3D MAS_START;
> >   retry:
> >   	entry =3D mas_state_walk(mas);
> > -	if (mas_is_start(mas))
> > +	if (mas_is_start(mas)) {
> >   		goto retry;
> > -
> > -	if (mas_is_ptr(mas)) {
> > +	} else if (mas_is_none(mas)) {
> > +		mas->index =3D 0;
> > +		mas->last =3D ULONG_MAX;
> > +	} else if (mas_is_ptr(mas)) {
> >   		if (!mas->index) {
> >   			mas->last =3D 0;
> > -		} else {
> > -			mas->index =3D 1;
> > -			mas->last =3D ULONG_MAX;
> > +			return mas_root(mas);
> Why we call mas_root() to get the single entry stored in root again?
> I think it's not safe. In RCU mode, if someone modify the tree to a norma=
l
> tree(not a single entry tree), mas_root() will return a address.
> So, this may cause a race bug. We can return entry directly.

Good catch.  I will address this in v2.

> >   		}
> > -		return entry;
> > -	}
> > -	if (mas_is_none(mas)) {
> > -		mas->index =3D 0;
> > +		mas->index =3D 1;
> >   		mas->last =3D ULONG_MAX;
> > +		mas->node =3D MAS_NONE;
> > +		return NULL;
> >   	}
> >   	return entry;