Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230427114745.53136-1-arefev@swemel.ru>
In-Reply-To: <20230427114745.53136-1-arefev@swemel.ru>
From:   Ping Cheng <pinglinux@gmail.com>
Date:   Thu, 27 Apr 2023 10:56:40 -0700
Message-ID: <CAF8JNh+ps2F=vCr6GwpB7NAj8-graAw1-oCV2DonJWw8YA8p9g@mail.gmail.com>
Subject: Re: [PATCH] HID: wacom: Added error check
To:     Denis Arefev <arefev@swemel.ru>
Cc:     Ping Cheng <ping.cheng@wacom.com>,
        Jason Gerecke <jason.gerecke@wacom.com>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        lvc-project@linuxtesting.org, trufanov@swemel.ru, vfh@swemel.ru
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Apr 27, 2023 at 5:07=E2=80=AFAM Denis Arefev <arefev@swemel.ru> wro=
te:
>
>    Added a variable check and
>    transition in case of an error
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Denis Arefev <arefev@swemel.ru>

Thank you Denis for working on the patch! The patch LGTM.

Reviewed-by: Ping Cheng <ping.cheng@wacom.com>

Cheers,
Ping

> ---
>  drivers/hid/wacom_sys.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index fb538a6c4add..aff4a21a46b6 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -2417,8 +2417,13 @@ static int wacom_parse_and_register(struct wacom *=
wacom, bool wireless)
>                 goto fail_quirks;
>         }
>
> -       if (features->device_type & WACOM_DEVICETYPE_WL_MONITOR)
> +       if (features->device_type & WACOM_DEVICETYPE_WL_MONITOR) {
>                 error =3D hid_hw_open(hdev);
> +               if (error) {
> +                       hid_err(hdev, "hw open failed\n");
> +                       goto fail_quirks;
> +               }
> +       }
>
>         wacom_set_shared_values(wacom_wac);
>         devres_close_group(&hdev->dev, wacom);
> --
> 2.25.1
>