Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230426225458.877481-1-olvaffe@gmail.com>
In-Reply-To: <20230426225458.877481-1-olvaffe@gmail.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Thu, 27 Apr 2023 14:50:57 -0400
Message-ID: <CADnq5_MEc_YAfts-wWEZVsm=bJLv5CT65qNX8c-qj_VZsxnS5A@mail.gmail.com>
Subject: Re: [PATCH v3] drm/amdgpu: add a missing lock for AMDGPU_SCHED
To:     Chia-I Wu <olvaffe@gmail.com>
Cc:     dri-devel@lists.freedesktop.org,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>, linux-kernel@vger.kernel.org,
        amd-gfx@lists.freedesktop.org,
        Andres Rodriguez <andresx7@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Alex Deucher <alexander.deucher@amd.com>,
        David Airlie <airlied@gmail.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

Alex

On Wed, Apr 26, 2023 at 6:55=E2=80=AFPM Chia-I Wu <olvaffe@gmail.com> wrote=
:
>
> mgr->ctx_handles should be protected by mgr->lock.
>
> v2: improve commit message
> v3: add a Fixes tag
>
> Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
> Reviewed-by: Christian K=C3=B6nig <christian.koenig@amd.com>
> Fixes: 52c6a62c64fac ("drm/amdgpu: add interface for editing a foreign pr=
ocess's priority v3")
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c b/drivers/gpu/drm/=
amd/amdgpu/amdgpu_sched.c
> index e9b45089a28a6..863b2a34b2d64 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c
> @@ -38,6 +38,7 @@ static int amdgpu_sched_process_priority_override(struc=
t amdgpu_device *adev,
>  {
>         struct fd f =3D fdget(fd);
>         struct amdgpu_fpriv *fpriv;
> +       struct amdgpu_ctx_mgr *mgr;
>         struct amdgpu_ctx *ctx;
>         uint32_t id;
>         int r;
> @@ -51,8 +52,11 @@ static int amdgpu_sched_process_priority_override(stru=
ct amdgpu_device *adev,
>                 return r;
>         }
>
> -       idr_for_each_entry(&fpriv->ctx_mgr.ctx_handles, ctx, id)
> +       mgr =3D &fpriv->ctx_mgr;
> +       mutex_lock(&mgr->lock);
> +       idr_for_each_entry(&mgr->ctx_handles, ctx, id)
>                 amdgpu_ctx_priority_override(ctx, priority);
> +       mutex_unlock(&mgr->lock);
>
>         fdput(f);
>         return 0;
> --
> 2.40.1.495.gc816e09b53d-goog
>