Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Hawkins, Nick" <nick.hawkins@hpe.com>
To:     "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>
CC:     "Verdun, Jean-Marie" <verdun@hpe.com>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        "brgl@bgdev.pl" <brgl@bgdev.pl>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "jdelvare@suse.com" <jdelvare@suse.com>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v1 1/9] gpio: gxp: Add HPE GXP GPIO
Thread-Topic: [PATCH v1 1/9] gpio: gxp: Add HPE GXP GPIO
Thread-Index: AQHZcgrpODxMvy9ha06K9TX/iHoHda8/ZmMAgAAkIQA=
Date:   Thu, 27 Apr 2023 19:01:17 +0000
Message-ID: <DM4PR84MB19272617D9E728DC09715A45886A9@DM4PR84MB1927.NAMPRD84.PROD.OUTLOOK.COM>
References: <20230418152824.110823-1-nick.hawkins@hpe.com>
 <20230418152824.110823-2-nick.hawkins@hpe.com> <ZEqikkknyRrFTh2t@surfacebook>
In-Reply-To: <ZEqikkknyRrFTh2t@surfacebook>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zk2/Ra6bkjTGGBoR0N4WZzeROX/ZVy1p2XS7yUnFSrashD90RwfqfCSnjR3i?=
 =?us-ascii?Q?83LJTSHrkf6/wnely+cOWhvS2f1dJ4457Jy7EqiVsEX3RtL4wzTAbHaTU1T4?=
 =?us-ascii?Q?SbbAV0Y1w2eVq4ueR+Q5exHUJZ86T+c7aH+SiV1W7eKVAraCvMlGcW6twAwA?=
 =?us-ascii?Q?e51EQNsecgv+SIbs6NhHzSLtUy9zKbDjjc2FCoJ99PCFs/OMXTB8v2t7NdcQ?=
 =?us-ascii?Q?K/g1ug6PfjzxbseVJyHuKclqiZyND5n9fD/s96HQufRBiKihTVm+tbVcdfiu?=
 =?us-ascii?Q?r15OaD1Wxb0+HFntsnsdqTbbPbYXmkE7IqVvko8xW8Yu2XaLRVvWjYgBc45W?=
 =?us-ascii?Q?QvKrRYA4XBBeH3G4KIVjmKa+gLAm2y6V/nhkbIQqm3f////plASUJIQ13Lcf?=
 =?us-ascii?Q?+smFGa566OcLlX53ZjG4wcOVx0XALzerObON4Bn9PsuZUCkuZLTXdLx8W9jO?=
 =?us-ascii?Q?KWdVidNxXAVVGAr3TsMD9nuJ67IMfccUMrrUeZOV3XUJ8qFniDC4DljaAZMo?=
 =?us-ascii?Q?Pw8xuvSL8oRXcKuYg9yWxzdYtSgm5cjEefgHlZyTcpG0Wr1lzFJyq7eQVEis?=
 =?us-ascii?Q?sKzC3Ol7KZV9l/+4DbBS6HglY/n3rom0FZqSW2+XtRry1oya12LEH7DreFuY?=
 =?us-ascii?Q?R9cH06wFNQd/K9A1nw4NUQ5c5nFhrCwG7eBTMPRHTewtWtS0/vz6rw4DPsG3?=
 =?us-ascii?Q?B2AjdxQQRG1fRoUOy+2JFfSdGmpxXpct1eAq7PgRle7kyVZYr8AT2yrECVlF?=
 =?us-ascii?Q?W3AXd0t/P8CGCqAjfakDkam112xt9dcNGaiGu+sMaAo01ImGg5VNuBNOKZPY?=
 =?us-ascii?Q?/9jn0NLFTTyYauEABwdw+bDPtzTfF437ONPU2PalcHCu9WU9sOQJpvKzj1Eh?=
 =?us-ascii?Q?KQm+VJepPR19C3eXLYengGvOFCcyb5IKfNBMbAWHrRBsDnJq7CuPSd6szxMD?=
 =?us-ascii?Q?N52cBXloyyrIG6x4zte6d/FGEElBLHIaA6Rm6jK8qqQwJJnnbGE3KFuM4Dzu?=
 =?us-ascii?Q?m8PM2f0Cwl7jtvyQoLQOMjbKm7Q/MKPiIF/tew2xjMVTVRLCjmVr+IfDlIvh?=
 =?us-ascii?Q?if+8FEnBQhGm4I7hBGdxaPXzPc+KbyPJ6mWmNybaIyB4ouaD3kj5EbU8c5nh?=
 =?us-ascii?Q?Ya9dysiH9I8Srdcg/DJrYejnNNZYLMC5941hqji4WB33netRq9SGLLlxlY5y?=
 =?us-ascii?Q?Vv0TBmKfnhq9sbSB4+M9p7tKGhZFS1jXJT8SunFrzJbYoD8BLC6A6GgWP/1F?=
 =?us-ascii?Q?UrmgmTlKyCgZNPXfvn/35jCwysimjt1CaEClcql05Y3d7m+fy6VHtNbhErpR?=
 =?us-ascii?Q?Pto2RyaSQ8EHZHEAzFwMP1V4y0UHFRv9mDGyiMCekJJFMZbKAyCzBGCDBLhT?=
 =?us-ascii?Q?WyiEKpbwwnat9fO5TPIfE9avFA3yPLCs7KvCt2v+hFzHdH0HRFX9o0EtHXw5?=
 =?us-ascii?Q?xUFYBu77/UuJomHq2DWL9mgAJRFHgtT96ndylO1oCdDiJEMJdkQHtUyQrrl0?=
 =?us-ascii?Q?HSpgREb9sHUAuvUO8k31o7Mg2juYOWeZ7JoHULKdxUSq62ocR//JIpLzXp8i?=
 =?us-ascii?Q?jhLSyxKECe53tLLoXSA/ryOgYFH74MTBacE7SNLD?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR84MB1927.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: d5da3ee9-9c28-4a6b-f02e-08db4751c7f0
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2023 19:01:17.5110
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NqS8pySHJoIjfHwx2Bb/hPEuB6QOecfXOAP+JT/2/E6xw2OwNAryrdHCFgSIQxD2PqJ8/tv2W7Rq5fYHXchK5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR84MB1807
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: rQNgkIGfT_GbYMBatIlfm0FLTh5EK9z4
X-Proofpoint-ORIG-GUID: rQNgkIGfT_GbYMBatIlfm0FLTh5EK9z4
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-27_09,2023-04-27_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0
 mlxlogscore=654 suspectscore=0 impostorscore=0 adultscore=0 mlxscore=0
 spamscore=0 priorityscore=1501 clxscore=1011 lowpriorityscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304270166
X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> Thank you for your contribution. To begin with, I don't believe a simple =
GPIO
> driver needs 1000+ LoCs. But see more comments below.

Andy,

Thank you for your feedback. I will apply all the input you have provided.

I will need to rewrite this code and I am considering the need to
perhaps create two files instead of one to keep code length down. As
implied by the description I was trying to have one file handle two
different compatible strings.

I believe that one file will need to be the regular IO from the host and
memory mapped IO pins of our SoC. The other will need to be the memory
mapped IO pins coming from our CPLD. Both of these sources are interruptibl=
e
which does cause some complexity.

Please let me know if what I have described above is not a good approach to
take with GPIO drivers. Any guidance would be greatly appreciated.

Best Regards,
-Nick Hawkins