Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Apr 2023 12:06:27 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Raghu H <raghuhack78@gmail.com>, <linux-cxl@vger.kernel.org>,
        "Alison Schofield" <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>
CC:     <linux-kernel@vger.kernel.org>
Subject: Re: [STYLE v1 2/3] cxl/core/port: Use tabs to fix styling errors
Message-ID: <644ac7b3e5354_182a929456@iweiny-mobl.notmuch>
References: <20230419111443.231151-1-raghuhack78@gmail.com>
 <20230419111443.231151-3-raghuhack78@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230419111443.231151-3-raghuhack78@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vc3X5syuAT/cH8xmW2IA8C3bLbnPycPTazkXL0k82O20jQ4SilWhE5JAx0ZN?=
 =?us-ascii?Q?skY66p33UdGfsTcKsXiMNZpdMVE9WUHBHkp9cUfURQmuXwWMmUWOzP8zTS9Q?=
 =?us-ascii?Q?WNfvhRYEHfY8i9hm015UwkxgWEQeDYLcgIkaVDIUPqgwn6l7gjxpQ8qWYWnS?=
 =?us-ascii?Q?eDogqcFK5qzQ9FuNEo3G3L12U51yb5xYxpyj18Oug1fjW45ao9oB/b7z1Z0m?=
 =?us-ascii?Q?zFU5wyCZH9vW2I3lFsOgOBi6HL284TB6uvomsbqUdXo4L0xZtwqwNRPRr3W1?=
 =?us-ascii?Q?4BwXXMDH5R9Q0R/DBStccF/QmnGto4tmFIvdu3kWBJJpD3icpEowjoI3088y?=
 =?us-ascii?Q?gnPa0kDn3iKXaKs3GeReBFwlY4kYN5IRljW3mUFsZAf+zcwqOUvKk+hyzoBa?=
 =?us-ascii?Q?oT+xNUBrLfJLTuDtNYRl7zMiGNiBXD1NbyltmyqWrxrF4dBfzRcs2vm/Ju50?=
 =?us-ascii?Q?bHmnXRtTDyMavNI4Aym0c7nBytSE7Tcmd6Sj+68NReqMri+RTPoAPTRuFFSy?=
 =?us-ascii?Q?iPjWRJe/KewjtIuNAfTDuPcUO1P8OBStvkoNfa7JtSTkTTXrslsdQpnKXOI0?=
 =?us-ascii?Q?YzRk/hGJEnjgvhi8EQftVEgV2JB/cN0nBfwfmm9V4irJlAbxHBb6ptOtgIBZ?=
 =?us-ascii?Q?pZsVXRtW5jkmvQ0NBIPs3E//t+v4BPYsH7toGWoovcbgLxlDMcoThVucDtYl?=
 =?us-ascii?Q?5DoV4NxhsPQcSCh367UT5tw3Ghji0uHpAY2KxgawoG6GYndJ53zyvJ4f5S8Z?=
 =?us-ascii?Q?swh6RZeDu2xxHgozq/4bbwbggE1cDsHFS7pVQ8xx7kzvsLM3OsPeNiCB7XrF?=
 =?us-ascii?Q?ox3DFb00sSeoYPYPFI3A2i1VHv56lobNJsjizXoxyoTL7M4n/o5A0SITk5Qu?=
 =?us-ascii?Q?AclfFQ/egKlBOMx8o8QZS3GfwtoZqWNd74A0bijjcS58nS0n5ttRkN916MOh?=
 =?us-ascii?Q?RHY07i9QjYrtBDPQPDoChIomnu9lsBqOr1fXAZp8nc40h8tys6m0kAu5PI8i?=
 =?us-ascii?Q?Pcv3PG+I18+LqV8pk90DX1Nsrals3zfpsSchwoWZ5IypzpmboHNVb6AyXQ5P?=
 =?us-ascii?Q?7C3q6F/pIpTN47zZiADSogElXCFFajV9y0rke4jPBJtVq1K7AhUMlP30yV0P?=
 =?us-ascii?Q?2uEdJsumxz8LGsX/Yp0Wf5eKCksiwMpis1UHZqUT+iQuOaHy+C+hoHSugcY8?=
 =?us-ascii?Q?LEkrDFrgCV+/lxLGH8QmPFFFpCKnL6JfLmvI6n5w2fQ7WmawROsy8toI7J8F?=
 =?us-ascii?Q?+IWvoajk08SJaORDNGgLpKCKNEuXclbfrifSPeQGvcKV6os3BN2HoEcxssTn?=
 =?us-ascii?Q?pma0j/8ZaZ3X4XgERISACTYibW4qZzcr3XmVqOwT6Zbo4IF5lNTuc4Y9Oty2?=
 =?us-ascii?Q?v3ambMXflbwYorQ7Q7yBxt8sGj8ti++tnoqGCqUcTozbjIWgaZQ1symmdcLs?=
 =?us-ascii?Q?DjLXEULfGdS1bqPtZ6IRe7+6hSl1OX9DOomBMNEvDE2Q4PZV+5DgNZW03/PD?=
 =?us-ascii?Q?VzJTTiswyNzltkHvBJtaz3xJP7b4a16phhX0TpfQLgiMNTVWSSFGIVL/oqbf?=
 =?us-ascii?Q?B98amPUy+UWN9Vkd/Qco06ZGmZWA3wRfRsYQqIZg?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 06f36db5-dce3-48fc-278c-08db475282c6
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2023 19:06:31.1626
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mi8xeK2KY1z13GipLB4LdSn/gb76k7lK3ly8/DElAMSDpbm/j1WKZoWQDBfzRMfVlFnO+/e0LbBPK364175+1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5394
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Raghu H wrote:
> Styling errors due to linux of unwanted spaces in the definition,
> modified the definition to use tab to fix the styling issue.
> 
> Signed-off-by: Raghu H <raghuhack78@gmail.com>

NAK

This is unnecessary churn.  The formatting of the file is fine and very
readable.

Ira

> ---
>  drivers/cxl/core/port.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> index 8ee6b6e2e2a4..7c3aaed180ca 100644
> --- a/drivers/cxl/core/port.c
> +++ b/drivers/cxl/core/port.c
> @@ -95,15 +95,15 @@ static ssize_t size_show(struct device *dev, struct device_attribute *attr,
>  }
>  static DEVICE_ATTR_RO(size);
>  
> -#define CXL_DECODER_FLAG_ATTR(name, flag)                            \
> -static ssize_t name##_show(struct device *dev,                       \
> -			   struct device_attribute *attr, char *buf) \
> -{                                                                    \
> -	struct cxl_decoder *cxld = to_cxl_decoder(dev);              \
> -                                                                     \
> -	return sysfs_emit(buf, "%s\n",                               \
> -			  (cxld->flags & (flag)) ? "1" : "0");       \
> -}                                                                    \
> +#define CXL_DECODER_FLAG_ATTR(name, flag)				\
> +static ssize_t name##_show(struct device *dev,				\
> +			   struct device_attribute *attr, char *buf)	\
> +{									\
> +	struct cxl_decoder *cxld = to_cxl_decoder(dev);			\
> +									\
> +	return sysfs_emit(buf, "%s\n",					\
> +			  (cxld->flags & (flag)) ? "1" : "0");		\
> +}									\
>  static DEVICE_ATTR_RO(name)
>  
>  CXL_DECODER_FLAG_ATTR(cap_pmem, CXL_DECODER_F_PMEM);
> -- 
> 2.39.2
>