Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Apr 2023 22:26:19 +0200
From:   Marijn Suijten <marijn.suijten@somainline.org>
To:     Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        freedreno@lists.freedesktop.org, Rob Clark <robdclark@gmail.com>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, quic_jesszhan@quicinc.com,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] drm/msm/dpu: remove GC related code from dpu
 catalog
Message-ID: <lbd7vhrjbl5lsno2gc2pdd56rp7n4lfhmr5xvbxnjwaacn4nub@7p27sam6t6gp>
References: <20230426192246.5517-1-quic_abhinavk@quicinc.com>
 <20230426192246.5517-3-quic_abhinavk@quicinc.com>
 <a1a4f31e-b591-498d-d99e-872661d154d1@linaro.org>
 <5b0fb557-482b-a3df-613e-371eddfee93b@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5b0fb557-482b-a3df-613e-371eddfee93b@quicinc.com>
Precedence: bulk

On 2023-04-27 13:20:28, Abhinav Kumar wrote:
<snip>

> >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
> >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
> >> @@ -127,12 +127,10 @@ enum {
> >> ? /**
> >> ?? * DSPP sub-blocks
> >> ?? * @DPU_DSPP_PCC???????????? Panel color correction block
> >> - * @DPU_DSPP_GC????????????? Gamma correction block
> >> ?? * @DPU_DSPP_IGC???????????? Inverse gamma correction block
> >> ?? */
> >> ? enum {
> >> ????? DPU_DSPP_PCC = 0x1,
> >> -??? DPU_DSPP_GC,
> >> ????? DPU_DSPP_IGC,
> > 
> > Don't we need to remove this one too (in the previous patch)?
> 
> Yes, we should. I thought of it right after sending this. will push a v3 
> which fixes it in the prev patch.

Yes please.  Don't forget to mention that dpu_dspp_sub_blks didn't even
have an igc member describing the block.

- Marijn

> >> ????? DPU_DSPP_MAX
> >> ? };
> >> @@ -433,22 +431,18 @@ struct dpu_sspp_sub_blks {
> >> ?? * @maxwidth:?????????????? Max pixel width supported by this mixer
> >> ?? * @maxblendstages:???????? Max number of blend-stages supported
> >> ?? * @blendstage_base:??????? Blend-stage register base offset
> >> - * @gc: gamma correction block
> >> ?? */
> >> ? struct dpu_lm_sub_blks {
> >> ????? u32 maxwidth;
> >> ????? u32 maxblendstages;
> >> ????? u32 blendstage_base[MAX_BLOCKS];
> >> -??? struct dpu_pp_blk gc;
> >> ? };
> >> ? /**
> >> ?? * struct dpu_dspp_sub_blks: Information of DSPP block
> >> - * @gc : gamma correction block
> >> ?? * @pcc: pixel color correction block
> >> ?? */
> >> ? struct dpu_dspp_sub_blks {
> >> -??? struct dpu_pp_blk gc;
> >> ????? struct dpu_pp_blk pcc;
> >> ? };
> >