Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Apr 2023 17:12:13 -0400
From:   Hugo Villeneuve <hugo@hugovil.com>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Fabio Estevam <festevam@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        Hugo Villeneuve <hvilleneuve@dimonoff.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Message-Id: <20230427171213.480d1d3ba1576edc8198e5f0@hugovil.com>
In-Reply-To: <31610e60-5c1e-4d19-9beb-83b49ef26155@lunn.ch>
References: <20230427195538.2718661-1-hugo@hugovil.com>
        <CAOMZO5CQeeme6uhb8NCzR2QADjkBM-mRC9-GUnmhLWSGo5MMoQ@mail.gmail.com>
        <20230427160608.f051241d750404939296f60d@hugovil.com>
        <CAOMZO5BNbRV1fLpwDZWgj9+gihHJBBGeZCvkF1tgm5GhwSn8LQ@mail.gmail.com>
        <20230427162251.518a956ce7a9dcd88352725a@hugovil.com>
        <31610e60-5c1e-4d19-9beb-83b49ef26155@lunn.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH] imx8mn-var-som: dts: fix PHY detection bug by adding
 deassert delay
Precedence: bulk

On Thu, 27 Apr 2023 22:56:40 +0200
Andrew Lunn <andrew@lunn.ch> wrote:

> On Thu, Apr 27, 2023 at 04:22:51PM -0400, Hugo Villeneuve wrote:
> > On Thu, 27 Apr 2023 17:07:59 -0300
> > Fabio Estevam <festevam@gmail.com> wrote:
> > 
> > > On Thu, Apr 27, 2023 at 5:06 PM Hugo Villeneuve <hugo@hugovil.com> wrote:
> > > 
> > > > Hi Fabio,
> > > > it uses a ADIN1300 PHY.
> > > >
> > > > The datasheet indicate that the "Management interface active (t4)" state is reached at most 5ms after the reset signal is deasserted.
> > > 
> > > Please add this information to the commit log and please add a Fixes: tag.
> > > 
> > > Thanks
> > 
> > Hi,
> > I am trying to properly add a "Fixes: " tag, but the description for this tag indicates that it is to report that "the patch fixes an issue in a previous commit".
> > 
> > In this case, I cannot identify a commit that introduced that bug, apart from the initial commit of the DTS file which didn't have the reset property present?
> 
> Is the PHY on the SOM or the carrier?

It is on the SOM.

> 
> If the PHY is on the carrier, then the delay is a carrier property,
> and should be in the carrier .dts file. So use the commit for when the
> carrier DTS file was added.
> 
> If the PHY is on the SOM, then use the commit for when the SOM DTSI
> was added.

Ok, will use that.

Hugo.

-- 
Hugo Villeneuve <hugo@hugovil.com>