Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Apr 2023 18:18:26 -0400
From:   Hugo Villeneuve <hugo@hugovil.com>
To:     Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc:     Fabio Estevam <festevam@gmail.com>, devicetree@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Hugo Villeneuve <hvilleneuve@dimonoff.com>,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>,
        linux-arm-kernel@lists.infradead.org
Message-Id: <20230427181826.3929691d2aa4820b6db7def8@hugovil.com>
In-Reply-To: <76302757-5359-5e70-02e2-daf0923843cb@pengutronix.de>
References: <20230427195538.2718661-1-hugo@hugovil.com>
        <CAOMZO5CQeeme6uhb8NCzR2QADjkBM-mRC9-GUnmhLWSGo5MMoQ@mail.gmail.com>
        <20230427160608.f051241d750404939296f60d@hugovil.com>
        <CAOMZO5BNbRV1fLpwDZWgj9+gihHJBBGeZCvkF1tgm5GhwSn8LQ@mail.gmail.com>
        <20230427161226.9c971530c6b848aa813c92b3@hugovil.com>
        <76302757-5359-5e70-02e2-daf0923843cb@pengutronix.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH] imx8mn-var-som: dts: fix PHY detection bug by adding
 deassert delay
Precedence: bulk

On Thu, 27 Apr 2023 22:16:45 +0200
Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:

> On 27.04.23 22:12, Hugo Villeneuve wrote:
> > On Thu, 27 Apr 2023 17:07:59 -0300
> > Fabio Estevam <festevam@gmail.com> wrote:
> > 
> >> On Thu, Apr 27, 2023 at 5:06 PM Hugo Villeneuve <hugo@hugovil.com> wrote:
> >>
> >>> Hi Fabio,
> >>> it uses a ADIN1300 PHY.
> >>>
> >>> The datasheet indicate that the "Management interface active (t4)" state is reached at most 5ms after the reset signal is deasserted.
> >>
> >> Please add this information to the commit log and please add a Fixes: tag.
> > 
> > Good idea, will do.
> 
> Please also add the PHY name into the DT, e.g.:
> 
>   ethphy: ethernet-phy@4 { /* ADIN1300 */
> 
> I find this very useful when bringing up a new board and looking
> for similar DTs.
> 
> Thanks,
> Ahmad

Hi Ahmad,
altough I agree it is a good idea, I prefer to not add this information for now, because there is probably some (old) versions of this SOM which use other PHY devices (maybe AR8033), but I am not 100% sure as this is not clear from the SOM manufacturer infos/website.

Hugo.