Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>
Subject: Re: [PATCH REPOST blktests v2 2/9] nvme: Do not hard code device size
 for dd test
Thread-Topic: [PATCH REPOST blktests v2 2/9] nvme: Do not hard code device
 size for dd test
Thread-Index: AQHZeXtj0ucpszBCTUighHxPq+oc+g==
Date:   Fri, 28 Apr 2023 02:44:44 +0000
Message-ID: <z3lbxnnewuwnozrme27okchaxytt7zegj4emgpt4gmewsvcr5k@aordfdu7tai4>
References: <20230421060505.10132-1-dwagner@suse.de>
 <20230421060505.10132-3-dwagner@suse.de>
In-Reply-To: <20230421060505.10132-3-dwagner@suse.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pIL1mTc37EcsYUUNUkbBKX0vPY2Niism9dP2ftx/NzRQvaKgQVAxhFJ9bbyg?=
 =?us-ascii?Q?QZ0TDixTJI7jqJA5gvtJGSW6wk6QHreIJK21RwE/YVbOL6RfYjRUooVtcoao?=
 =?us-ascii?Q?BxGiDL8l9af6ZyiBOsLfUGtk4alPdEM3ZCjfhQPeHg7QSbgt4trJACB0u9Y3?=
 =?us-ascii?Q?YVLez2i+Emvugzbqk2OxWpkCHjf90LAIqB9MFmBJlxhZXQzGY7o8XK407xSn?=
 =?us-ascii?Q?+pdiFv5ixHO5/GCZXOoZ6buM7TFPBhdFrd1nuZQCz0SvZDufZYuOct5E3KoU?=
 =?us-ascii?Q?FxvpCDCajV285HldBOqRJin9LfGVDMxJPw3SwBXSr87RKxJkuN/OPq5qeljN?=
 =?us-ascii?Q?kEp8haPxp5iOLy6E8/kJNOjtyTQ8xBc9tjN0MKD90HyFfV3jYPnDCBD9AxD9?=
 =?us-ascii?Q?Aq6g0fZHm8TVDZJh83tXv2iOXegaROcFYVpxl/+xAr9EGb+jwXwqw6TM2O9C?=
 =?us-ascii?Q?vj59txY34yDsgoKJbCfzATtzV89phP8NMff42Erk0nKOQZ280VVjewaAeBgP?=
 =?us-ascii?Q?dlcVg70i9illS3+bnTMvT2zfxWqiWwc+UFwRTCS7oXe5NEQLWvM8qU68jAa+?=
 =?us-ascii?Q?GuAs1ama2SR/SAEFqNxOX4dAFgrOEmOWB7sn4STPQbSxr5G3+pL51x9xmhDw?=
 =?us-ascii?Q?yLykhJNGkqVp8nC58kWOBwV3Vs304oeLrzp+vP9n25g6XHtJAeM4rJ3J5fu7?=
 =?us-ascii?Q?C7+V85BjKAxXYnXO1w7vy0P+etTA02gfykf++zumf9H3yclDPGFsSb+M+7ai?=
 =?us-ascii?Q?xtU0tafJpMnVzNrBwLvew6WoV+RwCdWIajIUSbqIc/6VWfTyfrOn2olnlThe?=
 =?us-ascii?Q?LNboFJqHoa0zUWCF2S/SUUy59EXe4jiCWL/Y6CyzdKoodAUsstwIax13GAE+?=
 =?us-ascii?Q?DVbn4RBRxBwL/gYCxw3Dk3OgL6ZcBDDuv8hkEv1JhTx1BoHh6dwiIB3cihMo?=
 =?us-ascii?Q?gvMjT3oVSD4dteDb7JlMTrsBlaX79EBN+jiLEoJeSOhSBESCwJ95vChaq4B/?=
 =?us-ascii?Q?45FPnItSap+E/gC13NBFDp7+vqVqnGsRWP+0IipDyrR6Fi/5d0N3wWWi21tI?=
 =?us-ascii?Q?IAm5NRIjtW503NieNuh8VDxzoDtKEQFg36A6yfoslKilsYGAMMFTyBM28Y15?=
 =?us-ascii?Q?ABjH1O+93yWKuFWdNn6TgJVL3DJ2Tx28/XM0jHGPWeZGHx0fIGzY4w9xVouR?=
 =?us-ascii?Q?713c7kpAIvhpXDwakELuvGienVoNHxO0DSv37U0IbhA1PfJzliRaw9RoQakX?=
 =?us-ascii?Q?SwFaVYbx8sYvcD2C5dtkDmpX8HmnRqFjpH/DDydVuTq9gBA8YaUCika2XNYZ?=
 =?us-ascii?Q?alrcFspjRJNgysWsbdVC+IeBiSkXBybD58v+mqW4PdQtJdCTHPPk17lg+5KD?=
 =?us-ascii?Q?RA8pV+OfmV8PrURRMRvLctVJZmYzd8Q9tYCrfi/Da29c4SKP8XpzOkxyhDL7?=
 =?us-ascii?Q?KLUZzhi4sfR0RHYhvJVLm4a4H7aEXNs8M0NqhW4wnKzXG3oLDwxcRP6/2BwX?=
 =?us-ascii?Q?oRFb4U6VZwjEA0SEKceS/4JV7P4PzNpEHLXN7BArqdZHtfjZD5irVtTY2tPh?=
 =?us-ascii?Q?oHacxLGpxjgY03wYQeTfMhsZtcSGsdq+zPqtdJdxh9pLaIFgBmqDICjaMSlc?=
 =?us-ascii?Q?1FtoFDEnZH4DV74CsxFw/LE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <DE8A500D00366E4A8EE5C93DF3C147D6@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1u39ZYHd3lAxlkFfXx+J89zO06ns2dsf4p1g+noL+k5YO2juuQyiL98TzAfr/SKNR79eUbTkINBG8YJ4L5CEQ9+h1c8zPgxoSlLvhZmEMz6795kuwqCrmakkMrM1yvqJ6vVKuX3qMVmbMX0hu9pcHNrBgWaGH8Vuyd5S+dT/oYZ7DMYBXOcDaxOXwGWmL5c/4TmJyzEQajkv13G9/8PXYhHGINpC+OOnJc08yySw3dywPg1v6NdFqiYOZRx1eFTZzizHYvUt4K2z/Pw/aI8T0rU3wLroIvlyEo47lSiR3wTSe1Pz/0LYsytRUOTCFbnR41b9Cb8Rw8KF2/D+Y1VSXPMSSD46MRyXD9c/CJm3wYVy/3U/XaKUwlN1B/+gmg5IrjB3vm2BHegzrMugGuEQmDPJoheLjPklb0vpdVw1iVXv5cV5Du6Ume4+xIsXFQiUvtMtTiN5XiOpLcZQncg6nllkhPPV9UVkn1ENL5GkUNBlLlp9eS8yqgAb79NpUl+cRC3Ez7tDcbw1A5vt/MxEiBStvtFBpA8Irh9NiSV/amPBCTB8ag7K2fIRriFRQ2Ym0z7L2T1Ctaj15RGjCS3J0m4VeWbdMvJdI9AjdztDUW27LmYtwmVbxG0+TNIjg9Ztl45tAVYn3HySK70V+jXiWgshaAqpZbzdd9QCOqZYz5ieMZ5fxbH3bUagU/K6jZP68WGPTxYDKPC8OUdZ4p7o97X6vDHQrkvOBGIUnKZVZeSexpSxacHoLT+qTO+x9ZFdDRxtm4sTkwMxffwYeaVMFfGWkS9ZZHuwx2nd6mGqJovPgoIcKx/zwexrErr8VVY4nTUb+SfxVyJjioBuWWT89go12QyoLf1bZTZsbSIZ63ySeLn5CcR8nITP7E0bsp7J+QMA4UZVZgDqar/+pXuvj3ugSiaXqwMeSsao0d/TQLM=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29a77779-a67d-4542-c093-08db47928664
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2023 02:44:44.8585
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: C5dwsjCarSvt5Vd5yuRDFtMtCS4OMwCHqrAzpZz15qYU6AFBsp/qT0LTQNCi7DV6c8vwe4UVTmJHYEDPyCfu62Ry0bUj6zH1QOX6Z2JNrP0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB7085
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Apr 21, 2023 / 08:04, Daniel Wagner wrote:
> Read the block device sizes instead hard coding them.

I suggest to add this to clarify the purpose of this commit:
  ".., so that the device size can be configurable in future."

>=20
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>  tests/nvme/014 | 10 +++++++++-
>  tests/nvme/015 | 10 +++++++++-
>  2 files changed, 18 insertions(+), 2 deletions(-)
>=20
> diff --git a/tests/nvme/014 b/tests/nvme/014
> index d13cff7921da..28913641ae40 100755
> --- a/tests/nvme/014
> +++ b/tests/nvme/014
> @@ -23,6 +23,9 @@ test() {
>  	local port
>  	local nvmedev
>  	local loop_dev
> +	local size
> +	local bs
> +	local count
>  	local file_path=3D"$TMPDIR/img"
>  	local subsys_name=3D"blktests-subsystem-1"
> =20
> @@ -41,7 +44,12 @@ test() {
>  	cat "/sys/block/${nvmedev}n1/uuid"
>  	cat "/sys/block/${nvmedev}n1/wwid"
> =20
> -	dd if=3D/dev/urandom of=3D"/dev/${nvmedev}n1" count=3D128000 bs=3D4k st=
atus=3Dnone
> +	size=3D"$(blockdev --getsize64 "/dev/${nvmedev}n1")"
> +	bs=3D"$(blockdev --getbsz "/dev/${nvmedev}n1")"
> +	count=3D$((size / bs - 1))

Do we need -1?

> +
> +	dd if=3D/dev/urandom of=3D"/dev/${nvmedev}n1" \
> +		count=3D"${count}" bs=3D"${bs}" status=3Dnone
> =20
>  	nvme flush "/dev/${nvmedev}" -n 1
> =20
> diff --git a/tests/nvme/015 b/tests/nvme/015
> index bb52ba2598db..2f7957caac88 100755
> --- a/tests/nvme/015
> +++ b/tests/nvme/015
> @@ -22,6 +22,9 @@ test() {
> =20
>  	local port
>  	local nvmedev
> +	local size
> +	local bs
> +	local count
>  	local file_path=3D"$TMPDIR/img"
>  	local subsys_name=3D"blktests-subsystem-1"
> =20
> @@ -38,7 +41,12 @@ test() {
>  	cat "/sys/block/${nvmedev}n1/uuid"
>  	cat "/sys/block/${nvmedev}n1/wwid"
> =20
> -	dd if=3D/dev/urandom of=3D"/dev/${nvmedev}n1" count=3D128000 bs=3D4k st=
atus=3Dnone
> +	size=3D"$(blockdev --getsize64 "/dev/${nvmedev}n1")"
> +	bs=3D"$(blockdev --getbsz "/dev/${nvmedev}n1")"
> +	count=3D$((size / bs - 1))

Same here.

> +
> +	dd if=3D/dev/urandom of=3D"/dev/${nvmedev}n1" \
> +		count=3D"${count}" bs=3D"${bs}" status=3Dnone
> =20
>  	nvme flush "/dev/${nvmedev}n1" -n 1
> =20
> --=20
> 2.40.0
> =