Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     Hannes Reinecke <hare@suse.de>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>
Subject: Re: [PATCH REPOST blktests v2 3/9] common-xfs: Make size argument
 optional for _xfs_run_fio_verify_io
Thread-Topic: [PATCH REPOST blktests v2 3/9] common-xfs: Make size argument
 optional for _xfs_run_fio_verify_io
Thread-Index: AQHZeXy68rG2HytVkkq4pAqFsLjcxA==
Date:   Fri, 28 Apr 2023 02:54:19 +0000
Message-ID: <6odezvt3uwnc3c6353qlvqdxadmn5giihsj77xvwi6h4655la4@ezvpevwxfsan>
References: <20230421060505.10132-1-dwagner@suse.de>
 <20230421060505.10132-4-dwagner@suse.de>
 <1089a043-a40c-6b49-f0a0-38ca3bcd8f91@suse.de>
 <s4xicrnevbwapdwvw5wl2z4bpm6vv6q62lcgimy6wcqnbf6tbo@u7alfvt4bmen>
In-Reply-To: <s4xicrnevbwapdwvw5wl2z4bpm6vv6q62lcgimy6wcqnbf6tbo@u7alfvt4bmen>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?j8FS/wuXzVjt7CMMJcbUJhckBWmb+KUXt2b3HNBNO+KgGxITvAZQIBgXLeUm?=
 =?us-ascii?Q?Tt7KmkpFDqMG1pu8oFFXH6rr1G+wQo3po2FuFc8zFLfQ2/J4iPsLN05ZSdoC?=
 =?us-ascii?Q?1+7lDt7eMzQmGZQTTgNOn8E7O2S/CjFr07g6iqD3H41uq3LmLBmbBpSHAc2M?=
 =?us-ascii?Q?Eujm22+F5t5lPd4vl0jBAgVZM6zcMiYJmC14SrpvS27JlrbgqFBxKOm9KIiS?=
 =?us-ascii?Q?BdDvGEeiyMtJ0wyU7JvO4i7KproCHbTVAI+Oh6T3Cg+QStb507iYdTGQfziR?=
 =?us-ascii?Q?M0B2Kg7WgyLjA3PltfBe+2UYoyvfV74gNLemsaKabeyhy2XF05tfv8ktzjea?=
 =?us-ascii?Q?8ljk6dCjaKxnu1rx7dBaaggCr1cT5Aka6Gv5ys0ZuiOm/r9X/nYL2lb34mah?=
 =?us-ascii?Q?TkwwvEXIowiJJiZlJsGOvHcLj680ddsMq8h0x0IG77Wn5OzSh4bgyzCt6n11?=
 =?us-ascii?Q?A3BgD4CVnYHkUydc9yi29wrDOUwG53pDdcwDK9BWGHLL+9B1kMhX539OT5DO?=
 =?us-ascii?Q?ytgaJkvi3nf8xpxQHREJsMwrQ7KVA58D+5huTGrhZd6AQI8ljMF0abygEvdD?=
 =?us-ascii?Q?k6zvN7FaGXyCYFb9eO91heqH+dqFr/MD0wuQNEAGQmyBbp2JjvVTFxE7Iess?=
 =?us-ascii?Q?EObLNHkDGfWQe6o7WAnndTQTYQI+GknU86uiLjpQNxfKIvwgiybowIaQMtUu?=
 =?us-ascii?Q?cGsFUirTFTAh2IIJoCcIo162pd7Xuuf4O5e9L1ao1yBSzQ75gKfVBw0/nOIy?=
 =?us-ascii?Q?RQlaz3gdDc5GgKjg2ExOCn2n6uPNm3p1pHp0P8gNfo8C+CbYeCeUuNh9If3/?=
 =?us-ascii?Q?BEjyVHmI1i237m9IhozmcJrG4Q2y0hVb5AlqkrwGmWB35tHbNWxyrXaVnU6a?=
 =?us-ascii?Q?jL9Hh7bagwh7rz6f5Pm21/YrwteO/FZdwuMJ0K10Cy9glnRyFy5+ocju5Umo?=
 =?us-ascii?Q?Sv8nvqbfmbtgStGc9EqMRTUDgya8G7hJCIWLXZsK5I8iS4aPGdLwQkZ3eWkq?=
 =?us-ascii?Q?zKqjJXdNwVrDxSnp1WDwkAxcbpwHwpISzz6C6xn/8PKMU1EBRFNi6V1otpJQ?=
 =?us-ascii?Q?kuh0rZ52f+vmvpNB/FJcMDC7gerUIBTQGjkjbn0GE0VIBeIjVhz9FzoOfHSn?=
 =?us-ascii?Q?FyyHRuPH30XzMHm448bzCl1pVY2gIRviq7c+6dJmu8Cm7UFtEEPL/VLm9sdW?=
 =?us-ascii?Q?7xnYua+8raFvjTEvljBmrcM4GTH3FzCm1KbkdCBYwFxcWWieTVLB3Q6DPFKn?=
 =?us-ascii?Q?k1KqYiPLgjxTMgAomHG078Man/m0q4lnifs2UW8nHXujFSe7Wv081Hxvfr+J?=
 =?us-ascii?Q?UVI5/1pxMEQrYplww1m5AXh1/6xof78rHTsY402GScZhszXLv9zUqAMhHVxc?=
 =?us-ascii?Q?cpdanILukHYkEL4/OAj3FnGhqqu4DDp95UPl2Wocn/x3IfSMeYnIkuJtcjIz?=
 =?us-ascii?Q?nSLSHb6qnpO7KjPkqMaphLhtKMCH0nOrEKrwI6oMwLHuElskyVH01F0lXP9Q?=
 =?us-ascii?Q?2sorTkAxERYjZX5FbsXtH7x8DKiUIgowHXA+6CPLD7bCHSXT07su+2uk7eJW?=
 =?us-ascii?Q?KXcJWwCLcb40E2rejFp0SBaGSe+SxVDpjAx5t1qreFlKSNyGwMDjLXwenHjB?=
 =?us-ascii?Q?ptI0A82PREh0x/FQ9zWmjp0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <918C1595D5EEDE4DA3B5161645E8D8B6@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: fFZl5Bv8I6uQzSQt4L5ghAGnywQGqCi+nuDrdJu6ee74b7OISzcTUWgjhejcx0ybqNW/peYTL3fBGqIZxjg2zATUWQIebHKdSRFfLr4kewvqhXNr4JD7O6d+3ZK9/Bla5xU7AhuYMPGXkv4VmFl6n51W77P11DTeiRCJgGN9BlRZ9ZmJr6nvenalBdHl15sbn+bInOdy+rpdNGdmvi626esPX2DcSU6XwOqd/bgj2soniczqN14YwvGz1kI4aRjSoS4l2poCcCr+yIjoWlrBZylLVI01w1HlzXkCtbzzJCFTGAjusqjRZl9EtANyKMTfQOitY8F4+Vii3oU7gBtuO96a3dFo5dZ8qQ4HqE5k0L/qBXgxJjXeMmxMJZGpzorlusCwwAldYdjzVk4J0ctOvLiFFL5bSaNF9kKQQY0X6ThghzHi51MroJcY6Obk5vT243iKuD8ykCM46CyrW0EW+mHs009miHLz95xlVJqrqU+5vhQ4oF/vuRup+/lsxHapmYPKA4mTf2s7xPx/U8031b5DlDCWPIhtKClFTBZronmv+OXwf4cDLp5EStjRLHfS65rCBzt7QTgFQ6+fj3S2Kwm1+Qo1sgmdMzE7dEOmmShBgAMDxfScm1nynljLpSlPLOka+JpODhIdf2RGCyJ6O6EIWaftG16lpE/843tXOXT/lwGCNZ+mE9Oz/Lf2Y40l0YnldWM/KEYGVXHMuWiYoblEsxwlAh4HCUnYvrFBhv3xbH1JWqdEI4i94tdgzogpRjUmHXeFZqtwn5joBhjTFMqahx5zTVUF94nAFQ4ZRoalj3VHaLoSh9ckkZs6SEFboBXqgGKqnGu49WfZhceTlLf0ClXsLetQd4jpukSqmgaFRxnj1twqkcP2+HEaLknPQvuFgEBziIuVoxupuZovdDc6KDh4so3v8T1IVaRQoxw=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec575215-3a5e-46dd-1d9d-08db4793dcd6
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2023 02:54:19.3220
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uLG/1M+Jcj1qfvY35n4X7baxot5wcPokPZ3S4VEocOJY1uQKw0Y4zCnVpNauQT7AzcjjUMSgfqtujzt8QudRKBcMXKUkCkDWWJKkuN+rsSw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR04MB7949
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Apr 21, 2023 / 08:54, Daniel Wagner wrote:
> On Fri, Apr 21, 2023 at 08:27:35AM +0200, Hannes Reinecke wrote:
> > On 4/21/23 08:04, Daniel Wagner wrote:
> > > Make the size argument optional by reading the filesystem info. The
> > > caller doesn't have to guess (or calculate) how big the max IO size.
> > > The log data structure of XFS is reducing the capacity.
> > >=20
> > > Signed-off-by: Daniel Wagner <dwagner@suse.de>
> > > ---
> > >   common/xfs     | 6 ++++++
> > >   tests/nvme/012 | 2 +-
> > >   tests/nvme/013 | 2 +-
> > >   tests/nvme/035 | 2 +-
> > >   4 files changed, 9 insertions(+), 3 deletions(-)
> > >=20
> > > diff --git a/common/xfs b/common/xfs
> > > index 2c5d96164ac1..ec35599e017b 100644
> > > --- a/common/xfs
> > > +++ b/common/xfs
> > > @@ -27,6 +27,12 @@ _xfs_run_fio_verify_io() {
> > >   	_xfs_mkfs_and_mount "${bdev}" "${mount_dir}" >> "${FULL}" 2>&1
> > > +	if [[ -z "${sz}" ]]; then
> > > +		local avail
> > > +		avail=3D"$(df --output=3Davail "${mount_dir}" | awk 'NR=3D=3D2 {pr=
int $1}')"
> >=20
> > df --output=3Davail "${mount_dir}" | tail -1
>=20
> Sure, don't think it matters.
>=20
> > > +		sz=3D"$(printf "%d" $((avail / 1024 - 1 )))m"
> >=20
> > sz=3D$((avail / 1024 - 1))
>=20
> I tried this but the devision is likely to return a floating point which =
fio
> doesn't like. Is there a way to tell bash to do a pure integer devision?

Hmm, AFAIK, bash arithmetic supports integer only. I tried below, and bash =
did
not return floating value...

  $ avail=3D90000; echo $((avail/1024))
  87

Assuming bash arithmetic supports integer only, -1 will not be required in =
the
calculation.=