Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1509935rwr; Thu, 27 Apr 2023 20:03:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5UonuGpWK/9B6NKNMeTDltytCAA+Y8vM97hTdqyTeNrmhZXKgnwrlBbvMLG4sH5tQVSlFx X-Received: by 2002:a05:6a21:9991:b0:ef:7d7b:433b with SMTP id ve17-20020a056a21999100b000ef7d7b433bmr4456130pzb.41.1682651039460; Thu, 27 Apr 2023 20:03:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682651039; cv=none; d=google.com; s=arc-20160816; b=sTOVOMELbwh8JrUGbDDg604DKouJQHeWm14PcjTFQi0wNqd+Che7WSTDjW6JH/Hjm6 dxZgJSC4rNURND6dpniBgehFGGmPISspa1BMMs5ggdzd9LJBcrFODk5Ak6V2+LXe/L74 TwT/lu+1cBvFZqgr1Eiu0oQRQJTNDAzmHTWzFKmXYSxavPjfXG7B69pbLSKJ2xII91Eg 45oyRD648RQoRvabYq2a4hE7dxaYkT1FMlN0mqxD8VtEGx6gCw+3CMXxchkEsqVFauau YZl0TaoXFgIlIXdeSicTqDUWAPdv5TAKatClJYyBpqQx6ed+BCdljyI5megW889dkzkS WzKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=/9mxxPAl4POq2fq0d8t6aqpR8L52uoUsixYLH2L9aFc=; b=b3k/JvTByAAMn0ERTFn7ftY7opYX+XZn2Lnq1heCJDtxsdfoKa6y3HqzFgWOAJML7k 7v9Ry3nFd7tw1HNywaysZtdpV1Tyko3c1SVVMMD68KZ8jbj5vkqFuMolLrCsX4hcbFdR nwde60HzRTN98AkfKWc2DA17gnM7vEpYRTV2B3zZYU+fXQHF9WU6hcHla6/Z/uC92P3V P63AwgHiELdfzxKis2CFCsrGZ9exvpRCkbvGD5upNKZVtuH8H2c/Za5Zx5pkzjn5iZQo I35TYjup/ApBzqNb6tPlxdpLKumOnlkmLmGvKN+zwkMCJpJFf/8ZgCGRKc9B4c0rprn2 2CkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=ZPk0kJ3F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e14-20020a63d94e000000b00527d158ec73si10895753pgj.3.2023.04.27.20.03.46; Thu, 27 Apr 2023 20:03:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=ZPk0kJ3F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344779AbjD1CyL (ORCPT + 99 others); Thu, 27 Apr 2023 22:54:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229963AbjD1CyK (ORCPT ); Thu, 27 Apr 2023 22:54:10 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7D8B1BFA for ; Thu, 27 Apr 2023 19:54:09 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-95369921f8eso1519394066b.0 for ; Thu, 27 Apr 2023 19:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1682650448; x=1685242448; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/9mxxPAl4POq2fq0d8t6aqpR8L52uoUsixYLH2L9aFc=; b=ZPk0kJ3F0NtZVICxhc3a3DXop4x4L91ocVVqE6hotNGm7wYzk9hjYizAd6xEbDFkNx xQlbQrVEZgQiUjP7CyzX/mVC91Ds+FzOGiyUtvDiz6nGl/bMnws3jXj8gAcNqX8fiOh4 Ktpfpqcvab8BvlwGJQ/grUpV6NWFBFjBsZAGk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682650448; x=1685242448; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/9mxxPAl4POq2fq0d8t6aqpR8L52uoUsixYLH2L9aFc=; b=cNxxR7Q1KsyqhhOj5n1ulmLY4I84NDRTKD9lGZm/Wh8rfrU53HUkxmttsw91EQbfPE UhOXeeX6JQ7igOauU1ohcIeSWI25ZKzRuDJ1HqnBFZHXg5Erv+y+vqzRgptz1tJb6oh6 bGgBsENIeqMg3yHLO5N2bMRnB8F6ezX6kV0ByyP5gQM0eI8UI+Ful9bK0y3gPaUHHgnr zOiCJrBBa8iVQeQ6YT38W1OvbUlWAIuNfgOrYJwqf701Y+KIIeDH81oknwmyUI60jEvt nWVH5aiYdBAk04xhLnz1ClsCWI7F3mqFnZqSCTafC5c1CYe1ayHUHIxNlqJSLy4Vuu3l sY4A== X-Gm-Message-State: AC+VfDxwpTWN7cjoKCwCbrPXNh0dpsXsFgz7tsogbhc29kQngWE8hQpj m2/Di09qeCbN78dztlWoFman4w8hcLyfgr8x8X2maQ== X-Received: by 2002:a17:907:970d:b0:94f:6852:549b with SMTP id jg13-20020a170907970d00b0094f6852549bmr3936184ejc.9.1682650447864; Thu, 27 Apr 2023 19:54:07 -0700 (PDT) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com. [209.85.218.52]) by smtp.gmail.com with ESMTPSA id ml24-20020a170906cc1800b0094e6a9c1d24sm10771053ejb.12.2023.04.27.19.54.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Apr 2023 19:54:06 -0700 (PDT) Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-94ef0a8546fso1518569266b.1 for ; Thu, 27 Apr 2023 19:54:05 -0700 (PDT) X-Received: by 2002:a17:906:da8d:b0:94e:4586:f135 with SMTP id xh13-20020a170906da8d00b0094e4586f135mr3520975ejb.6.1682650445056; Thu, 27 Apr 2023 19:54:05 -0700 (PDT) MIME-Version: 1.0 References: <20230427140959.27655-1-vbabka@suse.cz> <2023042719-stratus-pavestone-505e@gregkh> <3cc6e10c-f054-a30a-bf87-966098ccb7bf@suse.cz> In-Reply-To: From: Linus Torvalds Date: Thu, 27 Apr 2023 19:53:48 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH for v6.3 regression] mm/mremap: fix vm_pgoff in vma_merge() case 3 To: Vlastimil Babka Cc: Greg KH , Andrew Morton , "Liam R. Howlett" , lstoakes@gmail.com, regressions@lists.linux.dev, linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, Jiri Slaby , Fabian Vogt , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vlastimil, On Thu, Apr 27, 2023 at 8:12=E2=80=AFAM Linus Torvalds wrote: > > Ack. It's in my tree as commit 7e7757876f25 right now (not pushed out > yet, will do the usual build tests and look around for other things > pending). Gaah. I just merged Andrew's MM tree, and while it had a lot of small conflicts (and the ext4 ones were annoying semantic ones), the only one that was in *confusing* code was the one introduced by this one-liner fix. I'm pretty sure I did the right thing, particularly given your other patch for the mm tree, but please humor me and take a look at it? That 'vma_merge()' function is the function from hell. I haven't pushed out yet because it's still going through my build tests, but it should be out soon. Linus