Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>
Subject: Re: [PATCH REPOST blktests v2 3/9] common-xfs: Make size argument
 optional for _xfs_run_fio_verify_io
Thread-Topic: [PATCH REPOST blktests v2 3/9] common-xfs: Make size argument
 optional for _xfs_run_fio_verify_io
Thread-Index: AQHZeX1i8rG2HytVkkq4pAqFsLjcxA==
Date:   Fri, 28 Apr 2023 02:59:02 +0000
Message-ID: <le6qqxhkbdaacsifz4b3mody53gllg4rzhowm2j62y56y56y6k@pmlukhvwjw24>
References: <20230421060505.10132-1-dwagner@suse.de>
 <20230421060505.10132-4-dwagner@suse.de>
In-Reply-To: <20230421060505.10132-4-dwagner@suse.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QZB7VQkZZE5rYqZuOqeHAXUNnnxPLsyH4j9sPxqiGpgJwNaWx2pG7gGw4T27?=
 =?us-ascii?Q?m38FIf+KvpaF46f9aUCuJQV0101R9zNhg2sZPM7JdoxdGOwrv5jKPLA/0G2P?=
 =?us-ascii?Q?08KRRttunaMLDYMVEI0qqCbuBoUxBbyMf1Fl2rpOAhrUzbHej99+0LmyBcvO?=
 =?us-ascii?Q?M/J+Z69hFxQHL0bwNtqew8/nZ/LFqB8mebpv5FcGN7auNFDSwBnBmnJzphXZ?=
 =?us-ascii?Q?WAI2u4RwaxxzT64BlJ1PaKSAX0QiH1yRZ9wBndfQ6BlgRakf9CEMfVcjajac?=
 =?us-ascii?Q?U1Ga8KtCWY6n8Q9Xpf30gW2ZLt98YU3jZ/13ezsQOMYeur3hr3Y/PqykK13V?=
 =?us-ascii?Q?woMGHOcKoGIp/+qDZNRnSDz/us32Ma4WG7+aNbQfzw1Nz3Fc1RmmsrnNljKS?=
 =?us-ascii?Q?Kr+RZBZI4MzjmJNW2AbvBNqytPaYnZUPbKxtQZN0J/xl5bcKpVoZtk/5rCTp?=
 =?us-ascii?Q?veang15LYTVIt2n1CDNEfLfbaLJ/cIzWmMK23ypgiw9yEDUQ5SjqJ8Giqd7B?=
 =?us-ascii?Q?BnqtSsNQWkTlls51IjenZCrF83HS1eHK06+xHNFYfRfPY8wcRuslZ4/VBykT?=
 =?us-ascii?Q?zkkjHVGUIxlp6NM8e0NgHAFR4gVu/OOYBUiZt03yTMmu0MuopUlLPiRbEaLZ?=
 =?us-ascii?Q?xq8DgIUR4rAFx6N+nRCCJovZoGWSoLHPOE9C3Y295pSxzIDzvK4uAQNaXm9y?=
 =?us-ascii?Q?Q8kznHynOTIKTpPGeJ8zzqZBae6qajVYSbSoEeynFJpsdY8DLVJXV1/3z3ky?=
 =?us-ascii?Q?mbrD3iCcOQ21b/0nZj+hcKlkuC0PxsijChcyKm5hK+p+fR4yFLyYuDW+WokD?=
 =?us-ascii?Q?ZMzPtAyQK0mt8lzYnWTXrnhQxCb5lT3XcyZ32xrIKPnMLq3pgj8oJzIoJv39?=
 =?us-ascii?Q?/H+mQOg5JPzdlAYyfBCoXl9dL8ltGBYmScipmTRbHIjyBXRQSRTu5Zltge0i?=
 =?us-ascii?Q?sRtk6J+gfNbOL9QT4Vcm/v/2UkRIXEmv59JBAzDurvRq1VNSAfdOjHI3jzy1?=
 =?us-ascii?Q?Am5Wjs+aEjJawmDIZ9ItK/oifjsXNLYJ40X0hyWgUno9uHzRcWMxtxBcjvfV?=
 =?us-ascii?Q?EFIRi55y+k8eT1q8BM5b+sV3IjoP6w5p33dREN0HXJ0W4Yzxw1OF6k0PX6xK?=
 =?us-ascii?Q?ndqVMxowWG9l2YVf+x05+NfrI63Lszw8RxKJjBOkgvkM+IHx9T8H6zRsELN1?=
 =?us-ascii?Q?xtP8PJLRD5FHRzUVPVH9ZwM+jsmWnoT+bVJATypHLx6FELz2s9gkcJhOKvMM?=
 =?us-ascii?Q?yIC0056kMewhekxAnyiIh71hLE0o++jLFJO5skh11+8pJs3u37eDY5vpA39i?=
 =?us-ascii?Q?e4RFyFn9ROdcYdJBCi6bd93DizZl6CQ9CW5pumHPTpNiEI1Bf6NFonqrtyrg?=
 =?us-ascii?Q?Es1/Ze43LeIt24qQk+62Mw7CebJIw4Jvh9Stl0vgQIfMlhXucGqKQiGYD4w5?=
 =?us-ascii?Q?wEdWnOFLZSB/6kVaJI+CHBL/9MbhQTzZvVbXKOjsLCRRuDf2OJiUqxouQtad?=
 =?us-ascii?Q?g7mj7mSCDXMq28eJdNJ5NrTzDltKFEOI5eERHxNTiQyVmuQdzNHjL7/i8PpZ?=
 =?us-ascii?Q?2dJntbmZMLnUmR9fTQI6AaOo9znYgPqZxxuhzuWrgJm3IpcOIB73AWVUN1gE?=
 =?us-ascii?Q?fpCBxlWOCFuHgEf/klmBKG8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B966ED1A4E698D40B54CA8DC8853AA46@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: IyfeStA59d1HgX1z+5SnFtxIoy1Yl5STVDsZ8Lv1olAdvJDLaVzuccHZmMZZ+MmwjqrRal7449D3lVNpyzVPPO1wUEDmXXXjbWHLTX96ufkfGzson/A14By6r5CK8pNPpYkQe1EzU7AnIzSz+bB8+1r7suegugw0joLUNKKyMpBu5NoHsSeIDmUhCNGU6UudXFNea2R148PYWo/TepkOo03qCcFERdTPWepSxkSVKkgngxtYk3ryXff7CmVk9n93rqjTKdbmojSz8P2rA0FXYOqYjJ2lWDPzQYdtDSycPa6J2CHLTWqDorF3ZZ4fNJtmqojkxAJUDfFceeLuyKh+NRgCzTriUbSMnj14S9d36zw4bPisMWTO/U4PvQWj68R8qhp34X833fq4FN+HSNloOEdthr8exb/UW5HvOHX6IJOWVnT05PcgQQLnjLhx+YL4v9Gpq+z1GKVfsRGQ9A5UMprOXzrNhT5rN0++lZmtdMcRirhUmlcYLklKLrpHPQz/CdwHhAsRwX2JPymh1JtEWX5NCBbplObqePfHcO70okUY1kNavSCNqENaFJrL6V/P5JCMledTiXjGiisCMdASR1L+9HAJfytIvDzr119XQ6V3Qy13fmFXpDqxysQZdgXuSU/raUgsUJ0KfKZfvirWzDukYw/ViTbtTJKhoUEArYMilA3ovT4u3/46RlW1sRePvWlTdw1jIxL9qsPSbIapnAgxhrk8ZIxbcdlWSBW3gSR6Ki5ZHPfgn2+h+OlhxbXIDfLrPYX6AyVREae3dIkNb/XlBDLiu0wJbJH1W6da+pVS6GbR3alxSME9P46NyNqHxW8B4y89urpFIo3ZUTGX9GTwIenWzroPQNVXTtJuMoAnO8Vk53vsiax+nSAeMfQEJxL00q1t7awQN6G0pJuu0Ogh4BZ5plRIqdrCRrTHlpw=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9289a538-6ed2-4138-b90c-08db479485d4
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2023 02:59:02.8595
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hLH8wZVwZqwP1u2DxjfAwujvEu4qgNUU0IPREv4uPAx0MrjMe3nxIWe+med8CZMJlkNT2VIJAt2SImEApRxWAa20etFB99VXUC9Gb6FaM3A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR04MB7949
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Apr 21, 2023 / 08:04, Daniel Wagner wrote:
> Make the size argument optional by reading the filesystem info. The
> caller doesn't have to guess (or calculate) how big the max IO size.
> The log data structure of XFS is reducing the capacity.
>=20
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>  common/xfs     | 6 ++++++
>  tests/nvme/012 | 2 +-
>  tests/nvme/013 | 2 +-
>  tests/nvme/035 | 2 +-
>  4 files changed, 9 insertions(+), 3 deletions(-)
>=20
> diff --git a/common/xfs b/common/xfs
> index 2c5d96164ac1..ec35599e017b 100644
> --- a/common/xfs
> +++ b/common/xfs
> @@ -27,6 +27,12 @@ _xfs_run_fio_verify_io() {
> =20
>  	_xfs_mkfs_and_mount "${bdev}" "${mount_dir}" >> "${FULL}" 2>&1
> =20
> +	if [[ -z "${sz}" ]]; then
> +		local avail
> +		avail=3D"$(df --output=3Davail "${mount_dir}" | awk 'NR=3D=3D2 {print =
$1}')"
> +		sz=3D"$(printf "%d" $((avail / 1024 - 1 )))m"
> +	fi
> +
>  	_run_fio_verify_io --size=3D"$sz" --directory=3D"${mount_dir}/"
> =20
>  	umount "${mount_dir}" >> "${FULL}" 2>&1
> diff --git a/tests/nvme/012 b/tests/nvme/012
> index e60082c2e751..c9d24388306d 100755
> --- a/tests/nvme/012
> +++ b/tests/nvme/012
> @@ -44,7 +44,7 @@ test() {
>  	cat "/sys/block/${nvmedev}n1/uuid"
>  	cat "/sys/block/${nvmedev}n1/wwid"
> =20
> -	_xfs_run_fio_verify_io "/dev/${nvmedev}n1" "900m"
> +	_xfs_run_fio_verify_io "/dev/${nvmedev}n1"
> =20
>  	_nvme_disconnect_subsys "${subsys_name}"
> =20
> diff --git a/tests/nvme/013 b/tests/nvme/013
> index 9d60a7df4577..265b6968fd34 100755
> --- a/tests/nvme/013
> +++ b/tests/nvme/013
> @@ -41,7 +41,7 @@ test() {
>  	cat "/sys/block/${nvmedev}n1/uuid"
>  	cat "/sys/block/${nvmedev}n1/wwid"
> =20
> -	_xfs_run_fio_verify_io "/dev/${nvmedev}n1" "900m"
> +	_xfs_run_fio_verify_io "/dev/${nvmedev}n1"
> =20
>  	_nvme_disconnect_subsys "${subsys_name}"
>

As for nvme/012 and nvme/013, I observed the I/O size changes from 900m to =
920m
with this patch. This condition looks better for testing point of view. Goo=
d.

> diff --git a/tests/nvme/035 b/tests/nvme/035
> index eb1024edddbf..8b485bc8e682 100755
> --- a/tests/nvme/035
> +++ b/tests/nvme/035
> @@ -32,7 +32,7 @@ test_device() {
>  	port=3D$(_nvmet_passthru_target_setup "${subsys}")
>  	nsdev=3D$(_nvmet_passthru_target_connect "${nvme_trtype}" "${subsys}")
> =20
> -	_xfs_run_fio_verify_io "${nsdev}" "900m"
> +	_xfs_run_fio_verify_io "${nsdev}"

On the other hand, this change for nvme/035 does not look good. It runs the
test on TEST_DEV, which may take very long time without TIMEOUT config.

> =20
>  	_nvme_disconnect_subsys "${subsys}"
>  	_nvmet_passthru_target_cleanup "${port}" "${subsys}"
> --=20
> 2.40.0
> =