Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230427023345.1369433-1-brpol@chromium.org> <CANiq72nxNtLvx1J-50F8D05QQjx4FBPkrhg6pysc25RL6--Zhw@mail.gmail.com>
 <CA+_b7DLoTEn6_2auTVN9Wj62ogOFXnhf7kTmh_KCZPkCBfJsSw@mail.gmail.com>
In-Reply-To: <CA+_b7DLoTEn6_2auTVN9Wj62ogOFXnhf7kTmh_KCZPkCBfJsSw@mail.gmail.com>
From:   Brandon Ross Pollack <brpol@chromium.org>
Date:   Fri, 28 Apr 2023 11:55:17 +0900
Message-ID: <CALWYx-bvyzN3nGtGpLKyoayWLtzKwJGCtdFMfg=6bJSP2qYNGg@mail.gmail.com>
Subject: Re: [PATCH] .gitignore: ignore smatch generated files
To:     Dan Carpenter <error27@gmail.com>
Cc:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
        linux-kernel@vger.kernel.org, masahiroy@kernel.org,
        ojeda@kernel.org, alex.gaynor@gmail.com, keescook@chromium.org,
        nathan@kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Apr 27, 2023 at 8:20=E2=80=AFPM Dan Carpenter <error27@gmail.com> w=
rote:
>
> Thanks for this.  To be honest, I hadn't remembered that Smatch
> still generates trinity_smatch.[ch].  I would prefer to just delete that
> stuff.  Another idea is maybe Smatch could put everything in a
> smatch/ directory?  That feels like maybe it would be nicer?

Sure, that'd be great as well.  I'm pretty sure that smatch outputs
these files from whatever directory you run from, that's why I did the
overall pattern rather than a path pattern.

Should we just patch smatch to not output trinity* files and output to
a directory and change this patch to mask out the directory?

>
> regards,
> dan carpenter