Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     Hannes Reinecke <hare@suse.de>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>
Subject: Re: [PATCH REPOST blktests v2 7/9] nvme-rc: Calculate IO size for fio
 jobs
Thread-Topic: [PATCH REPOST blktests v2 7/9] nvme-rc: Calculate IO size for
 fio jobs
Thread-Index: AQHZeYWCsLKktkO0eEaJ0SLd6XY4VA==
Date:   Fri, 28 Apr 2023 03:57:12 +0000
Message-ID: <l5uvjenah7oso6batcdgvkrzpgw362c55hwxxvkscriy5xj225@o2qtmbvyg52s>
References: <20230421060505.10132-1-dwagner@suse.de>
 <20230421060505.10132-8-dwagner@suse.de>
 <6aa42bc9-e04e-cfc6-32cf-f1739944070b@suse.de>
 <7qew4jvwfgvpsqlci6dh6r6vjmzrzaphbqzzxqvvpdfadkj3ab@vxvbvh26bvji>
In-Reply-To: <7qew4jvwfgvpsqlci6dh6r6vjmzrzaphbqzzxqvvpdfadkj3ab@vxvbvh26bvji>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+uwzLvbmM5S3po29WBW6b8eCqx1SlTxNTavYMlvhYMFOobORGmmf0A5vkhkk?=
 =?us-ascii?Q?5HnLgOOyZ+Am9FYKdyqrnX2XB4ndkXyus3mlVQkQ7nYAaq8TNIVB4umnfF7h?=
 =?us-ascii?Q?jJxt0AtZQGH2wNm8zz29fHokEul7pB3x4cCZVSfK4zRm2qKlHnzDVrp5w6Hi?=
 =?us-ascii?Q?p3kjHlQmyUnzZXT0SpkIAi8uyiDO4FYNgUc0Rq6EDLze6fXHYg4EpwmTMlTJ?=
 =?us-ascii?Q?pk/T/Upp7ajScGQOCzV/xYX7y2Z0oR5sD6sn3gLbk88GmKDV10BDdaWMhu5s?=
 =?us-ascii?Q?WiZ/MzVtiSDbIpPzXtcTIlyiTC4o0B5XiG9vSYOjAmbBstM35bcpUxYK3Jby?=
 =?us-ascii?Q?3gzdyrbNDNuzP5QUrHKDwpTX/d17F7hlr+W6L4G9pa2Hf04O6Xk2Yx1ed/aU?=
 =?us-ascii?Q?SogLgUK6lXv9hRbSjf6SEYNnmtW8N0/Su1a8S6nQkuwQEAvY+zadhpKSsSX6?=
 =?us-ascii?Q?OZXghJL1eY2cy6bj8kvfJ8zxcJ6GzzK4SO0FdMLqVW+KbG88HEoZctTWLXKm?=
 =?us-ascii?Q?BjufXB9XOzObdZMckMhJBTFVT4t0jbg5qP3LRvjYgQoDCRCYSFlFtG6rj9dU?=
 =?us-ascii?Q?1Nwmu4ai5WfpaobrSgwCOx3JALf5bGlpQJIAasFePezJBchIXS9CKBfhn7U4?=
 =?us-ascii?Q?Z5UDZle9CPykL5+F74q4yRxGihIPHJPFJbFpp0DltocshsRwpIb1AighObJ2?=
 =?us-ascii?Q?vAmEMeK2snhfNsnOrCabMGbnvx1RmHa9wjIRQ51H2Uyp0wHdEo2tLPwdPSUm?=
 =?us-ascii?Q?02f1pyXlMEXEwiFQZZVd0H2lA+pnuSjPcFCy5g9M+g5zRtfn/CFfQ7jbBp3w?=
 =?us-ascii?Q?ytGUvmprRFXDqQnzMKNfIoFBl85TkoTJe5I/7vXS/Hm85zRoMQPiMjRKyVX/?=
 =?us-ascii?Q?XuA9kgxnA/eEvDU3UccGpQRm9ciPGtNR9Nxd0ERCTcFQydDaS7EhCtNylPtt?=
 =?us-ascii?Q?ZJtdDXOIsvQT2Tl2gM732fVY4w7azKJL99Mi/u3C2oxbI3iAfMugQQ84lwte?=
 =?us-ascii?Q?bIz8QcZj89XLIIwxsmh6W+9EedCHLpc0UzMZ10TMFU0KVicQS4rDTMDw0qN3?=
 =?us-ascii?Q?YyCSCMW0Wm+3Lzr4fjGkEsEfYlvdbq9kilYq3lWPDXj/qw65zc5uAHVF69AI?=
 =?us-ascii?Q?PQivRd1u+pGc1tQD32LzVV0++0+3VjbngmFbfthdu/eMTHgeKioFKH9evX/6?=
 =?us-ascii?Q?AayiJk5vVVTQMsdKMJd2u9TefC1pme0MtWyLsKHU0j6p2MvOInjs9J980bLb?=
 =?us-ascii?Q?keFFy2OuiTW06Eab37CEI7ODzYBfJwo5Hb74O+e2GoKu8QUnm7tDvU0pXyug?=
 =?us-ascii?Q?n9D3NlQ6EzS4FA2TEd9Svc9WpiWhnmPsO326BxwUdicGP8h502lV/+4Iq4aS?=
 =?us-ascii?Q?6Dgov3qcYF8m9lxzWcUvOAtfeduMZILnfXag8ML15DeJtp3aiwke1gWILLNP?=
 =?us-ascii?Q?M+GRjdD/QcQgyPicN7qFEI0h6bHvnmz3VuAMqFO1IyyyXr4WFwTjeXzs/04g?=
 =?us-ascii?Q?TJy9kMrRsrvb14arKFDVL7sQojkaxugvb8CWJBZ4pv+VCyKw9PHqSCeaOxTD?=
 =?us-ascii?Q?7P+agXVv4PZfVUk2f1C6NgQEyUnQXxqNi5Y0sGsvJF3CoT2IdOgKDVkJG9et?=
 =?us-ascii?Q?GEceAmA0haOZmy4ovBu2ABU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <843E63E576B76E47B19E7FF7BEB36A0D@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: B+1O4Zzy7qR40ksxO1reLu7cOgFB0yBEgN+TTssRz4iqL8MGJY71mo3uOcXe1ru5pMZwrQGY/9ZKzF6KQw2tfeeSvGrcZfyR25v/W0CAyR0wndiEP9HOsyNsZGVnZxO9AUvor+jjk6ilODdkGqHQWcOR2uCLbb1gPqST8g6f3AdQsU8uEfCg2ObJqFcAwxMDTKjh2qhjOc9yOJEq0E+N9ZQ3cGVeFtgoQve67yk1q/zneUHRPA2axDR9Eg5XWMAcJaRTQ6R8IJxwrm4x+cWQXkZ2TIWmTZ4VOoANaO6IJ0jTb2zvMcHMFXFVyZKQBjmmsl8IOkozmL0vpiMZRkthzgI3eMoKKzD8vVe3YuSpK0nbckUkTbvx6tGW/wgxhoyLkeF/6CldBv7dR8PWxuCybFBB2GSCAbuTlTQaW2FyZcDshjAtdWdRCOwucP8oNyfPtzvgWVw3vo1pv9BU61ib2FhS7SUeMXFN4x/SVFOqwVFpscXngXcaBJMFoU/hQKkkKFhkY6Bh79V+8pVeiXrNX+x5vluSiK9/k6oPxiRY/YV49Uv7fT+vNnM2qJgl4VWKDSYZiYomt92E71UaQSapEZW8jl193bvC5Tr+vOeY3sN2iTQ/NAgydADJLVw661iy7Ogm0q75cQ6YykBy/Yh2+mn/HdENe1jBG3V68flazkdrNReIk2P91LipHBFpCe62xayzlomZMpq36spA58Tmm2NKTLXhL+lvuleUIBfuvtaBPRICz3zhdyNf7keu+TxwhtIW9QwTnn7xLAOvWTZGusbxh4PzTrLL5R3UbZvkDLS/46hyCspKEr7cmbQMDQKttP08aQrNbXqo16FAa8gXP/i/cuXo/YAnun6SLQ/LYWLAvqP4Oo0jJxGnrrUy5N+cKGLv/knbkA7v8E7eFRw5Zmq5FLBBwhD9icEjmnciCjo=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2799ee1-0ad5-43ad-e862-08db479ca586
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2023 03:57:12.0455
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zD8bTBKqJeMxSQSleVi4MudW0N1EkOLzyTMe4FeIy7DZcchX9DgAitCMWGONCdAiCHmZhOcqZ7chplA3URZ8V+yb49oTR08TqoWLaHf1nWY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR04MB8375
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Apr 21, 2023 / 09:03, Daniel Wagner wrote:
> On Fri, Apr 21, 2023 at 08:33:46AM +0200, Hannes Reinecke wrote:
>  > +_nvme_calc_rand_io_size() {
> > > +	local img_size_mb
> > > +	local io_size_mb
> > > +
> > > +	img_size_mb=3D"$(convert_to_mb "$1")"
> > > +	io_size_mb=3D"$(printf "%d" $((((img_size_mb * 1024 * 1024) / $(npr=
oc) - 1) / 1024)))"
> > > +
> >=20
> > ... ending with ridiculous small io sizes on machines with lots of CPUs=
.
> > Please cap nproc by something sane like 32.
>=20
> Yeah, propably not really good long time strategy. I was wondering if we =
should
> make run_fio() variants smarter and do the size callculation there and no=
t by
> the callee. If we do this, we could make the number of jobs dependend on =
CPUs
> and image size a bit nicer.

The usage of _run_fio_rand_io() look different for each test case. nvme/032
kills the fio process when it is no longer required. Then IO size reduction=
 with
_nvme_calc_io_size() will not reduce runtime of nvme/032. I think nvme/040 =
has
same story, since _nvme_delete_ctrl will stop the fio process with I/O erro=
r.

On the other hand, nvme/045 and nvme/047 may have different usage. I'm not =
sure
if these test case needs I/O with all CPUs. It would be better to have othe=
r
run_fio() variant as Daniel mentioned, so that their runtime will not depen=
d on
number of CPUs.=