Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754509AbXJAIoy (ORCPT ); Mon, 1 Oct 2007 04:44:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751897AbXJAIor (ORCPT ); Mon, 1 Oct 2007 04:44:47 -0400 Received: from nic.NetDirect.CA ([216.16.235.2]:36956 "EHLO rubicon.netdirect.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751843AbXJAIoq (ORCPT ); Mon, 1 Oct 2007 04:44:46 -0400 X-Originating-Ip: 72.143.66.27 Date: Mon, 1 Oct 2007 04:42:18 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Pavel Emelyanov cc: Cedric Le Goater , Andrew Morton , Serge Hallyn , "Eric W. Biederman" , Linux Containers , Linux Kernel Mailing List Subject: Re: [PATCH 4/5] Move the user namespace under the option In-Reply-To: <4700A7C5.5080005@openvz.org> Message-ID: References: <46FA7D4D.8040808@openvz.org> <46FA8087.6060307@openvz.org> <46FBA2A4.2040909@fr.ibm.com> <4700A7C5.5080005@openvz.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Net-Direct-Inc-MailScanner-Information: Please contact the ISP for more information X-Net-Direct-Inc-MailScanner: Found to be clean X-Net-Direct-Inc-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-16.8, required 5, autolearn=not spam, ALL_TRUSTED -1.80, BAYES_00 -15.00, INIT_RECVD_OUR_AUTH -20.00, RCVD_IN_SORBS_DUL 20.00) X-Net-Direct-Inc-MailScanner-From: rpjday@mindspring.com Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1614 Lines: 43 On Mon, 1 Oct 2007, Pavel Emelyanov wrote: > Robert P. J. Day wrote: > > On Thu, 27 Sep 2007, Cedric Le Goater wrote: > > > >>> diff --git a/include/linux/user_namespace.h b/include/linux/user_namespace.h > >>> index b5f41d4..dda160c 100644 > >>> --- a/include/linux/user_namespace.h > >>> +++ b/include/linux/user_namespace.h > >>> @@ -17,7 +17,7 @@ struct user_namespace { > >>> > >>> extern struct user_namespace init_user_ns; > >>> > >>> -#ifdef CONFIG_USER_NS > >>> +#ifdef CONFIG_NAMESPACES_EXPERIMENTAL > > > > is it really a good precedent to introduce Kconfig variables that > > literally include the word "EXPERIMENTAL"? > > How else can we call it? I proposed one config option for each > namespace with "depends on EXPERIMENTAL" dependency, but everyone > else said that two options are much better. i don't know -- perhaps something as trivially obvious as NAMESPACES_V2 or something. i just think it's awkward to take a word like "EXPERIMENTAL" that already has a long and established history, and start jamming it into config variable names. but it's just an observation. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/