Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>
Subject: Re: [PATCH REPOST blktests v2 7/9] nvme-rc: Calculate IO size for fio
 jobs
Thread-Topic: [PATCH REPOST blktests v2 7/9] nvme-rc: Calculate IO size for
 fio jobs
Thread-Index: AQHZeYYHsLKktkO0eEaJ0SLd6XY4VA==
Date:   Fri, 28 Apr 2023 04:00:54 +0000
Message-ID: <sbkboyc3tcad4g5zjdtko6ardhythnaotwp3njchbotnabhlun@mhhvxut6q2av>
References: <20230421060505.10132-1-dwagner@suse.de>
 <20230421060505.10132-8-dwagner@suse.de>
In-Reply-To: <20230421060505.10132-8-dwagner@suse.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eJYHD01yp1it9irOlJRL+6kAjom8wfJgfYNXJd7FgKTVl122wxDKBfEljQLt?=
 =?us-ascii?Q?tBPX3/ajqB+TgHW/nyCrRtgb/WcYt40gkwjFiH1uoOUhAWPcwK/A6iKK03F+?=
 =?us-ascii?Q?+E84u5I5D5jN5xLX2h3EpWSoJFrdE1Ned/81RtGHNj3gYdtSAY2DLipg9j8A?=
 =?us-ascii?Q?MqaGuDnkjximDAngtszwdE1lgalLYDDGgBCXLFW0+feJe6Ha0+qBq4qVufk4?=
 =?us-ascii?Q?RIbCBHYO48Hgy/NS4S1pChLqbjaBT11sACSGpBmq3niwgi395vytn1QBrzce?=
 =?us-ascii?Q?DS2Z+YgJfZfAXOzRsd2mkez3MgpzKL8f/Qbtvj927TlDuj79GyXBId7VjY+C?=
 =?us-ascii?Q?UM+J6ubac1jd14Xr+YcNTejMPm99B4AtZS+A/EXZoFiZTzWrGNU/RQYsd07n?=
 =?us-ascii?Q?HeAy52oWNMZqqdmAHjNM5OGps9TVxz5xRxUsZgDSr+R5q25dRl7n7UduzO6n?=
 =?us-ascii?Q?f2eWb6FBfUj8lBwCFOyIcPd4v8vpsHYmTNFhmOhbdjvT4sR4cYsMtwM9uo7j?=
 =?us-ascii?Q?Sg5S7y7UAartWUZpiEu8/RbHRyFZSn+PeDpzysCOZzf6zOVk1rDIwzMbqjHY?=
 =?us-ascii?Q?BTqX6HKk8sHeZHd3N8tWztkFLUzoJRmOgCsDeAP05CXOogYnhUfiykDnifjF?=
 =?us-ascii?Q?Ih/KLC7jgomacVpki8OhOnesnvZzyxVMnfpIQACqQekVq2z66XyQ9CMlJY++?=
 =?us-ascii?Q?76pN/ogab8Tmh4sW+RXz9Js6CZww/NUwJW8ghxxiBqwKiYgeIfpR/DPFl3On?=
 =?us-ascii?Q?oSi7aCbK7oUjZp+QB0zobSMwSFMZiv2f8/i273T0QL2SiL5fftSomJXj7Jk5?=
 =?us-ascii?Q?lIMihF5tv9skFY5XJl0l9hL4uDSK/mN7PBDpqq0Gec/SRDynbHeVBG8KVPgm?=
 =?us-ascii?Q?zha7/YXRZjcjMqZi6jOU2ZBsmxDPu+Ip9gr9gItYcx8ZYArAlxPMSsQHHzJq?=
 =?us-ascii?Q?kTkDkXbbqQh5RX1J/YJFcDn536YA9CE++ZvAJQJs5aIsUZ27CDUzvja7XaBH?=
 =?us-ascii?Q?AZToMvSD53V+eH/CkcSXZNQapiMk3iTqBk48AJg3cSns0UHdBE5RismFJfZ5?=
 =?us-ascii?Q?7Ech0eG0fQ295mUuPpnqC16oCB+JMWROc3yr3GgvdVB9fkxF1ianT3AK5Nfc?=
 =?us-ascii?Q?aAD2Okv9MMdYEhfg0yjOIrZLQm1rwdTZCXqfg9fdu0vmqWYxwEVy0lI9SIL8?=
 =?us-ascii?Q?6xX6n6rZaqVmtfSJYpWpLaFgbYd+f1tIqxPNMht/6Qu55dsXuW/b2jJufdAK?=
 =?us-ascii?Q?58A9R0x4TYQNpUoE1fZD7Qwyr02rtoQXvlIy4EMjXPvUtIw3duaud/dRV353?=
 =?us-ascii?Q?wSHs4FBItY9ynTp0jmSv4Xw7513mj5kW4/+wCY+OYClcG4pxOj/aPzDRL424?=
 =?us-ascii?Q?fqE8G1SKZZQ8Ay4a1Iuir4ta19JR/pAHV68imYCx962F3Mi48dubTOECumOK?=
 =?us-ascii?Q?LLV3uAL3Nf7yNrq0O5Xtv2+oguoXnuud54nzhkCS45J6hfj60bYx41Y04Tfk?=
 =?us-ascii?Q?RmimihT/1/ARBsFrOPx5CsEFkSQcS7xaM2IA1XKeffcqFfGBlF8G8boEd7TH?=
 =?us-ascii?Q?2YW8mzl2Sqj68KL/g/jFNvJCFZ1gpcETbb635glcZeuixDXoa4oYCrC8tgZr?=
 =?us-ascii?Q?Lx/BkIq2Ap1eF/kJqH7L+VM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A8FEADCC1FC2874F8074997279D920E8@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LuPp0khW2lh6nEzOY5Ac6+EnOVdO9qYZqwKUB76gOVAhJgMsBT3ysZ3N3mZcWNY2QKGolV3DO1pv7pYSGrG1IjF1PUjUvZTNrUnDDaLiJgAwmwRGKvIQ1OY9koYMSVNXMItVPYQS03esBXJuGKxwSo0+TCnCv/7eSeueZrKqRL1PRR8SZN1sZtQkJlEf3CSy4/AFrPyE3v7mnAyoaqdbp0mUh+3sV+oepV4dNLHWHIhMzg7kxbRyf4hDIzPx71ysOqDwlQH51ZKsuc7sVBbNwjslsFshXBtinOJQU8bgzAVe/7FA1YQdlyw3dRxQlsXNWxVs0IQaqog2nt+yYJ3eZmdcwb6ZfOy/NDGhR6ibSenXgki/naTtFvTbAfTHTiwwSe+BF2mTy8rpRmGNcvP/tAMwUirYrS1ZV2nlgjuZiFu3P7Q4VfBD+3rBpYYWJCipQrGZgdpk0r9DYEZa0QbZEb7DYio8Lw1n/vEaL0NfproR4ta5eclJoAJCR0AhEMp8dRFWMZ7kS53oNG3KzwUYU4lwmmP9y1LQDMJyei5ij6dSKE3zxebGO+enKbI/dCt89Ngj1l2fTkByNzmk2NiMulGojjjDHLg8vhkwrHsii4eo9PVxf5OQrneFiS8czq+8a7x+wc6FFrMFl1XhVD0KxtbhWw0BzfHeyj4DNq6ldhp/+ri/91uPYNfigJrO/IFTgB48kHxg0f4lcbX615vSyvLFPUpji5x3OopyfhosTGRl7BCgAY8AnuwUXzW9cp/Fu5mfs5jqn9d/mKUyda49Bbm7OOYs+MjTaI9FkZbPIcFOuLHDMd8TjUlvBE7wXLx6ZEjOdy47m2hdEJzNTnJskfz6Zyxk68eC+/1DHLhxEmILINNCuXG1xqTh7B/WIaBfv0KPJXNqDIekWmcWaJjgaxzO9l/1+FVqjFEFRumkGss=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14d13f80-91cc-4106-a97f-08db479d2a42
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2023 04:00:54.7242
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mqdB7J+k8re1fa0c4NavSmYAzcSSsPKA3M1hHzG0R+H+3GXqfWhrf2q8SXEvPdiGinvHqC8P8gMb8iyXiiOa2OBo5G+ZBdtWgVt0Rqh5LVk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR04MB8375
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Apr 21, 2023 / 08:05, Daniel Wagner wrote:
> Introduce two new function to calculate the IO size for fio jobs.
>=20
> _nvme_calc_io_size() returns the jobs size for _run_fio_verify_io()
> function. Reduce the max size of the job by one megabyte to make the
> test more robust not to run out of space by accident. Note these fio
> calls run with just one jobs.

It is not clear for me what kind of issue happens without the 1MB decrement=
.
Could you share failure symptoms you observed?

>=20
> _nvme_calc_run_io_size() returns the jobs size for _run_fio_rand_io()
> function. Again, the jobs size is not maxing out the space and most
> important it takes the number of jobs into account which are
> created (number of CPUs).

This patch has two purposes, similar but different. It would be the better =
to
separate them.=