Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>
Subject: Re: [PATCH REPOST blktests v2 9/9] nvme: Make the number iterations
 configurable
Thread-Topic: [PATCH REPOST blktests v2 9/9] nvme: Make the number iterations
 configurable
Thread-Index: AQHZeYeYxsiB87D1TEmk+smEBQZfkg==
Date:   Fri, 28 Apr 2023 04:12:06 +0000
Message-ID: <yuwidfmwcg2iue2fm4wqyd2p3vmzo34t6hqr7rvf3d3rkh3ag3@wvpu4f3aqhly>
References: <20230421060505.10132-1-dwagner@suse.de>
 <20230421060505.10132-10-dwagner@suse.de>
In-Reply-To: <20230421060505.10132-10-dwagner@suse.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ik5DEnpicp28yf8xEtSiavx+ShXhK4e/T7U2/yNZtFsBIHUgGpNrcbg2+E3+?=
 =?us-ascii?Q?4RiilDRwxT99PX/1/G5j/EUc+davhr4LqRKhpnAlEGnDty5zEImfoLIy56BD?=
 =?us-ascii?Q?MA9j35hbpHCRvgIZicfrlME4aqf4wsDncimK7z7j05hbc1uPMRCi+hfsvxzE?=
 =?us-ascii?Q?wNV8fDYPlOrM8AuAajnXq41ygRFvcO8vcQQZNPDI6ajlz8hYZxsNbp4C+GaD?=
 =?us-ascii?Q?3RiCrwo1JM2Fx8Sm0HIhcGxPhkLsxy2Z12aDsXQJlPX9szYBMYASJm68zOdC?=
 =?us-ascii?Q?xNT0fIQYyAsVyy74jztjHFwzRrBXmoNT2pe7Unrt0ejDvhVfGEzgXf4rX+18?=
 =?us-ascii?Q?6mH/H9j2X32i7KPyJHOBJA3lEqj0TEg4d9GPQhbzxj6addqX8M49Swftcr4r?=
 =?us-ascii?Q?2nzonNvkwjnKN7+PqyvRqh4HEmhLG9cWljvGlnvJ3J7BF+YfsWs3RDo87rf6?=
 =?us-ascii?Q?AIymfcETiOPyOaSGc/N3PdEOYws5i2W+qjaI0WcNrgOfBTRA9YY/jtzbqItN?=
 =?us-ascii?Q?jh1VIpOTM6HIhiz8vM2nzLixWI6JXm12E8HBJk92TWMB6t4wKofuMrbLOPu9?=
 =?us-ascii?Q?a0nQpzLkfmE2cm+ZwMUdQGGPaQaIBlSTIVrTTLl4wQO53WgpP2+jMokCvS0B?=
 =?us-ascii?Q?xvVaKYOQUoODJnznlxFmBYnRE3e6lZXJed0iXlSeql/sLlJiyqcOk5sAaIlg?=
 =?us-ascii?Q?PmUT2bfqGhbS5Yh19xlHd0wHalRxx3/V791NouhfwQoBfYZ4wyTa21pSoE+J?=
 =?us-ascii?Q?U5OylZU4fESQHFpkX5EmNUxd+k1npMmgvYO5DfFwbDfAxo2DXl1GWVhE4+oA?=
 =?us-ascii?Q?tc9dIYA6tzTBdlWM0UP41vkYdwuRM5RLnyPG4ACqPCuJiiMPLho0NPGO0BFT?=
 =?us-ascii?Q?2+/bm2Pk2mH8yc5OK0mpKePG9gKC6ctjIWOyq75H6KovqTlEo/JZ+qrsGbxj?=
 =?us-ascii?Q?/XD9qzPSxS4v8EhX2jdai6OrZh8HkckHhGF5cYZZvokL3l/i8rtdYkeVUDBu?=
 =?us-ascii?Q?DBlFSPYo7UhPze77aMp7dUC0pJPgRN3pHf2o2rj6p3Hjlk70sTW/Cf0WuiYg?=
 =?us-ascii?Q?WAEObUiSe4eYDq+rSlyHOeqgfgJW/ulIuL8FE0Zh3swzKQ90IdWGis54yGej?=
 =?us-ascii?Q?//pEZk0LFhDFsasw8lD34gpLZsvhYs1VkUVPmfVx64YVb7hkzzHMpQovilQN?=
 =?us-ascii?Q?6Oda2jMgiGbu2Znv6+ajivT+ctOjghkDDUgftD1SJSqLuxlFK4J5SqX4zh2J?=
 =?us-ascii?Q?nQSulyCs4L5xoysbCdt0hxNpljuZPNbAtwq/gFEnNoNu9Er97wIpuq8NRvQW?=
 =?us-ascii?Q?emgRKycKjZvX117LKQpt7LgI4IQpnHOAPKcyxB8Y1DydqfX9FR3sYlJbm/2p?=
 =?us-ascii?Q?OSHTPD330XNjGV7/hgB6bqEJQY9UAuzCb2iJQE5NnjirIpYR/KgT6GoIsnn7?=
 =?us-ascii?Q?zXCRuobTZmQv74ArNo256LEP1gGlX2JUvr8KECrLUYU/84gLHDybwAz5xie0?=
 =?us-ascii?Q?1mvhL/Kr6s4A4ik7yufJrsBBTkE6qnyDPlsABlQot5UudToYfOezIarFmGju?=
 =?us-ascii?Q?w0uBVabIg3VodC+TigaCmvwpbPbFkjPwdsZeGYcd/GS4bllBtWiBAzYJDAsu?=
 =?us-ascii?Q?vnJTYu2ttqO2dBge9tq3G6c=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4FC025F5662CCE469401A0C8674EB9C5@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: h8yHP3Vo6/He1b4lTBjGLvcm8tnCkQYKmSizBWZR0SnwKg8f4V/yQ4daoaUj8p9634pX+ZoYrAm714wWK2H0vHM1ZNd9N2zkKXBA9+DlCqOJEcXEs06BHlpZs8XETp4vB3LVgj2Z6gVSgJ+Kq73QIlDPNSAR18oQixaJMM+SmO/ePp/yEifalqwvBPwwOkgc8fKZfB5lKPDYVTue+wJnJmXVWejPcWeHIZZLoxQqqsSIpQWo1moeyGS7F1Us5smVfbfLeDUa2NJt4BFtqytHrf61QZnn/GSJHL+B0UI61QQ/X/YlX/OdBon+eXypVD9tKURy9ZqZPSAjhB+I+gjMBPxp93F6gBYHTr7MMfLGOH1zEAl943LKa38WUlo7F3VNJ3teiMFkOcvGnPMUIgXKqBQ7m0EzUawGdE4t8cAPX9Z2NsXeTVgtTaB2+fHi1a+5T76ovbzuCM4NKDxobpSGTUlDEV1hcfmcsSqOPCXA88jO11dcDeoO6CRc3kTbTLE0eKQUAwMzVaYv0UH+Vm32pCK3rAO+N6glqnhjSfl9b9JnkYhlftHhO1gqFXyvQBgEhF7v7ANz/WNM2pOKD3CfvMj5rnfj4HABupupf7ON8rbGTw+Dp3w013mOXyrqc+JojWTXYdyDNNnlmcEcC1YH/mHjJ1S3LgmwtvZ8X96QiTgA3E875CxhdERc27jX9NBNXovxzlzZkWxQUleN6HuLfLXXIXBoVeDreIOxPLbZvgkRSdhJZuL7iVHJUbNRSts9N6HuKdohGsgpf/QxkBmKsFODMC3SP9fD+8xSaoHYOI3Mya2FTQSBb+/nMB6qx1y8i1+5+LnYxVjkESs7nHuw94dAf/z2c5rA8SNi0qi7fV5Uoons2kU5qvFLoyhIBAVzwh4m2HE0kFKnLnJhU0liq6JRFmZVY6Rwk6xGZLNw3TI=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bf06e2e-fb72-4ba9-167e-08db479ebab6
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2023 04:12:06.5378
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uKDrUOeFas5qphvGXx7yfNRo6mVTVRssGYAzTZUiG3g4PjUv9ybSQHwaVlL6jr/tqL4ewVHn88/iN6I3wt37qupbYE6vaaPR0yEDaUWdgro=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6771
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Apr 21, 2023 / 08:05, Daniel Wagner wrote:
> Some tests hard code high values of iterations. This makes them run
> relatively long compared to the other tests. Introduce a new environment
> variable nvme_num_iter to allow tune the runtime.
>=20
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>  tests/nvme/002 | 2 +-
>  tests/nvme/016 | 2 +-
>  tests/nvme/017 | 2 +-
>  tests/nvme/rc  | 1 +
>  4 files changed, 4 insertions(+), 3 deletions(-)
>=20
> diff --git a/tests/nvme/002 b/tests/nvme/002
> index 6b8484844b4d..c28035483514 100755
> --- a/tests/nvme/002
> +++ b/tests/nvme/002
> @@ -20,7 +20,7 @@ test() {
> =20
>  	_setup_nvmet
> =20
> -	local iterations=3D1000
> +	local iterations=3D"${nvme_num_iter}"
>  	local port
>  	port=3D"$(_create_nvmet_port "${nvme_trtype}")"
> =20
> diff --git a/tests/nvme/016 b/tests/nvme/016
> index 4eba30223a08..c0c31a55b190 100755
> --- a/tests/nvme/016
> +++ b/tests/nvme/016
> @@ -17,7 +17,7 @@ test() {
>  	echo "Running ${TEST_NAME}"
> =20
>  	local port
> -	local iterations=3D1000
> +	local iterations=3D"${nvme_num_iter}"
>  	local loop_dev
>  	local subsys_nqn=3D"blktests-subsystem-1"
> =20
> diff --git a/tests/nvme/017 b/tests/nvme/017
> index 0248aee9bc41..e1674508f654 100755
> --- a/tests/nvme/017
> +++ b/tests/nvme/017
> @@ -18,7 +18,7 @@ test() {
> =20
>  	local port
>  	local file_path
> -	local iterations=3D1000
> +	local iterations=3D"${nvme_num_iter}"
>  	local subsys_name=3D"blktests-subsystem-1"
> =20
>  	_setup_nvmet
> diff --git a/tests/nvme/rc b/tests/nvme/rc
> index 2aa34fb0c9b8..bb135502220a 100644
> --- a/tests/nvme/rc
> +++ b/tests/nvme/rc
> @@ -18,6 +18,7 @@ def_hostnqn=3D"$(cat /etc/nvme/hostnqn 2> /dev/null)"
>  def_hostid=3D"$(cat /etc/nvme/hostid 2> /dev/null)"
>  nvme_trtype=3D${nvme_trtype:-"loop"}
>  nvme_img_size=3D${nvme_img_size:-"350M"}
> +nvme_num_iter=3D${nvme_num_iter:-"100"}

The commit log of tests/nvme/002 says that "Test nvme discovery with many (=
1000)
subsystems so the discovery log page exceeds 4k.". Can we fulfill this test
purpose with the default value 100?

Also, nvme_num_iter will need description in Documentation/running-tests.md=
.

> =20
>  _nvme_requires() {
>  	_have_program nvme
> --=20
> 2.40.0
> =