Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     Hannes Reinecke <hare@suse.de>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>
Subject: Re: [PATCH REPOST blktests v2 4/9] nvme: Use runtime fio background
 jobs
Thread-Topic: [PATCH REPOST blktests v2 4/9] nvme: Use runtime fio background
 jobs
Thread-Index: AQHZeYoWQ5FGkdz4ZEKIobo1OJOmQg==
Date:   Fri, 28 Apr 2023 04:29:57 +0000
Message-ID: <bnr5gwlxyfixvajlpzm75mfmizgvq4uibb2b4t5tqij3jmkqrl@ialjk5an7nla>
References: <20230421060505.10132-1-dwagner@suse.de>
 <20230421060505.10132-5-dwagner@suse.de>
 <72ecc5fc-0ff4-5592-3293-f4204633fc8e@suse.de>
 <4ckg7ymu73lfs7zlsby3com6k24qgovkaqky5jmgeoubs7azhh@jtvovyjluekv>
In-Reply-To: <4ckg7ymu73lfs7zlsby3com6k24qgovkaqky5jmgeoubs7azhh@jtvovyjluekv>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tTFQkMt6M9X5HbtjreM2SWJC/HuqLYcLWzp6W5EmlB5KCQozhfmHlpWcmZZl?=
 =?us-ascii?Q?xTbT74x96iaIlXt3VglCRAuwb94M2IVCIWi5N7TsvcC2STr4UO76MoyCdHZz?=
 =?us-ascii?Q?/1iSDK5vGicrj4bxk6PWHO/pxPukL+yBoruGo1afRS/vqDdfiqs1gLhbd4cj?=
 =?us-ascii?Q?Agxb7+l/BanZTlBf+BCXHegL6kePV8Z8uCdUY9FzQYZ8IopRWQpf8SQMfmz3?=
 =?us-ascii?Q?OTFMDhCdAt7dGFL/PdLLUtPWOCflZe9AarS9rpT9+sceVAEsEHsIf7N3L9qa?=
 =?us-ascii?Q?k23hFxBF43Sd9uQhYk+90B83X+QEXepGOolIA+8E7t/1AcC0LXyqtvK9utEZ?=
 =?us-ascii?Q?QBrmyaRuTkCD+9vuro6As5m3ITfpoCttpMe5T1d+319esj+C7jdv/Wc9ghdv?=
 =?us-ascii?Q?KVVSHUOzAzMc0Fs/Ka/BuAfniFTA9e61JqxHcZeSfusEm7N5FQGegifrBwhy?=
 =?us-ascii?Q?3svwZRpQCB9K2420lsHa/j38pfqL+DoisGo9tpQEZumlZK7sQap8/mB906VL?=
 =?us-ascii?Q?UTGtSazkn71znfrxJqLs2PYfUw8CGKqvosoaDCTx8deHAPaDlqIeWvj1JmOe?=
 =?us-ascii?Q?llHhnJz4WupJKeYDwNdU8FufTxOoZZ/SkTW6jrR8U4el9FcxatDsIxLPEqJA?=
 =?us-ascii?Q?MaDpFsR1b/5YKfO32jQMvUn9NWq4oxT163rvZxBIHdNSxudiFAzcGzU6AUih?=
 =?us-ascii?Q?ENVRzh/bULJ1s79cJbrw+nTFyY0E7nqL4XBdez9ZhvsZE2J5DCCGr7RSg11Z?=
 =?us-ascii?Q?zolh4RULex3G8LS49kzD2iQDJY5HsDU0OnVY+sGtqoimmUZ4o0R1qhwFomRd?=
 =?us-ascii?Q?QS9BYkA/AASWh6tHMy52aCRTA5z4bcE3hf3/wx4cVpqmW9esTBBklsPBhnfI?=
 =?us-ascii?Q?gxtHz4YZYyydBsWNbgZTG6YWBV/n5grixC/yX8AtHSgx/l14YqJKofi8u+7r?=
 =?us-ascii?Q?HcNsCvupEd1I+svV0KmH6YPLN15JzYHAEtVyQrHseFeo5zVxLMEazHEKy3v+?=
 =?us-ascii?Q?OekKP4BBMIq8gg3DL0rchZ3Y96n9r+GvVAEB5Wa/FMJgv4IRB5CVhVlXPThY?=
 =?us-ascii?Q?4UC+mS7dCKyFTEF7h85brXwSVljgsyV3c3cG/Uz28WXms9zCr6maIz8wIFxs?=
 =?us-ascii?Q?U2Pg8SfC1bRAtnvKjdnA2aTAtzcWx0/yNc9c9zUCvv8zdIjETorBvV54739+?=
 =?us-ascii?Q?+3yVURQDc8FUm5GEhOo0OBjV7UNBCKzXZNNYmkY6Rma5gZJsDvMKos6Ef7fk?=
 =?us-ascii?Q?C+vZ5yzp/USxL5t4bW/nVQ8CHQbdNpo1ulyz1kz/JoYnrusMfi94ps4xJev5?=
 =?us-ascii?Q?BKaMY/fwcwnoJZ8ZFrxqNBiR9Lr018lHxBMZfHuwsdt6X9MPWamwDtnOqTix?=
 =?us-ascii?Q?ZVXDeOYTsUKZhjK5UVhoSVpJcWufVr8Y88LQuz+no7+1o5P5HBZtIdXfkyj9?=
 =?us-ascii?Q?quS84oYbGLWQjlTFokPFlBatB7Grg8lihI6/g/CMXal2H2ogfd8pL8OAu0CR?=
 =?us-ascii?Q?oyYvKi8W5N3p5dbGUufNFoUzCIv2tOl4/pKN0U/PR46M5jCNVl8w+qfJYXZC?=
 =?us-ascii?Q?/VLVpbtBYSDIuy+Y81v0itzBanFkg+U94+r4/cfPdxp9AYfU6wuDN44udLTq?=
 =?us-ascii?Q?sxMDdOhgEgom6lzdJLKtiZ8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <93909E577C4E9649AEE5F5E2787F73B3@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Ek16oPd5fzX09z9r1QxFvSF7gVMIp3sE0GHVwRy0gge8rUu59K7y6LovtaV8jKoRecMGGsjf2On4XLJ0rPSs0h4fEP9/vYrgHYV9+SaGOJ3khi238Hcb9dZ1QsB+JnkByI2I7rhwEGGYmyVC9Q8cvEyJ6oGLgPEnW1b5wlGa2+eHZKDNm466uCXqPTfeQy7nMreuGmOa4Ab0YI22KLxznT3TzFgrvet/VbbR7M+h/3JloDqcx9fpopp+eEAOH7VdIc9zVZ/8ap01FfDVaAE5ATPEded/tkb1ZXpPa+2Gd0hlfFK9KitVId63nL+nt6SJoU0CL/BSGysLm8g1cgFdDEYl1qtpwPQQae45/NBZBPqGL8m5hknlqcHiXiaMLgPdTx5YRsX2/eYctPDYTbpR/l9zOUByvJRXC5h7n4ECkWbEIGM2LJ+OY4r4FvmsqccJk9jM9ueaFnQu6p8EUg8cx5ct/sNJ0pbiUcmCULSq6mRYDnSj1LHpKv51H+Vp6yYOemPNzEbR2IgBDyfMLWOEAXqkUjWVbQP60nVfdApf6KmmsLZ1Y0a4faTBuRkWJ3mYZByGT8A988sl7NP9FhAWlE4C3GX/MQPX+zM6/ojqfr7eUHNjy04s/iYCF4/NnqA14d1xO0LdSLIcU8WHr0H4AGtslF80Y/wgbZX6mvPmlF0Ytlns6bVY/KDdwolRwfRCQbs07z3vHdu1hHBPrUJ7kQUGOCD/KwVNsZVereysDHPkfmiKOLHYHA7e3l+OMbK620PA2X8+mcLQjpJBw6/lc+ny+kjS5UQsAVlDxq+EgAom/Ao0kB/mkCcGZVjpbcKPcCHUa6artE0TTaMeqrPvk/6ZXtQ2Pt0CEqk1IE5k8osNDJ20x/TXYnWP3YHX90yl9kwugSY8IwC8+KjAwSpjugMHIUK/qCrO6iYDkxA6lyU=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20d82456-1772-456a-7e09-08db47a1393e
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2023 04:29:57.8639
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fTyALGVug4UsE2GvdGGCMRco/w7fhqLUj3dIvk/LOsBiQTb4K3u5eUZdDPl0LinwjpH3mj675eOWmb0uMWp+LwI8LcrdNLQC66W0QXkYXkI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6954
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Apr 21, 2023 / 08:57, Daniel Wagner wrote:
> On Fri, Apr 21, 2023 at 08:29:22AM +0200, Hannes Reinecke wrote:
>  > --- a/tests/nvme/040
> > > +++ b/tests/nvme/040
> > > @@ -38,7 +38,8 @@ test() {
> > >   	# start fio job
> > >   	echo "starting background fio"
> > >   	_run_fio_rand_io --filename=3D"/dev/${nvmedev}n1" --size=3D1g \
> > > -		--group_reporting --ramp_time=3D5  &> /dev/null &
> > > +		--group_reporting --ramp_time=3D5 \
> > > +		--time_based --runtime=3D1m &> /dev/null &
> > >   	sleep 5
> > >   	# do reset/remove operation
> >=20
> > Wouldn't it be better to let _run_fio_rand_io pick the correct size?
>=20
> Yes, makes sense.

If you do I/O size change for the test cases nvme/032 and nvme/040, could y=
ou
confirm the runtime reduction of the test cases? IIUC, the fio process stop=
s
due to process kill or an I/O error, then I/O size reduction will not chang=
e
runtime of the test cases, I guess.

IMO, --time_based --runtime=3D1m is good to ensure that fio runs long enoug=
h,
even when nvme device size is configured with small size.=