Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Chatre, Reinette" <reinette.chatre@intel.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "yishaih@nvidia.com" <yishaih@nvidia.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>
CC:     "tglx@linutronix.de" <tglx@linutronix.de>,
        "darwi@linutronix.de" <darwi@linutronix.de>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Liu, Jing2" <jing2.liu@intel.com>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "tom.zanussi@linux.intel.com" <tom.zanussi@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V4 01/11] vfio/pci: Consolidate irq cleanup on MSI/MSI-X
 disable
Thread-Topic: [PATCH V4 01/11] vfio/pci: Consolidate irq cleanup on MSI/MSI-X
 disable
Thread-Index: AQHZeS7Kk6SGEqv3N0GNziWVXSz0EK9AQtCQ
Date:   Fri, 28 Apr 2023 06:28:36 +0000
Message-ID: <BN9PR11MB52764ACFE8333427750E23C48C6B9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <cover.1682615447.git.reinette.chatre@intel.com>
 <aef2b60d9a3c5a2984b39919561ade5ca9786b27.1682615447.git.reinette.chatre@intel.com>
In-Reply-To: <aef2b60d9a3c5a2984b39919561ade5ca9786b27.1682615447.git.reinette.chatre@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uvS/Jr616nhuNfqiKjLcbULu99RTJl/KC2I8MuNmbiFY6vyu4isMBdytM2gw?=
 =?us-ascii?Q?jy0AenX/QUmMZ85sJXuo3pWMjvvY97C6//aq82fQVtTvu1wXp/tSSu9uNXkB?=
 =?us-ascii?Q?4YXHe9Lq8V1+MWDHkM7OtonWi3EY3r/MMWPVW+H2niDxQz7S6xAIaCCmugx4?=
 =?us-ascii?Q?XlIMXyrDvQ0gmysC+Y8C/b9YS9MrRSoZAezxZSjcxcgUJsr2OXuymaCXojWT?=
 =?us-ascii?Q?XmyDgF8QM/23HeAy9vjmrjxsWv1JQKOm81NSPvbH03WFdbh62gPv6l/FrzcF?=
 =?us-ascii?Q?n1XbltWJmf7mu6ztpSIrLDXiJEcYLqGe4kbyQlu1oumCxSRXyASe9echHSUg?=
 =?us-ascii?Q?kzZFUXFv93Z0MGcjaSLBn49Rve4EGfbrJHeJ1uyryTQu9yJorff/qCVOp0Ly?=
 =?us-ascii?Q?7xQnyshf4lKx8NoHqHvTAPzZy9BulpsyqUuXKqDljX6cW8ti6fQlhGxxIBZw?=
 =?us-ascii?Q?3to2HcYZnMslM2nREMBhvbRb7lBbep3ENuQCzMsfe3q3FRDu3ZUajTr4dfy7?=
 =?us-ascii?Q?cbxLv6Ap0pdXz0aKchm1ciw4FPR5+SoIFj3jHI2lKO3olICVXqxJxGonUQh2?=
 =?us-ascii?Q?LEWF7PQd7ZikQM2UEytHiFwvYfsoXg4aXnrR7uigIMslAhEtKEtd19gAgPYi?=
 =?us-ascii?Q?H1QU0qXsDTabYxNSxHpgu7/x+dsTqRBmQdV+vU4/MU9PsxzrgzTmCHBZ17cH?=
 =?us-ascii?Q?LvXsEvCrDY7vzCBYZZ9Pwg/FX+goiuiNpha/qlB37fO26YRTfeczw7iCVGcQ?=
 =?us-ascii?Q?Ak1J0G0ete8X4vkHhhSPZCOVrQjFJFAWenB/K8NugViHstEZ31C05Q4ALY77?=
 =?us-ascii?Q?phg+0RzJxU8jWqL1lIOwbgVZDizm2dO7lwlDbokFcutHmw5cQLAJ48qvI9Wp?=
 =?us-ascii?Q?CxoGiidKhWSpRfeXGz3bldwHgxPEUDJbRftqqBDnE/n5srh/qZolAclBFFpN?=
 =?us-ascii?Q?0N7vKQBsmnaSMEG8sUioKd7s7oDwLDmfsoa8xWnP3EBcjYpZ6PvNrJj1k8CB?=
 =?us-ascii?Q?lZAaYL3LIV0gClFmT6p3+mnHFr0EweFJfNgKrcvr0LiE9ytT1shqvUPv8kze?=
 =?us-ascii?Q?xbZO2VLJ5egbD5MHDl17IqrlR1ZcI9qHTZPzPf2TIG3AgSJZWV+K81L5ozYM?=
 =?us-ascii?Q?iYGr0pi3G4h5RKeV6RI2AmlPOo+PFW1W8tfD1U2Azi9Fun4ngsWVBuO07hcD?=
 =?us-ascii?Q?pWmCSg/NVby+zz6wiKqMQ3xJAW5I8k/yWQHefB+1ucKpDCL7ldoyLXkY3sD8?=
 =?us-ascii?Q?LfC6lmZRpruWjlRkdkJBdvdxR7RoT5R//A+RZyAkjwc5JyNyCvokUlTJj/qd?=
 =?us-ascii?Q?qzDMojXasyvhFi4bqO6Fuc/IlUX4/1eo8obC9Wkxf/yXFMashPWab02EPG2p?=
 =?us-ascii?Q?NpU9lPA7MivtQdqWMzT0uPQh/BvDoRtPgOZzpjzsnYzINRUa24VoBMIO38Ku?=
 =?us-ascii?Q?zgh2rGo6QJB/oeQtVrP4XYhCxFUc3VmLzsisotgED/YrPdZIgkojhhbgzCCc?=
 =?us-ascii?Q?V2sqaSfICPiywF017JMN0Yc+tZz8242zefUxDeJ2gekASOMf+feumPqMssK3?=
 =?us-ascii?Q?QMHLtg3p7M6nTwAP2NWaHdWseqqZwlVpWp+f9t3E?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c7dadf04-7d88-43f1-9dae-08db47b1cc6b
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2023 06:28:36.7089
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rfKPLtsk+9LUgJnKpxzQg5HSovoj4RzkzmX68sRlcQCGjhez1uw7r5pVNyCNATafbgww49/llfvW9WOOwEg+QA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5581
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Chatre, Reinette <reinette.chatre@intel.com>
> Sent: Friday, April 28, 2023 1:36 AM
>=20
> vfio_msi_disable() releases all previously allocated state
> associated with each interrupt before disabling MSI/MSI-X.
>=20
> vfio_msi_disable() iterates twice over the interrupt state:
> first directly with a for loop to do virqfd cleanup, followed
> by another for loop within vfio_msi_set_block() that removes
> the interrupt handler and its associated state using
> vfio_msi_set_vector_signal().
>=20
> Simplify interrupt cleanup by iterating over allocated interrupts
> once.
>=20
> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>