Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Chatre, Reinette" <reinette.chatre@intel.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "yishaih@nvidia.com" <yishaih@nvidia.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>
CC:     "tglx@linutronix.de" <tglx@linutronix.de>,
        "darwi@linutronix.de" <darwi@linutronix.de>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Liu, Jing2" <jing2.liu@intel.com>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "tom.zanussi@linux.intel.com" <tom.zanussi@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V4 02/11] vfio/pci: Remove negative check on unsigned
 vector
Thread-Topic: [PATCH V4 02/11] vfio/pci: Remove negative check on unsigned
 vector
Thread-Index: AQHZeS7KcXyJMam5/02OfvR6IA/q+K9AQwAw
Date:   Fri, 28 Apr 2023 06:29:13 +0000
Message-ID: <BN9PR11MB5276DC8D4CE6751954C9501E8C6B9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <cover.1682615447.git.reinette.chatre@intel.com>
 <5add301d11d4a566c29c487a78b4227ae383f11d.1682615447.git.reinette.chatre@intel.com>
In-Reply-To: <5add301d11d4a566c29c487a78b4227ae383f11d.1682615447.git.reinette.chatre@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BTM4jKWZxu8GM7+ytFgh7JoSE2SXn2V9lZt7CldGP6TpMXbw1/iBhO5OGcL4?=
 =?us-ascii?Q?mWSstcx+YoYN/kAbqA7Zc/fb/VfuBas5qdOQn1EPHUq4arK/kO0xeN7LxX+H?=
 =?us-ascii?Q?iMaQd8Hzycbb61pVnEVKzqEe/zGctpwIBLD409muG7FUii+eqqq+y71nA4Fl?=
 =?us-ascii?Q?WFnoT6IiowsQ1rwggY+M9lZ/HA1UKXG7uJIL+5OFDH87b6jCRI7KOMdFn+UV?=
 =?us-ascii?Q?detuMyUnEoIJFCSvTlfrPddTq9h8Z5bTN4n/w5V9q9pxKXMYK8LCstNINF/h?=
 =?us-ascii?Q?10WeUcxegMReqqVL+2ezYxSBy5EQuQxNMIEVeDvbFGQ/nN5MazLj0RLtseld?=
 =?us-ascii?Q?lGU0c/Nvqp9gDIBE1mlu/stY8tiwmBXxs8SEq75o7haN0ha1YMg//I6SZjvy?=
 =?us-ascii?Q?W9AHf/2EcHinhKZahq7XlJjfTjdVP0n1TIQTvHI/U5fGkjCoFwavJeL1wGaB?=
 =?us-ascii?Q?QpRYsenPwSFPlIG03yuwQK8Am3rqlRtsg6GSWiFRKamGnQG8UnOCVt+Kpzrw?=
 =?us-ascii?Q?kN75iYnjW/lU2kkpLUJM+5ZTV6LRErCrRe9jB+LCBkcHQAFj8hR1pgQfkJaX?=
 =?us-ascii?Q?8WDJ5iZxKJooKtkTtxmUUjgNkzBe+XoV96DhK4UsTcxFFh8jVhm+aM13T5MC?=
 =?us-ascii?Q?6coadXpnuA6rJRoRhH90QFRntVjwJTh82Y1EbzjMa2HcjQdoOb7KI5wUIgSL?=
 =?us-ascii?Q?rB1aJmx7CfyEWZoqoh+AnVwe3+UweRLjocLqKHgcDMeZkhmVug67D/v3E/lD?=
 =?us-ascii?Q?6CTKBnfYShOSzGVxGLTrCjbRmQ7uwdN7CRZ11kMvjWBQPF1tPfxQcsPM6ke/?=
 =?us-ascii?Q?2cB0HrgllqwSeQVlhf+2bxzGqWDolfyuploR3mwbE3UllPjaQNzPEvTC+sXO?=
 =?us-ascii?Q?Q27K1jcFBH1sWpAdCrhV5KFgda2tWOlu9/jlIlGNYKED8lUmcaOmDgoDQOl+?=
 =?us-ascii?Q?z5YNZRGWqSgqLhQZ6QNQH32Pw/6bHZ8npUBMXVncCf/U1OLbZpCYadrxDOyl?=
 =?us-ascii?Q?kdJe8ucI33Fi/cO5o4uMt1uXrMx5mlwbcIDfs0KltpPaq1W35vi8GGkT0v56?=
 =?us-ascii?Q?/lo4ntVezthgRxzGywUvW1hNyAO8JktiBbnJi4D7kdh75MEUPyymdFdcRO9L?=
 =?us-ascii?Q?ERBN3Bp7lwiw7tuAnYL2jXs+HirCCZPkWzvb6eKFakgZChQjP4hQlPQB88Pc?=
 =?us-ascii?Q?Z5o+IsWdxTHsabn790sSrMDLB3UKRrxyhO2NHtPPGuChhAWh/qJDCnLS9nIG?=
 =?us-ascii?Q?Aegf2hV1BJku40uk5zjGq05/lfTaVUe7b/7KRSa6Prz42GXv1VjxyTewIWaD?=
 =?us-ascii?Q?QvzTP+rViL1VQB2kotl2soZywM55ldoARpyNJjA8WY3Gij1wMSI0h8YSgMSm?=
 =?us-ascii?Q?flIkGY2Y/3nKZF4Y8JqOWnZwpFxNAjbhC0SbxTc7EjHtKdzfHhbC9f3eu/Bn?=
 =?us-ascii?Q?n2DYJfxgqEUYXjy49e2gTGjz9jRoCt7ZGyS62oogLsOwPboZz3PUy4u3cjhS?=
 =?us-ascii?Q?qvLulJCBi1GkeeZrxI0lrOXkR5t7TAaHP6eD1deJ+BZ+jseC7MPqXYJZXVzi?=
 =?us-ascii?Q?+OkjhHQRiO36oxJlQgE68v7p52aiQcsLq24PKIYa?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a63e1051-7e8a-4db9-a1d2-08db47b1e299
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2023 06:29:13.9322
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dbk8Fs7ypvvkor3S8FYDHx6SszJLKZVNSDaKI8lzyZkLK6sfkHNKKQJmyRiFgUsnj2l1UsJKiBBbak68VKWZdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5581
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Chatre, Reinette <reinette.chatre@intel.com>
> Sent: Friday, April 28, 2023 1:36 AM
>=20
> User space provides the vector as an unsigned int that is checked
> early for validity (vfio_set_irqs_validate_and_prepare()).
>=20
> A later negative check of the provided vector is not necessary.
>=20
> Remove the negative check and ensure the type used
> for the vector is consistent as an unsigned int.
>=20
> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>