Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Chatre, Reinette" <reinette.chatre@intel.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "yishaih@nvidia.com" <yishaih@nvidia.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>
CC:     "tglx@linutronix.de" <tglx@linutronix.de>,
        "darwi@linutronix.de" <darwi@linutronix.de>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Liu, Jing2" <jing2.liu@intel.com>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "tom.zanussi@linux.intel.com" <tom.zanussi@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V4 05/11] vfio/pci: Use xarray for interrupt context
 storage
Thread-Topic: [PATCH V4 05/11] vfio/pci: Use xarray for interrupt context
 storage
Thread-Index: AQHZeS7LwVOBrXfz6ECqvY6p4pG9Mq9ARM7A
Date:   Fri, 28 Apr 2023 06:35:29 +0000
Message-ID: <BN9PR11MB5276870C3A3CBE601A68838B8C6B9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <cover.1682615447.git.reinette.chatre@intel.com>
 <78182c9cd770885b6d354f114ba157c7024c8b39.1682615447.git.reinette.chatre@intel.com>
In-Reply-To: <78182c9cd770885b6d354f114ba157c7024c8b39.1682615447.git.reinette.chatre@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FCIOCbsTxNILXcYBxNEHamFjf9iV52F5ibZQ9oKbHxHHK+RDglhKn53EaTEt?=
 =?us-ascii?Q?Gv3jr43JXaxpZuUoqLk8X+smrinGgChfCyP/MvaEX6kS1kUi4h+VHBbQIILV?=
 =?us-ascii?Q?bDV2P6pkPJu3i20CsPJdpykVFgewMFpmgN6LAFA4NZA7S+ezTwt/H/w7p4Sx?=
 =?us-ascii?Q?X/a6stW74hID2xMNMLmhlGwXt6Evy/+wtynIzZ5hRl8SwU04M+8Gk25qniXn?=
 =?us-ascii?Q?uqjy6tCFxWSa2BYjqzU8xyk7/v6Qxt/Btu0+MjW25fhEpInuI+MRxqN6Ez8m?=
 =?us-ascii?Q?X1Svm41W4GbD9SeCvM5ntFqNUT5mpH9NEagugk0YHUbebAHl0RYZpe5trlBX?=
 =?us-ascii?Q?4nsgE1NvsNUN4yrtavpamyjyrDHKyfXcOkRGA2bJJZHrqavLb8kz9Q3idmAy?=
 =?us-ascii?Q?eoVqqFNjPFHdZ+oni7S/rRM3ol3Mbls5+lQMHagJYk+ob7/2aGIRtoKoZtlB?=
 =?us-ascii?Q?oNbgugKNhUt1AHVLaHr/z1QUZG9srcOaK8VPr/e2b0MG+aZ7JXGxG/v8+t4n?=
 =?us-ascii?Q?YPEzUaVk3bXsUHGsbnZS8hsZnqbDYpTaA1w2pxYz0P1W5jY36hCTBYB3aL5B?=
 =?us-ascii?Q?P6BlYoa7m0kdJf7mEadpw/r2URVnWVfdyylr361l/a8KnGeAyjUgMglWQkhz?=
 =?us-ascii?Q?SVJIZ7d74xj/MNUGmfEheRC9cQQufFtCwTg/tXSuI5pPUNLpYu5mcVOX6d6I?=
 =?us-ascii?Q?4F1T0D9oSNbMRhiXzXuPFaob1AVFZAhJxnQ+flNrew/Y6JUDFjslGzY4zo6U?=
 =?us-ascii?Q?Y2QzE89p1OyLJuSZyg5GxAvj3QJMICn1Uj6TEak5nFKY0tf/4G0kIUManphB?=
 =?us-ascii?Q?vfXD6mFLVNYlTN033KpN75Q2zq2awtPHvdHkPTwmjl40wfSjZc5KWhkvBZi6?=
 =?us-ascii?Q?zNPIxo1FvBgnzsuRyXq3qZ0lXOuUzghq/Yv4vdl3Htrrsj4n++M3snVMZpZG?=
 =?us-ascii?Q?CxEymJjgZzo3VBzUjT6CSHaC1utqn4HV5iDydELnv5b/PUS1KekCJMA5nnbv?=
 =?us-ascii?Q?FD1Til3jSS41IebmnOYgM81SywzA2SFmy8mjMytOZEkpz1vCePPqjEUsAiuC?=
 =?us-ascii?Q?e7G8VyDjUA/tY62nxlLaO1nynMnAnDadhXhvI1LbSHGW/3OM9fLC4VbTaGdj?=
 =?us-ascii?Q?yKrhA2Q3yxfJEFCmygt57LsrqueVl+GnmdUeNNwvxGdJgoUt+3ms9xjr1d6G?=
 =?us-ascii?Q?W+PUm+8I4H2s+J97W9tgorKz3GTIiNBETGmhvd7EsRhgyfxAKYx7fRureur4?=
 =?us-ascii?Q?8pLYUy7226zORVEebG45l1F3nqXn1zQnWtS7tE6rT7+MoOGC13Txizu3IEOM?=
 =?us-ascii?Q?9kLZGlAbhKATfjwpy8UbB/wrTqTgjRt+YYcsZ+bNn6UEFuyIV56vF/77tk7p?=
 =?us-ascii?Q?KOA+eG97DqDlucyilSjzi2Qxif9pNGFFwl9WLvYCenUlOxSKK9+7WkNZtXVY?=
 =?us-ascii?Q?ei3mUR6AO7sxkBLF9bWC7eb8wDBufJG15vVaa7zEreWIPcb9mz1UMDRMRaAs?=
 =?us-ascii?Q?DQ+de20Za84EJOdpB10pzm5YnjzVIlleN0hhzY2AaNCVPrr96XQW6V7Yz/dZ?=
 =?us-ascii?Q?EfGTM82tnq3VHOq+dKfDgfkuMSStYoWyJOCVWvmw?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 58bef5b6-3184-4841-f21f-08db47b2c2b0
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2023 06:35:29.8795
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NffMaFqDwNcsXm9CW6qNohzhAhaPxtkBNhXcNNZfKazFxwlqdvIHd0dGzEDYusAxrlpP5CA0Ywexiw5SRX/Y7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8376
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Chatre, Reinette <reinette.chatre@intel.com>
> Sent: Friday, April 28, 2023 1:36 AM
>=20
> Interrupt context is statically allocated at the time interrupts
> are allocated. Following allocation, the context is managed by
> directly accessing the elements of the array using the vector
> as index. The storage is released when interrupts are disabled.
>=20
> It is possible to dynamically allocate a single MSI-X interrupt
> after MSI-X is enabled. A dynamic storage for interrupt context
> is needed to support this. Replace the interrupt context array with an
> xarray (similar to what the core uses as store for MSI descriptors)
> that can support the dynamic expansion while maintaining the
> custom that uses the vector as index.
>=20
> With a dynamic storage it is no longer required to pre-allocate
> interrupt contexts at the time the interrupts are allocated.
> MSI and MSI-X interrupt contexts are only used when interrupts are
> enabled. Their allocation can thus be delayed until interrupt enabling.
> Only enabled interrupts will have associated interrupt contexts.
> Whether an interrupt has been allocated (a Linux irq number exists
> for it) becomes the criteria for whether an interrupt can be enabled.
>=20
> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>