Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Chatre, Reinette" <reinette.chatre@intel.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "yishaih@nvidia.com" <yishaih@nvidia.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>
CC:     "tglx@linutronix.de" <tglx@linutronix.de>,
        "darwi@linutronix.de" <darwi@linutronix.de>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Liu, Jing2" <jing2.liu@intel.com>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "tom.zanussi@linux.intel.com" <tom.zanussi@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V4 06/11] vfio/pci: Remove interrupt context counter
Thread-Topic: [PATCH V4 06/11] vfio/pci: Remove interrupt context counter
Thread-Index: AQHZeS7KkA78xvgKNEebs8CfOLWYCK9ARPug
Date:   Fri, 28 Apr 2023 06:36:03 +0000
Message-ID: <BN9PR11MB52761C5DBE9A609797A427A78C6B9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <cover.1682615447.git.reinette.chatre@intel.com>
 <056fbd6c7c5161fb912d60b3f75e379ab3255d75.1682615447.git.reinette.chatre@intel.com>
In-Reply-To: <056fbd6c7c5161fb912d60b3f75e379ab3255d75.1682615447.git.reinette.chatre@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6ESGLY0NdAfSlelCUZGA9F4c2nmFGQxid5m5XHwb7AVGqivwu3IF5Aw0M/et?=
 =?us-ascii?Q?8tdP0TmJCocYRPyfu71jnEedJ3REIlHWgmtE20alc+ZVijI9tnhqtA5NiQqs?=
 =?us-ascii?Q?FZDFgFVjjFmkI7M/9tPjqBvapyk1Z630DV7eM6wIBSlDKGfVBuVECLWkcPmI?=
 =?us-ascii?Q?idx/LCA8l62IemM/Eqa4n41SrEOf4l632Mxzqml0C5o14OW8pZh3uuHgtn0y?=
 =?us-ascii?Q?KSQE3PEVaTeGQfOeMsy+eP4Of55Z93YrQxXlBLmgMw3YKTEU8RT1IfNMrJ9/?=
 =?us-ascii?Q?wsRhj9xE89qcduIFHf6FIyrtDOd0PzT11SE90ViiGs1eW5JaUT4NS/gLXU2m?=
 =?us-ascii?Q?7ia0MuUy+exj7YDP0ghf+iL2z2IFiTGQd3JCFmmqtj+C5oHUXpwxbtlvMUzs?=
 =?us-ascii?Q?u/uvgzYY4UGfZ6fIiHKdAgqdjmZuc2SeZZgSuz5UTLqH4aT49WsEZKDautXR?=
 =?us-ascii?Q?ELzzp0AkHxrBXJT64oBTsiBC1kNi/F03vCdXH07t+p+dU6xvXIVW/hRcEg/0?=
 =?us-ascii?Q?wBY8PeMh2wjH/oKNy+PpbBq/i/pOBFatQABfuQLkf6btAWIxDA/Ke1/hhrQl?=
 =?us-ascii?Q?ag80bpckdAuePOrEwzmz9yYOyfzbSQRTKslBtskDbt65h6BSw0PJDFNhi60l?=
 =?us-ascii?Q?1lhTPFbe1mHGBdvrM2vmA/7PTwntd887UY3IOmcY89MFK8aY1swCuQFbh2xw?=
 =?us-ascii?Q?xV8/PkS1hkrqb0MQwepJhas2ZCl68mNpCR1SzT3nh/qNIF3uKgkFml23hxLX?=
 =?us-ascii?Q?A/WCysGd/LKeFmOWgbJgeaQBQmGqiZPoYHCqqWg8/hLFvvtBniADGShjg4q0?=
 =?us-ascii?Q?N8DdhnSNfg5UR2VNOD1ycWZZTlSkE8PC4IjNT4hKl55RNhJq1Tr9Xn92nyWy?=
 =?us-ascii?Q?oRDXXVzbodQqKhKfQJvEbYVROLvMB/U1tR40CnA5UbDhtcFMcK9c9Eh+1b+6?=
 =?us-ascii?Q?JlxlP7BB4KXr3gIoutEQH5myRwfvVHgbJmaMsnaTeTBLfO9LQ1/SWcBRANoc?=
 =?us-ascii?Q?3Dd1VAE/dpiLfpWBFgxkMDVYp5Nu3ixZXzowGIzoh2d22fH7Lis/sUy6c9lI?=
 =?us-ascii?Q?DB6Q5vTvuVS5UscZW0qdrkgZs+MeapyhrWdpaT/GozXAl+ejWmonJGUPoc7W?=
 =?us-ascii?Q?5xszHkuxkkuv9QAVpU5ty4ei6KFZIRqxLWEAtmRGdOG5YoGKhTlHLcDcPV4K?=
 =?us-ascii?Q?Z6tHJJfP4mDCQgv40axOUBsCd0iJYHCva9AXwpxn0KqSYReVH6JlrZQneTuz?=
 =?us-ascii?Q?6aCWwuELiAR4fFMdCIJNmcRsnem6Z63/8YQG4ufEvP/XF2pxm3+KqRFm0vpe?=
 =?us-ascii?Q?F+1Xf7BFbUKJ5hI4324mIMRjEGRO4BTOxbUF326MKtbrO3eipBXjCnyf7xnu?=
 =?us-ascii?Q?grVv8CAaJrgEZv8fde4CccxCZXHvAZP+DJNh8FrwZqfRSW6c+M8RtQpBsfKH?=
 =?us-ascii?Q?0N69gO36EtsIpTsAWTSNTZLoVdCEUGF3G7v1Uo8bynwJVaO8D6lpFXl8F8UA?=
 =?us-ascii?Q?lI4DD/A7FG9+JZ+7XxV1THDp1zIF3IeDmSrNFJuMgpBaqTSgLcqWxgIIAwaW?=
 =?us-ascii?Q?wIll9d0T0rrMJ998o1RJ6Jxg42vY0xlFaKfc7MkG?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d1371e9-e246-4215-4723-08db47b2d6ed
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2023 06:36:03.8160
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SA9vMdZvZ6prYjXJ+w+DSI2Ti4WkCe3WNAJuNREL2H+bxLBMK5bfL2spvLrjndoj60/M4TybeaUjwgl8FPVNiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8376
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Chatre, Reinette <reinette.chatre@intel.com>
> Sent: Friday, April 28, 2023 1:36 AM
>=20
> struct vfio_pci_core_device::num_ctx counts how many interrupt
> contexts have been allocated. When all interrupt contexts are
> allocated simultaneously num_ctx provides the upper bound of all
> vectors that can be used as indices into the interrupt context
> array.
>=20
> With the upcoming support for dynamic MSI-X the number of
> interrupt contexts does not necessarily span the range of allocated
> interrupts. Consequently, num_ctx is no longer a trusted upper bound
> for valid indices.
>=20
> Stop using num_ctx to determine if a provided vector is valid. Use
> the existence of allocated interrupt.
>=20
> This changes behavior on the error path when user space provides
> an invalid vector range. Behavior changes from early exit without
> any modifications to possible modifications to valid vectors within
> the invalid range. This is acceptable considering that an invalid
> range is not a valid scenario, see link to discussion.
>=20
> The checks that ensure that user space provides a range of vectors
> that is valid for the device are untouched.
>=20
> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>