Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754651AbXJAJjm (ORCPT ); Mon, 1 Oct 2007 05:39:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752125AbXJAJj0 (ORCPT ); Mon, 1 Oct 2007 05:39:26 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:45145 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985AbXJAJjZ (ORCPT ); Mon, 1 Oct 2007 05:39:25 -0400 Date: Mon, 1 Oct 2007 02:39:14 -0700 From: Andrew Morton To: Geert Uytterhoeven Cc: roel <12o3l@tiscali.nl>, lkml Subject: Re: [PATCH] removes array_size duplicates Message-Id: <20071001023914.b6574959.akpm@linux-foundation.org> In-Reply-To: References: <46FC33E1.8010309@tiscali.nl> <20071001022653.40bd5714.akpm@linux-foundation.org> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1340 Lines: 27 On Mon, 1 Oct 2007 11:33:01 +0200 (CEST) Geert Uytterhoeven wrote: > On Mon, 1 Oct 2007, Andrew Morton wrote: > > On Fri, 28 Sep 2007 00:51:13 +0200 roel <12o3l@tiscali.nl> wrote: > > > This patch removes some ARRAY_SIZE macro duplicates. There is also one in > > > arch/um/include/user.h, which isn't fixed here because comments in that file > > > explicitly state a preference for the 'less fancy' version. If that's the > > > case as well for any of the other replacements please comment. > > > > I got a bunch of rejects against various development trees, a > > build error in net/ipv4/ipvs/ip_vs_proto_udp.c and now > > > > net/netfilter/xt_sctp.c: In function 'match_packet': > > net/netfilter/xt_sctp.c:58: error: size of array 'type name' is negative > > net/netfilter/xt_sctp.c:106: error: size of array 'type name' is negative > > However, arch/m68k/amiga/amisound.c: > Acked-by: Geert Uytterhoeven > Well yes. If the change had been split up into separate per-subsystem patches I wouldn't have needed to drop the whole lot. Hint. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/