Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0be60cda-6b8b-5844-c4fe-b711e7279cc7@amd.com>
Date:   Fri, 28 Apr 2023 10:50:36 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2 1/9] drm/docs: Fix usage stats typos
Content-Language: en-US
To:     Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc:     freedreno@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Boris Brezillon <boris.brezillon@collabora.com>,
        Christopher Healy <healych@amazon.com>,
        Emil Velikov <emil.l.velikov@gmail.com>,
        Rob Clark <robdclark@chromium.org>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Jonathan Corbet <corbet@lwn.net>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20230427175340.1280952-1-robdclark@gmail.com>
 <20230427175340.1280952-2-robdclark@gmail.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20230427175340.1280952-2-robdclark@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnFKczNGY0owOEliTTdVQzdwU1AxN2VQZ1l6Rm5Ga2hNcFRuTnR6MXVKUjIz?=
 =?utf-8?B?WWxSRnJUVVB1T01qcVRXSEZTLzR4NytDcStJUlUxakVQR1pQVk4zWWZWTmpm?=
 =?utf-8?B?ZG43dnh4akUrWlVGNS9pSWxBYk00KzZ3Z2h2elRlZG90eDRCQ3A4clNrMzRi?=
 =?utf-8?B?dEdaWFJoVEUxbFhocjlLTDN4VzU5MXd0V0tUbS85c0IwMXJqODdkL3lIT1Jl?=
 =?utf-8?B?VzFTdmxDbE9yTWxKV3c2Nnc3SkRxaS9OYmNpS2J2YlJwR3AvbnAvdHV0RXNL?=
 =?utf-8?B?bGlodjNwVy8wTG5CM2dVS1BXRGRPcm5GRFFOUWY5dEptTmx6SzZBc2x5eHpl?=
 =?utf-8?B?K3U5NkdyNlNrYVNvT09GbUV6aUlWdXgwRHJOKy9YZlZJWHMvTlU1VEI1Rkp3?=
 =?utf-8?B?d0UreTBZWmVXOFVxRUxpbWNRbzFUSWVhUWt2RjhPUGFEUFoxZnd2WG5JWWJL?=
 =?utf-8?B?MGpXdHh0OXZNQUwwL1M1b1ZBWXFqVDBCTDM2RlJqaUN6WDlIRzYxSFEzWVYv?=
 =?utf-8?B?bzkwQ0szVE5rUkpZN05zN3BnalRXcTc4S3kzWkFlVVFZOGp4L1lvS1NWUjRp?=
 =?utf-8?B?Q1RTd2ttWlFsKzRhSnpEWHUzZkZ0dWJuMHNXbzNYS21ISjRqbDBqdldKSWxJ?=
 =?utf-8?B?RmYzL0xkZFBEcTNoYW82OEI3TTBQOHN4VlNLY2xOOStkNEdaNDhkZWJsMk5x?=
 =?utf-8?B?UGR2dVJDcUZrN1p6VnFoeWc5cjB1TmZQbE56SUFqNUY5dFdrYlUxakZsL3Nq?=
 =?utf-8?B?T2FvUjZrcVpCaG9RdlBscy9Ud0VEZk5XUG9GcjlxUFM3Q2k4S3pTZDBzZ1M1?=
 =?utf-8?B?SW9VczlnWXZRcWdCbFoyekZNaWtYQmJGK3BjaitkZ21zM04zbkdXcmlvaGxi?=
 =?utf-8?B?OXFHZm5JamRFQ1hlRWlwT1g3WHFjZVE5RlVCdHhCYXAwWGYvcFRSVC8rTmpV?=
 =?utf-8?B?MlJmc2VuVTFwL1FVcXpJWkcyd0ZPVm5jbzNHS3NGK1BjZEg1d1RHbFJaTUc0?=
 =?utf-8?B?VU5ucmY2VE14dVE3NndFaXZlM1o5SHV4cVh4Z29QcmF1R0V3Yyt6RGw4UzR3?=
 =?utf-8?B?R2ttVllWNVRaYjF4WGtaVGk4bEovR09TZGN1NmxDRVpabldYUHdxalpJMVJ4?=
 =?utf-8?B?UlJOMkw2cVNDWTFuZ0cyODZsQXJTRWk4TmZmUDZwM0V3MWU1bkdybmp3dXJL?=
 =?utf-8?B?WFAwejQ5OTg2TzNoNEhRdnBGZno4aSs4RVlXeFNqcVlPb2FXN2RJdm9ibmZj?=
 =?utf-8?B?cEFXdTBYTG9JR2Y0M2NCRGZISVlPdHVpajRQVmVCVHNIS0lQbEoxU3hwaWla?=
 =?utf-8?B?akhUdGVsMTY5ZTJ2RmxHaVpnNzM2c3FTQ3dsVnNYelp2VlNwaWpRSDlCNHh1?=
 =?utf-8?B?NEoyQzNoOERHNGk0NWdqUS95QjNBYkFkeU1Ta1RCSitZdldFMHVwWDMzNHky?=
 =?utf-8?B?Vk51UWM2OGZuUWN5eWRxdFB3SEZuUHZpUVNJTUFqbkFiNjlpaU84MGlRU1JO?=
 =?utf-8?B?dXh6Q2wyRzRXenJNVDU2ckJraXpSaUwrbG1QMFFiMUxRY2dDZEZZS1F0MVBv?=
 =?utf-8?B?NjZtUHh0ZEpZY3BwSEdQeDhaNEhUUi8zQ2NjK29WTjhQcnYwTUtPMy9FbTJo?=
 =?utf-8?B?anIvbEFQOTFkM0NjRkoyN2p4bkc0RC9NRlpLRStaVGdiNzd2WVIzZnBzL0tE?=
 =?utf-8?B?RHRzL1pZYTMyU1dKTVZpZno3M01NL01uSlIrZFlsUzRvNzRadmlha3Z2TVFI?=
 =?utf-8?B?dWxMamc0d2hZR24rL0E0MnlCUlZqbFNwdENLQ1hvbWVkN2VVTTNwQzdTem1X?=
 =?utf-8?B?SzBSdEZ4bTFyZGo2bmVTQXdKRnN0RkR2ZXo5NzBvaFplcWdnNmdLUU1vOHNU?=
 =?utf-8?B?RUlxTGM5N2UyeFVZYTJCdkVtNXlUdWlkanFNZUl5Z1JCb0ZPS3ZaazZ1RFNn?=
 =?utf-8?B?UVBZRjF5U0pYVU1ZbFF2c3R2S3plMWxUSG5aeG9vOXZBaTd6Tk5ReGhSS0N2?=
 =?utf-8?B?T1NQNjlEUFdNbzI1SnIyV2JaQ0VqTUI3U1p1RTRMSkV1OUNwV242ejFVVkpW?=
 =?utf-8?B?ajhJS1JYS3E0bTJUaTR5N2FCL0ZCRWFBeUxwZTIzMEpxNDRuUXhKdjJ3OG11?=
 =?utf-8?B?M3JWQVlnc2VmQ1p2V3FhTmdCNU56TDRhSG9Vbk8yditHNEJ6RmRxV3FXVXRM?=
 =?utf-8?Q?NfI32KHSDouGapqmLQf71ouVD21RH2TpBdp9+O6h/5aM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e6677d50-c33a-49bf-48d2-08db47c5a67c
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2023 08:50:43.2146
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fISLttXeNXDc6YOrbIj+Fs17VBnNErbadzFj7NHnLs450TO5+BbOQktDDDtQ4WUW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7193
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 27.04.23 um 19:53 schrieb Rob Clark:
> From: Rob Clark <robdclark@chromium.org>
>
> Fix a couple missing ':'s.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

Since this is a pretty clear fix I suggest to get this pushed to reduce 
the number of patches in the set.

Christian.

> ---
>   Documentation/gpu/drm-usage-stats.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/gpu/drm-usage-stats.rst b/Documentation/gpu/drm-usage-stats.rst
> index b46327356e80..72d069e5dacb 100644
> --- a/Documentation/gpu/drm-usage-stats.rst
> +++ b/Documentation/gpu/drm-usage-stats.rst
> @@ -105,7 +105,7 @@ object belong to this client, in the respective memory region.
>   Default unit shall be bytes with optional unit specifiers of 'KiB' or 'MiB'
>   indicating kibi- or mebi-bytes.
>   
> -- drm-cycles-<str> <uint>
> +- drm-cycles-<str>: <uint>
>   
>   Engine identifier string must be the same as the one specified in the
>   drm-engine-<str> tag and shall contain the number of busy cycles for the given
> @@ -117,7 +117,7 @@ larger value within a reasonable period. Upon observing a value lower than what
>   was previously read, userspace is expected to stay with that larger previous
>   value until a monotonic update is seen.
>   
> -- drm-maxfreq-<str> <uint> [Hz|MHz|KHz]
> +- drm-maxfreq-<str>: <uint> [Hz|MHz|KHz]
>   
>   Engine identifier string must be the same as the one specified in the
>   drm-engine-<str> tag and shall contain the maximum frequency for the given