Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jacob Pan <jacob.jun.pan@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        Robin Murphy <robin.murphy@arm.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "vkoul@kernel.org" <vkoul@kernel.org>
CC:     Will Deacon <will@kernel.org>,
        David Woodhouse <dwmw2@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Luck, Tony" <tony.luck@intel.com>,
        "Zanussi, Tom" <tom.zanussi@intel.com>,
        "Ranganathan, Narayan" <narayan.ranganathan@intel.com>
Subject: RE: [PATCH v5 4/7] iommu/vt-d: Factoring out PASID set up helper
 function
Thread-Topic: [PATCH v5 4/7] iommu/vt-d: Factoring out PASID set up helper
 function
Thread-Index: AQHZeTAdQSnrcG3HMkmo3hSxYxRHBq9AekBg
Date:   Fri, 28 Apr 2023 09:47:45 +0000
Message-ID: <BN9PR11MB5276726E67301703BD10833B8C6B9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230427174937.471668-1-jacob.jun.pan@linux.intel.com>
 <20230427174937.471668-5-jacob.jun.pan@linux.intel.com>
In-Reply-To: <20230427174937.471668-5-jacob.jun.pan@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IFF9egeMLhi/1Jt4XjSnuHk2uD1F9KsnhhcgRAkBP2jshK76srL1M/RcNVnt?=
 =?us-ascii?Q?7eCKQhkChqwtQIWXtpFcAkj5CdVh2EmXWt1/yyfOIDJlg1W2o9PIRyMzt8mu?=
 =?us-ascii?Q?zkWbiB3IFaEEogrH1AZuozdmvnYeznyt2WoqiADN2C+pcMBNK2FLSnDnsNey?=
 =?us-ascii?Q?VCZvHEWN55TzpnJLltcVO5Nj3JoFlqs9yS19TkFgYHmp7d3dUQdUEHdTi/lM?=
 =?us-ascii?Q?a4B97w+/QrEGcWpCZIGBg2Mt4qQwVWTv/tll9X/O3x+FBSZkDQ4lvPnaKGiq?=
 =?us-ascii?Q?lh7UaZicq/EsYzAJ4xuD8eCax1ix5RU6f5KIvzdXU6A04amRu/jDNvb474pY?=
 =?us-ascii?Q?BwfoBbBiedTngH7kN3652UxqkLvqgIaqzem8k2hGabgCgZoDR7dtlNEIzzsG?=
 =?us-ascii?Q?aeDGGeqjZW4sJcIFwCUjlfzNi+CXR0z3DwlNDuznh+rLOarU3xTaMWdIcgI2?=
 =?us-ascii?Q?+2NbE+jIuRdFXNhStsNyBZxS15rChnQR9pLxfc3BeReZBBTvpgkAYRsY5Prl?=
 =?us-ascii?Q?MGzmuFv39nh6Qs7E5s1SX3tpZp8imwu/lIMhbSVO2t+fBSvR72HyUFRuFXIf?=
 =?us-ascii?Q?fcPUlkDamsMZfSjGcBeHz2AFYbYkhu/5aXuOFxqYKYuxeNmrabBtPF1NhxuS?=
 =?us-ascii?Q?jmW2Ce+hpE5p/uDNTe47koLNMOiVMScGxjA8GUv32VB3XljEXhjrKGjmNkB2?=
 =?us-ascii?Q?wq2FEimwh7fKogulY9V/+D5xnEqexsnlF6XGvDEZXjNz/NVPIpxTu1jne6Bk?=
 =?us-ascii?Q?5DfQvcd6DF7zJ0Of7xzHzqj3x8qntUoTeceQCcgcfTPTilA0ceC3jKSl0o2d?=
 =?us-ascii?Q?0HiCh2+ob63IA7C07CkydtYlQoXIsAPmLUrYgONBDV7HqL3KHoAq1OD3jxFg?=
 =?us-ascii?Q?ivHiyrDbLaJWOrGlu/BgRp5scFGYzv4ntqWrvdyY9JnHoEeI3C1/ouiTOfd+?=
 =?us-ascii?Q?mlpNueRepHWa7pA77K9M9uNlc7Yn84qipXIiMD104dd9JJbASf4QYqoVBApW?=
 =?us-ascii?Q?NkOrS6obK6Jkos5fbuJQxenovU2bfn0b7Tlm2bhY2sdwe7kaoG+4Ntwj8sTL?=
 =?us-ascii?Q?ThDCMYwkxlStIBWCQKKje6xiFzZX74sTODfyrb4ATKyORsJyqgsPHHiEAOu8?=
 =?us-ascii?Q?kHNnpXACDi+ZsYK4gLceV2LiJrFn8Qk4dRO7WYgvpGEK7syBsuLfS9QpQjT+?=
 =?us-ascii?Q?wd/2FoKJ87PcD94nz2iKczswN1jParQelK/XJCFCmNVxh8bcFbAexuvVDC5x?=
 =?us-ascii?Q?yhHzsiAnHT9Ttqbb3fWCARwEiqjcuyHkOVXANF2r7oMfwnrjMwbLdBvDEa/0?=
 =?us-ascii?Q?4wspQKOkilHM71buYNvv0kXrJylp/elCkb5rzPvkN0hAcfBO+u4TbHIWS+OH?=
 =?us-ascii?Q?GGHiOhpYYTZpUtO1fg91sbK/ds19/nO9RKpClW9/kHQA8jt/wmhNJjp9+1u8?=
 =?us-ascii?Q?gqZLynAInac0SOa4n4fMip4kMwEzQIlFtRSDLWjU8J/X9k/FQNEadQSOoBhy?=
 =?us-ascii?Q?kHFA7ETO65yjZQNHOH1ss3JivC7VQSIKzwRBAfSUmeg0JaUJstupJXEImIwn?=
 =?us-ascii?Q?fdQORscI2re2MuJxn6UN9ISHrq1Ylg8LFwJ/L5tY?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b0ca26fd-63c4-4971-143a-08db47cd9e86
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2023 09:47:45.6003
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TVo9LOYy80UgAB9yNZIL20lZgLE777jkBKPns0dqIe2yK6wyFtQRbEEmbeLJLM4WD01c8vF85y0aVCHZMX+sYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7018
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Sent: Friday, April 28, 2023 1:50 AM
>=20
>=20
> +static int dmar_domain_attach_device_pasid(struct dmar_domain *domain,
> +					   struct intel_iommu *iommu,
> +					   struct device *dev, ioasid_t pasid)
> +{
> +	int ret;
> +
> +	/* PASID table is mandatory for a PCI device in scalable mode. */
> +	if (!sm_supported(iommu) && dev_is_real_dma_subdevice(dev))
> +		return -EOPNOTSUPP;

"&&" should be "||"