Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <951f0163-4b84-d12c-9c9a-8102abb51cfd@ti.com>
Date:   Fri, 28 Apr 2023 15:32:19 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH -next] soc: ti: smartreflex: Use
 devm_platform_ioremap_resource()
Content-Language: en-US
To:     Yang Li <yang.lee@linux.alibaba.com>, <nm@ti.com>
CC:     <ssantosh@kernel.org>, <linux-pm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
References: <20230428062825.126448-1-yang.lee@linux.alibaba.com>
From:   Dhruva Gole <d-gole@ti.com>
In-Reply-To: <20230428062825.126448-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 28/04/23 11:58, Yang Li wrote:
> Convert platform_get_resource(),devm_ioremap_resource() to a single
> call to devm_platform_ioremap_resource(), as this is exactly what this
> function does.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>   drivers/soc/ti/smartreflex.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c
> index da7898239a46..62b2f1464e46 100644
> --- a/drivers/soc/ti/smartreflex.c
> +++ b/drivers/soc/ti/smartreflex.c
> @@ -815,7 +815,6 @@ static int omap_sr_probe(struct platform_device *pdev)
>   {
>   	struct omap_sr *sr_info;
>   	struct omap_sr_data *pdata = pdev->dev.platform_data;
> -	struct resource *mem;
>   	struct dentry *nvalue_dir;
>   	int i, ret = 0;
>   
> @@ -835,8 +834,7 @@ static int omap_sr_probe(struct platform_device *pdev)
>   		return -EINVAL;
>   	}
>   
> -	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	sr_info->base = devm_ioremap_resource(&pdev->dev, mem);
> +	sr_info->base = devm_platform_ioremap_resource(pdev, 0);


Reviewed-by: Dhruva Gole <d-gole@ti.com>

>   	if (IS_ERR(sr_info->base))
>   		return PTR_ERR(sr_info->base);
>   

-- 
Thanks and Regards,
Dhruva Gole