Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bd4554f1910ba253d7833bae99d7c00b9098eae2.camel@maquefel.me>
Subject: Re: [PATCH 29/43] rtc: m48t86: add DT support for m48t86
From:   Nikita Shubin <nikita.shubin@maquefel.me>
To:     andy.shevchenko@gmail.com
Cc:     Arnd Bergmann <arnd@kernel.org>, Linus Walleij <linusw@kernel.org>,
        Alexander Sverdlin <alexander.sverdlin@gmail.com>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Fri, 28 Apr 2023 17:31:01 +0300
In-Reply-To: <ZEkozMAM674O2r7e@surfacebook>
References: <20230424123522.18302-1-nikita.shubin@maquefel.me>
         <20230424123522.18302-30-nikita.shubin@maquefel.me>
         <ZEkozMAM674O2r7e@surfacebook>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-04-26 at 16:36 +0300, andy.shevchenko@gmail.com wrote:
> Mon, Apr 24, 2023 at 03:34:45PM +0300, Nikita Shubin kirjoitti:
> > - get regs from device tree
>=20
> ...
>=20
> > +#include <linux/of.h>
>=20
> mod_devicetable.h and drop ugly ifdeffery along with of_match_ptr().
>=20
> ...
>=20
> > +static const struct of_device_id m48t86_rtc_of_ids[] =3D {
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0{ .compatible =3D "dallas,rt=
c-m48t86" },
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0{ /* end of table */ },
>=20
> No comma for the terminator entry
>=20
> > +};
>=20

Thanks you for all your comments and effort!

All will be fixed conforming your comments.