Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1975002rwr; Fri, 28 Apr 2023 04:38:09 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ70cEKWYfS5riY0DwczC3Qb8IGwdrYj2qZ0OkvpwWb99eEV1lb0rQLZCEOBfVZyaDv3s/75 X-Received: by 2002:a05:6a00:2d1b:b0:63b:854c:e0f6 with SMTP id fa27-20020a056a002d1b00b0063b854ce0f6mr7790209pfb.21.1682681889230; Fri, 28 Apr 2023 04:38:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682681889; cv=none; d=google.com; s=arc-20160816; b=szwmEQXFWAjJ3/sNfVU+ovyAgpZ4BnxSnFMDjIIHm3JgtsxcU/JoqutuEWcyZywb+s yrEhOX2YIAw1IPR0WA2guE+brHvyl7YoNXeDMlnLzlMAXD2BpfNF+3dHjkWQR1RLYopF g6KxjYysN2XVpv/yml+7mufHG6cT9zIJQVVB/mMlwxCT8t7yr2NSqkdiJogCFKqe3xd5 P3QiZyAF8O1I5Cik2LN5d6/rbXan/D/cCCupz75CZx7em/aGAtN74NSDxFgnRp0hqjUc yB38ftc9/c7oenTYBtoIWCavzsYK8PTpkzvtkQe0118FvTbnrl3MrWMuTRqLclyIDLYZ JIMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0kSWpQkRsDZ+pmfGKO8UDJNIyW0xzM6cUGxy1UTf/UE=; b=gsHYPbF6I62U24rQrHba6PdTYYUQ0IPlbmnS+DefudTnyD+EJbKCGsIDo7LmWdkUiA yoYzpgkXJhFuWL69ljHpPSOkVLKRXQqWfLo/2KefgFsISC9rm754dgSTfLyiGccGS+fO pAEUgIVnBH7b8hVnlIDjH6/OmkYVkTfGYClAHVTqjpumE7qK5nKom4WNqaqd2UFzgRi9 LJmivQ4t17Y0bnyexP8xq5OoBGKaPb9OzyfRaILfhAZVeohHU5+GkEqzsO+GvXVw2whp NCT5yryrO1g0NdjliAhJomxmj4tS1ELi7kSP8n11J1TU1Wz+2HE6wULAhCFUFLNs/EBJ a4Zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="QAcXMR/q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i23-20020a63d457000000b00513dd391d42si21405937pgj.657.2023.04.28.04.37.52; Fri, 28 Apr 2023 04:38:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="QAcXMR/q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345900AbjD1Lfz (ORCPT + 99 others); Fri, 28 Apr 2023 07:35:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345678AbjD1Lfw (ORCPT ); Fri, 28 Apr 2023 07:35:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31A015FCF for ; Fri, 28 Apr 2023 04:35:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BAF5964322 for ; Fri, 28 Apr 2023 11:35:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CD70C433EF; Fri, 28 Apr 2023 11:35:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682681747; bh=0kSWpQkRsDZ+pmfGKO8UDJNIyW0xzM6cUGxy1UTf/UE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QAcXMR/q4XLqtV0fkBIySl1ru/GJkwrtzw4GW2S9pIS6Bqvv27nt9NID1OxrlE8bU g/3BuXHCpK/hN1GcyARadoEJLPTFKtWnWnWLaTVoM3+vF9aQa0knHiSQJ+6BmQyCV6 Qwehlyko9119eGJ7s7JgvbywrflVBTm333KZfTThH0Hnxtl6YBwz2+RV/oBB5WHoMS 1fLelL5rYW7HG2SKRuSQiHb2e1I7xpiT/Ay84VyheHCYfd6f2FGOBoSLv1nSOFMjRe IWu5pVYjKSQpejtvsqYL2Yuj3DyecPl7LfQoYDucWaeKWdV5htFbzKZITTBV1LxeF4 qLPdG2TKe6MLg== Date: Fri, 28 Apr 2023 12:35:41 +0100 From: Mark Brown To: Matti Vaittinen Cc: Matti Vaittinen , Greg Kroah-Hartman , "Rafael J. Wysocki" , Geert Uytterhoeven , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] regmap: force update_bits() to write to HW when reg is volatile Message-ID: <14d81f72-ab34-4405-b826-b52636d2be18@sirena.org.uk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AfGEgsfhV+xzX2KV" Content-Disposition: inline In-Reply-To: X-Cookie: Love means nothing to a tennis player. X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --AfGEgsfhV+xzX2KV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 28, 2023 at 08:44:06AM +0300, Matti Vaittinen wrote: > In many cases the volatile registers are expected to be written to > regardless of the existing value (because, the value of a volatile > register can't be trusted to stay the same during RMW cycle). In fact, it > is questionable if the volatile registers and regmap_update_bits() > conceptually make sense without device specific map->reg_update_bits. I think you're looking for regmap_write_bits() here. --AfGEgsfhV+xzX2KV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRLr40ACgkQJNaLcl1U h9BxAQf/aWO4/AAtXLmJLtlvlqGPN00e6gJ8qqJEwtN3JzA37KJf84dw01nFog6U lotf6fxdrmGzJwUXSOTAwPseJsvh6PZoQFqCTrUzFJ3xFKT6fjrvlmjTz34dnviR 39Rj7p9vetv3/mtg3L1u1i12YTpIcgQg/XdwUDfQcsBLd8HfTbA0cVlc17Rb0O3s 612M4zM+r895LFgBKxuX60DJGYES8Fqa5ErJEUNdDOMdUrR5J1Vdut/jim+Hukuu iHtDN2JExZNgoVNEycb5vHVI6FSj1gAUtgwHiNdI1DQDOB1LetXN61PgAeTMnnxK SjfV1gZxfhwfs1Q3Ubp7KQWhjvHqBw== =kQgC -----END PGP SIGNATURE----- --AfGEgsfhV+xzX2KV--