Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d1b7f24604332cf6010f533898f96eb9be4bb686.camel@maquefel.me>
Subject: Re: [PATCH 07/43] dt-bindings: rtc: add DT bindings for Cirrus
 EP93xx
From:   Nikita Shubin <nikita.shubin@maquefel.me>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Arnd Bergmann <arnd@kernel.org>, Linus Walleij <linusw@kernel.org>,
        Alexander Sverdlin <alexander.sverdlin@gmail.com>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Rob Herring <robh+dt@kernel.org>,
        Hartley Sweeten <hsweeten@visionengravers.com>,
        linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Fri, 28 Apr 2023 17:35:38 +0300
In-Reply-To: <9e7583be-ad4a-0ccc-08f6-cdf3fa4ed6bd@linaro.org>
References: <20230424123522.18302-1-nikita.shubin@maquefel.me>
         <20230424123522.18302-8-nikita.shubin@maquefel.me>
         <9e7583be-ad4a-0ccc-08f6-cdf3fa4ed6bd@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-04-25 at 11:28 +0200, Krzysztof Kozlowski wrote:
> On 24/04/2023 14:34, Nikita Shubin wrote:
> > This adds device tree bindings for the Cirrus Logic EP93xx
> > RTC block used in these SoCs.
>=20
> Thank you for your patch. There is something to discuss/improve.
>=20
> >=20
> > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> > ---
> > =C2=A0.../bindings/rtc/cirrus,ep93xx-rtc.yaml=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 | 32
> > +++++++++++++++++++
> > =C2=A01 file changed, 32 insertions(+)
> > =C2=A0create mode 100644
> > Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml
> >=20
> > diff --git a/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-
> > rtc.yaml b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-
> > rtc.yaml
> > new file mode 100644
> > index 000000000000..d4774e984e7b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml
> > @@ -0,0 +1,32 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/rtc/cirrus,ep93xx-rtc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Cirrus EP93xx Real Time Clock controller
> > +
> > +maintainers:
> > +=C2=A0 - Hartley Sweeten <hsweeten@visionengravers.com>
> > +=C2=A0 - Alexander Sverdlin <alexander.sverdlin@gmail.com>
> > +
> > +properties:
> > +=C2=A0 compatible:
> > +=C2=A0=C2=A0=C2=A0 const: cirrus,ep9301-rtc
>=20
> Why only one compatible? What about ep9307 and ep9312? The same
> question
> for your previous patch - timer.
>=20
> Anyway, if you want to keep it like that, then filename should match
> compatible. Or merge it into trivial-rtc like Alexandre suggested.

I think i should move it to trivial-rtc - there is no need for a
separate file.


>=20
> Best regards,
> Krzysztof
>=20