Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Apr 2023 14:21:38 +0100
From:   Mark Brown <broonie@kernel.org>
To:     "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
Cc:     Matti Vaittinen <mazziesaccount@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] regmap: force update_bits() to write to HW when reg
 is volatile
Message-ID: <643e5dd9-2d1f-4cc7-90e0-22e4a07ecd0f@sirena.org.uk>
References: <ZEtdJtlbmDCvZuAc@fedora>
 <14d81f72-ab34-4405-b826-b52636d2be18@sirena.org.uk>
 <f7cf3e43-c7bc-67ac-e9ea-e7a79bcd8a88@fi.rohmeurope.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="oUyKV2P2dbUNSfFT"
Content-Disposition: inline
In-Reply-To: <f7cf3e43-c7bc-67ac-e9ea-e7a79bcd8a88@fi.rohmeurope.com>
Precedence: bulk


--oUyKV2P2dbUNSfFT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 28, 2023 at 12:36:51PM +0000, Vaittinen, Matti wrote:
> On 4/28/23 14:35, Mark Brown wrote:

> > I think you're looking for regmap_write_bits() here.

> Yes. Thanks for pointing this out to me. This is the functionality I=20
> searched for.

> However, my question really was if the regmap_update_bits() (and=20
> regmap_set_bits() / regmap_clear_bits()) should automatically work as=20
> regmap_write_bits() for volatile registers. I'll take your answer as=20
> "no" - and try to remember just use regmap_write_bits() with volatile=20
> registers which may require forcing writing the value even when it is=20
> not changed. Thanks!

Yeah, like you said in your commit there are cases where suppressing the
write is still useful - you might have some bits that are volatile and
some not or you might have something like a pattern where the hardware
can set bits and the host writes 1 to clear.  One common thing is to
have read only status bits mixed in with normal read/write bits.

--oUyKV2P2dbUNSfFT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRLyGEACgkQJNaLcl1U
h9Bp/Qf+IDBE36zg5rBz2IDiKeS7ijBclPnbrQS6TDlvzo6NRrFygfLZohEN2sTi
JPAAkuuoabV8yHOFEXtk6ZOyEDxXh3UnwQAqLIzoB4bOZqvMk9Tl9/JhvvK5CLlQ
Xapaubzl4upWZi0lf9YcMvJhiAVHfe0tu/dhvhEmzfVN4l8WHFzkmNxBin2czHeB
p6eB9YE5lPK3o+dCl+OLZdBQgFpaakVUH2ma3b5goJsBHU+o9PAOfohijXr9xtgM
ezuYHCInr5RCYYd8O2aTURsamF4nfFvp5ICBGnt3XQAcp26c8dQzYtdPMev9aHAu
b5sLxISvM0awavRsORc8H7ZbTH//0Q==
=Qjed
-----END PGP SIGNATURE-----

--oUyKV2P2dbUNSfFT--