Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp2114752rwr; Fri, 28 Apr 2023 06:26:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4P2wpCyEc+nsdmf87RW4kU58qIXcjxAuIrdRh13dDkUkj0NUwBko5xrY/PGb1RJ9hygFqJ X-Received: by 2002:a05:6a00:1ac9:b0:641:558:8e2e with SMTP id f9-20020a056a001ac900b0064105588e2emr7653018pfv.15.1682688371989; Fri, 28 Apr 2023 06:26:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682688371; cv=none; d=google.com; s=arc-20160816; b=sxcVNtBthx+e90DtVQeUImQneLuU3VOtxagl7znvtmRqV0wWH5StQwPDkauif5YNci +/3ygEE3uzRj6T429IJ3H3gMm5dER1RwIFLttghnSUfX6ypoyRC8/hIAvdC7MrVbUbE/ SHF9AzimlvBqV/I0QgzqfhPy9O6tetBHOvQuv0a7VE2Ju+shZWYt5oUG4Bkn6YN5Qz9s 0h5AfNUK8bEXiptXCO11YOemIJ4CJlwIIJ5qLue2Wp+H2/5VGfHwozrlKWTJdczXlqNY 0cYS2aziWVnRsIIHToRe3+zwLeR8VEZgzsux1txN6ov7mM5HRed6QzJ2o7C0x182baOt 4tWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :dkim-signature; bh=WHCBk5ekoAeggcfMzSItuZKOWJ2+XlF6kZloOg6sBWI=; b=VcN1SzOo81pJ+qKKlB+xR8JT2WXnkWjHBEXnhoC1WS5ytRsx8RVm/8f/w/EtyFbA6X JCYFlNi4j1NQmNhx2MG63L2Bc3oj3HcGq7crncNu/cjAm+Zg64/Ouwmx72pY1tQKBln8 GGIR0hr0LHewthZ54Mahi3c4YPUmQsKBVlAbypwWrN+URwbORad6CCQlwgiGikW8BlXI 8+/xD9lA+UUeyoKbSilLlaSg8s0EdigbS0XFK0IvqRdLQbogg2X4kC+TNOnu5PRK7yQ1 yew7y2vqzdNBZmpvhFpBBKnvlq0k3V8ddG4q2L79YDbBUjFVyWpLscEcb6IxokCbsQmr 8gdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=ExU31UHi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d16-20020a630e10000000b0050bea56f69asi22545699pgl.735.2023.04.28.06.25.57; Fri, 28 Apr 2023 06:26:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=ExU31UHi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346232AbjD1NYN (ORCPT + 99 others); Fri, 28 Apr 2023 09:24:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346079AbjD1NYL (ORCPT ); Fri, 28 Apr 2023 09:24:11 -0400 Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D48D8173E for ; Fri, 28 Apr 2023 06:24:10 -0700 (PDT) Received: by mail-pf1-x44a.google.com with SMTP id d2e1a72fcca58-64115ef7234so10547720b3a.1 for ; Fri, 28 Apr 2023 06:24:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682688250; x=1685280250; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=WHCBk5ekoAeggcfMzSItuZKOWJ2+XlF6kZloOg6sBWI=; b=ExU31UHiJbjXrqTR/RqtL1j7rtOUfrWye3kSIY+A9bN+qQOyMIen7nZ14d0Cslj/rw 0K0Bqef8k5GwIXCOnaTSAtRwXteDZmLIh3M61j5KjQlBPVJeSd7nlkWo+zsS3dmJYcg1 4kPNtWe5dhSdiycCKhAgpILFExYKaISctW+uSpbiivNtdrGlhP1C28da5SqI+Iiz/NK1 BUf2RYaYobH43+xZz2BSvVquZXldFj1iCvK92+4k6ySBsJwHjva5lbQtAhc1AiBKG1pL LpsLc8MUIU41XiyWbUGY1rpSwpiDqSKC8VLyEJxX3Lg3X0R8kl5GTNZ9vmj9HQs11RGP 83HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682688250; x=1685280250; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WHCBk5ekoAeggcfMzSItuZKOWJ2+XlF6kZloOg6sBWI=; b=bhRnE5PKGsZf+TY3EHry64Vmm6TMtSSK0x9MOJgE7qz+NECT+3Hmaevia70kbV4kYh cWIx5UswZh9nMx3EiC2TvFBbMw6HeyWOEdgqFKeqQRZJMqzEh7z6kkZ9ld4hu0MkQf0i DLwTl2vp6091bfWNQ29tPD2gkmTY42JoJKHO/22D7VFAW3AXCFK1VndWsuvuKUweuHQl x6TkyW1sEgobsNPfPWTk4oWMMhB5nbk45joEBjbVlVqhk57ottsozV/skiAR03c4yOh2 0HJRE7LhaBM5OorRUe2r5HwQbd5zlYJf9daRGrEgX0CqSwk9/WOzT/5NWP0+NhNKJ2MM wpng== X-Gm-Message-State: AC+VfDySut2Ypwl6iHa0SQNsNzMPoui0iooeNLtnih3Nxfs4fzwMnh8m nCp1rma+l7yRvrJ6l+tsMU5eX2tZt2dW/LBt X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:2327]) (user=yosryahmed job=sendgmr) by 2002:a17:902:be05:b0:1a5:112d:f90b with SMTP id r5-20020a170902be0500b001a5112df90bmr1728309pls.1.1682688250374; Fri, 28 Apr 2023 06:24:10 -0700 (PDT) Date: Fri, 28 Apr 2023 13:24:04 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.40.1.495.gc816e09b53d-goog Message-ID: <20230428132406.2540811-1-yosryahmed@google.com> Subject: [PATCH v2 0/2] memcg: OOM log improvements From: Yosry Ahmed To: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Andrew Morton Cc: Muchun Song , Sergey Senozhatsky , Steven Rostedt , Petr Mladek , Chris Li , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yosry Ahmed Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This short patch series brings back some cgroup v1 stats in OOM logs that were unnecessarily changed before. It also makes memcg OOM logs less reliant on printk() internals. The series uses seq_buf_do_printk() which was only recently introduced [1]. It did not land in Linus's tree yet, but ideally it will land this merge window. It lives in linux-next as commit 96928d9032a7 ("seq_buf: Add seq_buf_do_printk() helper"). v1 -> v2: - Collect Ack's and Reviewed-by's on patch 1 (thanks!). - Reworded the commit log for patch 2 after discussions with Michal Hocko. [1]https://lore.kernel.org/lkml/20230415100110.1419872-1-senozhatsky@chromium.org/ Yosry Ahmed (2): memcg: use seq_buf_do_printk() with mem_cgroup_print_oom_meminfo() memcg: dump memory.stat during cgroup OOM for v1 mm/memcontrol.c | 85 ++++++++++++++++++++++++++++--------------------- 1 file changed, 48 insertions(+), 37 deletions(-) -- 2.40.1.495.gc816e09b53d-goog