Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp2367409rwr; Fri, 28 Apr 2023 09:22:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5uFbdbYrZjL9urZwSllwGt/EIxN1UkJfvP6aZsdcB0BBn2BTOmK2G2WpcpMkp+UIECWwog X-Received: by 2002:a05:6a20:9151:b0:ee:a720:c707 with SMTP id x17-20020a056a20915100b000eea720c707mr7908027pzc.18.1682698954239; Fri, 28 Apr 2023 09:22:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682698954; cv=none; d=google.com; s=arc-20160816; b=purKF5AbNwNo37oq2/DCC8U1I+OuExw70glqJKJ6LT4I6ECQJw41gTakh9p0EaKnG3 acQd3YgsQ/PjdkSSiAKR0EP2VzneKbZ9AnhvU/chT4ByvOgg3vSc5Elan1Dq8uGbuZb9 UMnmJ7Nag5rPjQSZRXwGr+4OzNTYRLUNiAOkNWqF7U+PfLi6pUlo8Z4H/Mz1lFfjSsXS LE6mDFmHAaZlZAvSFyR9t/S7yBp/mpw80Gd0WqZZJQNYyb/dP4fBDgw1I6PYeu8Zo3M/ xc0ypB6y1TBqw2GoUTaNWF8wMjrsZR91HNl/m0hEYTEo8lHZ+bgUu6CcrrnZssNMProL /EGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=xvahxQLiQFCmxj/da0CErLJVS9PB2G5zFVCmECHMB00=; b=gbUldVcT34fhOteyRzKmDFxLgtrAs1vLt9fj92z1WzRz8B0IYliEOaaxgkJuicB8wd BHMGOw5+Ud/vfJOOho5bm6YH3Jr/SpIZhoxlWMdhcvbi+LUZD1ji8oLQxhGFWWOZso1g 0eq3+FpTTHN70Ijr96asfXzl/tZipV2hwlvVP1MTScnbYlQCcVujKOLtPd5dUWFZIqta 8W+UpRlI2bS08cFf8H0Fkcn3mTLsu6O8NY7YXlalxWdfwd6XD6KNgueU5qoYcgXZL1Ye uzz+a45rt4u6TX2RtbDopG3EF8N7yNqdGw5Uv8RRpdhcnbvuvXwaUKz1MV0GYyk3DHu+ j62A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DGvkDp8U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y8-20020a655a08000000b0051b5fef546fsi22361437pgs.600.2023.04.28.09.22.19; Fri, 28 Apr 2023 09:22:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DGvkDp8U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230353AbjD1QMV (ORCPT + 99 others); Fri, 28 Apr 2023 12:12:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjD1QMS (ORCPT ); Fri, 28 Apr 2023 12:12:18 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 843E11BC3 for ; Fri, 28 Apr 2023 09:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682698292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xvahxQLiQFCmxj/da0CErLJVS9PB2G5zFVCmECHMB00=; b=DGvkDp8UAKUWvdmFGUOjFjB5Md5vXBR6ipW9JD423ZqAilPZRxgLFdVEbxr41R3rreeLPP QSufe7KGCXVtas9ztJtvCcaTw8kPZ/b6YBKmwOZjygqFd94J27AttyrSQyUDBirf57r4WX kuFkspy0ckkCP9qOjF4EnkLJuWGoAYE= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-Sa6dKrrDNpu61gkan9yHfA-1; Fri, 28 Apr 2023 12:11:31 -0400 X-MC-Unique: Sa6dKrrDNpu61gkan9yHfA-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-54f94262a87so337257b3.3 for ; Fri, 28 Apr 2023 09:11:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682698290; x=1685290290; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xvahxQLiQFCmxj/da0CErLJVS9PB2G5zFVCmECHMB00=; b=gQPJ+vI30mN53VnvHuQjNVB5BzQ4AmcTMdXR4rUZUHxKqhpfC5DQxNU06cdrc97aRm M5PwAcGiMG6tfTEPyFTfBzrq+gAsL7T0oyywBoxQPBh2IddHbjOoWMqnWfKH9iSprlHh JCYGQF0k5b5CoD6CRi/Ja8AMzEcaMSAsKVdvVhA3uiJsOOKeBIBzStceT0J6ydcwHXX4 NnomTc2DzVZm8fLBs0gRGIg3FoZEXTO3teunjax3TRPE+9nBrieeqoBi0nMOgA8rpynb c76SqaHy7HB93e4iXSQmJlbmvxzgmPOIgtpJMcv+QY1De/dVViAfc3vvZyQ/CRiQJjhc 0u6A== X-Gm-Message-State: AC+VfDxjqvQGJgZRTWlH1rgeVDwB9XgwAKNbZNcbmSltFDZ80yq+Iyg6 t6ieEPu0YZNkKQsc59LaDQrdMHGx6DJOABnhepHAxXXsRps8q6z/66e+ZgjV6yQYEYEtihihoFU V+4nKfyr3gfFx6TuwNHgNBpBauOJvxIbo X-Received: by 2002:a0d:e781:0:b0:54f:7971:4f87 with SMTP id q123-20020a0de781000000b0054f79714f87mr4293697ywe.36.1682698290454; Fri, 28 Apr 2023 09:11:30 -0700 (PDT) X-Received: by 2002:a0d:e781:0:b0:54f:7971:4f87 with SMTP id q123-20020a0de781000000b0054f79714f87mr4293686ywe.36.1682698290218; Fri, 28 Apr 2023 09:11:30 -0700 (PDT) Received: from x1 (c-73-214-169-22.hsd1.pa.comcast.net. [73.214.169.22]) by smtp.gmail.com with ESMTPSA id d190-20020a0df4c7000000b0054fcbf35b94sm5497442ywf.87.2023.04.28.09.11.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 09:11:29 -0700 (PDT) Date: Fri, 28 Apr 2023 12:11:27 -0400 From: Brian Masney To: Luca Weiss Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Sebastian Reichel , Andy Gross , Bjorn Andersson , Konrad Dybcio , Brian Masney , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 3/4] Input: pwm-vibra - add support for enable GPIO Message-ID: References: <20230427-hammerhead-vibra-v1-0-e87eeb94da51@z3ntu.xyz> <20230427-hammerhead-vibra-v1-3-e87eeb94da51@z3ntu.xyz> <8250064.NyiUUSuA9g@z3ntu.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8250064.NyiUUSuA9g@z3ntu.xyz> User-Agent: Mutt/2.2.7 (2022-08-07) X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 28, 2023 at 06:06:20PM +0200, Luca Weiss wrote: > On Freitag, 28. April 2023 01:29:27 CEST Brian Masney wrote: > > Take a look at dev_err_probe() to remove the -EPROBE_DEFER check. > > The input subsystem doesn't like dev_err_probe for some reason, you should > quickly find examples of that being rejected on the mailing list (or see > "git grep dev_err_probe drivers/input/") OK, that's fine then. Feel free to include my Reviewed-by. Brian