Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp2386064rwr; Fri, 28 Apr 2023 09:36:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6p2LM6Ymo8iHoIxxFv9XpEtHy20f/6H/T7iRQR07GsdSpKhoGQnuVKxuYCvzvUq1C9SSqE X-Received: by 2002:a05:6a00:240c:b0:63b:4e99:807d with SMTP id z12-20020a056a00240c00b0063b4e99807dmr7701026pfh.8.1682699778358; Fri, 28 Apr 2023 09:36:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682699778; cv=none; d=google.com; s=arc-20160816; b=Rz/MB1nitJh/TYZva8E0FohCXJ2iw8a7+pFwMrxGNigMUh79hblf3dd6XZVeJyHSnG xMj7rDXfkf68SVT279147QmbL+8wKW3M7RntNLv0vF5pIbW2M8TMDEakrGFWgNMKUYiq wFfLS1Dp6bUlH+pf/g/dQuUbeaoGKLqY977/bR4xjJFITFI6HNgyuWQdRYLY9Ihe5oJ4 ZSnFSQBwjc+0xk6VEntuBYcB3e2nDkdx/7nZYlUJtu1Rwm3rAQGKtTR5SNzRA/1XyFA0 q1o0Oa6+NqEl3F0SBoqIIXmocBm+K/MQR+nibZcJE+NIjFnzKK47SpSzL/WtBGEcyXil kQlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=7GlwYkULXBPy4OcdTr53UD+8dz+uvHO/2mc0S4p+P3I=; b=Fe+UrmjHhXeozNGUiq/WGYu/V6TZLrn0Hbv18vc+ZOp+5jxOBQjrc6FZSKpdce3pff s2s6k5PEqHMsx5vpqk9vBjO+ZaN49TrsD7NLZnsK++Qi5gCKkOXBLNRpHmh5J0KCd9Jy fdrQfxwhb30iB0oXJM1VB4sSl7ROAI9EGK+/mzw9npcjjjet9P1E37j/DmlVF6Z7qz5h v5UPG6rQjSClOg3ZXg+tOQPeX0QE8hWAH9TsZL6c1tMRv+0gzYPBggQr6BrqdedYDc0i etOAiDTxQpsoo2KmO1slWz3Strfrm9V5d5sdeuE8MIbu3BbVe+K17Js5r7vZLStyml/G zf7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OqNrpR0K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 62-20020a630241000000b00528b78ddc06si2149186pgc.455.2023.04.28.09.36.02; Fri, 28 Apr 2023 09:36:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OqNrpR0K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229996AbjD1Q3k (ORCPT + 99 others); Fri, 28 Apr 2023 12:29:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229806AbjD1Q3j (ORCPT ); Fri, 28 Apr 2023 12:29:39 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03C481A2 for ; Fri, 28 Apr 2023 09:29:38 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3f315712406so68406115e9.0 for ; Fri, 28 Apr 2023 09:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682699376; x=1685291376; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7GlwYkULXBPy4OcdTr53UD+8dz+uvHO/2mc0S4p+P3I=; b=OqNrpR0KrU8mxcP4/MQWQl8UkwADPn2+wrbVkk96UxhhWitrk05uGWH2mKCRN+YfIE NAVeW8vXRCfykR5wkNxPSmAPVtbBX0gJeN3BU6ILBBf9kIGhBfMfPhsvvaIljn8F/VUz AG3bzpoqYB3fGRDKd5RHet9dyW1KfeegL9fF9PgWuyMR8u7RVMh5O5hpkyNAxKehWWMR 3ZcsZIcMeu9pzwuHUsHnregEMNulqm6DMHqyS1gz8Trdm+edzvOO63WpGiC0onZpEFcK zYLJRFnGKlYZdeTVIKu4qFLgvFQs11UQuhL3MK3a5qurXnau9fyXf4/DBo2XdBwGuULr p2Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682699376; x=1685291376; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7GlwYkULXBPy4OcdTr53UD+8dz+uvHO/2mc0S4p+P3I=; b=DRUSaXwfjhjNDaEtEsBW8SeQk0XYtrIRzO2Rk0tcRkS4LzfSK+1YG19HVxNX04FEhQ HmqaMNAc8SPu3tzx1Btndn5aDfH3ZFWuohxx94UF9BQAQh3A+zyA3C8EBcQjYI9nYj30 f5oBX/Nb9u3UecjtdFrz4qM2JWimjn4w7fdOrtkbSDmlGfn5xbS0TzAjLa27DyJIOIyB 7nEi0At5RV8K4O/3P31/d28OeQSVdlhrMgpAoadLDe5iOb+3g9LVLtYxCMo1FVtuFu43 17cRRTPUBukoCRDzE2y9BOBhwRt6+NkVinvJXS2Mypqxj0cqVkJ5fCzqiiI/ag5rLcCw 8ZdA== X-Gm-Message-State: AC+VfDxAwo7xAmkAzFnXHEXQSmjgfFxuu5oQ6xNC0KFfRFIlNgokdTba 6c20yy6xLYTnN1kYLxslfJ+pug== X-Received: by 2002:a05:600c:3103:b0:3f0:a095:7b9 with SMTP id g3-20020a05600c310300b003f0a09507b9mr8016575wmo.5.1682699376486; Fri, 28 Apr 2023 09:29:36 -0700 (PDT) Received: from [192.168.125.234] (92.40.199.120.threembb.co.uk. [92.40.199.120]) by smtp.gmail.com with ESMTPSA id n16-20020a05600c181000b003f046ad52efsm28067959wmp.31.2023.04.28.09.29.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Apr 2023 09:29:36 -0700 (PDT) Message-ID: <4403b1fa-3bce-3f4f-183f-a8353df42dfd@linaro.org> Date: Fri, 28 Apr 2023 17:29:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH -next] bus: qcom: Use devm_platform_ioremap_resource() To: Yang Li , agross@kernel.org Cc: andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230428065210.30095-1-yang.lee@linux.alibaba.com> Content-Language: en-US From: Caleb Connolly In-Reply-To: <20230428065210.30095-1-yang.lee@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/04/2023 07:52, Yang Li wrote: > Convert platform_get_resource(),devm_ioremap_resource() to a single > call to devm_platform_ioremap_resource(), as this is exactly what this > function does. > > Signed-off-by: Yang Li Reviewed-by: Caleb Connolly > --- > drivers/bus/qcom-ebi2.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c > index c1fef1b4bd89..01e76bb05218 100644 > --- a/drivers/bus/qcom-ebi2.c > +++ b/drivers/bus/qcom-ebi2.c > @@ -294,7 +294,6 @@ static int qcom_ebi2_probe(struct platform_device *pdev) > struct device_node *np = pdev->dev.of_node; > struct device_node *child; > struct device *dev = &pdev->dev; > - struct resource *res; > void __iomem *ebi2_base; > void __iomem *ebi2_xmem; > struct clk *ebi2xclk; > @@ -325,15 +324,13 @@ static int qcom_ebi2_probe(struct platform_device *pdev) > goto err_disable_2x_clk; > } > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - ebi2_base = devm_ioremap_resource(dev, res); > + ebi2_base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(ebi2_base)) { > ret = PTR_ERR(ebi2_base); > goto err_disable_clk; > } > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 1); > - ebi2_xmem = devm_ioremap_resource(dev, res); > + ebi2_xmem = devm_platform_ioremap_resource(pdev, 1); > if (IS_ERR(ebi2_xmem)) { > ret = PTR_ERR(ebi2_xmem); > goto err_disable_clk;