Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jens Axboe <axboe@kernel.dk>
To:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        Tao Su <tao1.su@linux.intel.com>
Cc:     tj@kernel.org, josef@toxicpanda.com, yukuai1@huaweicloud.com
In-Reply-To: <20230428045149.1310073-1-tao1.su@linux.intel.com>
References: <20230428045149.1310073-1-tao1.su@linux.intel.com>
Subject: Re: [PATCH v2] block: Skip destroyed blkg when restart in
 blkg_destroy_all()
Message-Id: <168270266088.259022.9566325777722187933.b4-ty@kernel.dk>
Date:   Fri, 28 Apr 2023 11:24:20 -0600
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On Fri, 28 Apr 2023 12:51:49 +0800, Tao Su wrote:
> Kernel hang in blkg_destroy_all() when total blkg greater than
> BLKG_DESTROY_BATCH_SIZE, because of not removing destroyed blkg in
> blkg_list. So the size of blkg_list is same after destroying a
> batch of blkg, and the infinite 'restart' occurs.
> 
> Since blkg should stay on the queue list until blkg_free_workfn(),
> skip destroyed blkg when restart a new round, which will solve this
> kernel hang issue and satisfy the previous will to restart.
> 
> [...]

Applied, thanks!

[1/1] block: Skip destroyed blkg when restart in blkg_destroy_all()
      commit: 8176080d59e6d4ff9fc97ae534063073b4f7a715

Best regards,
-- 
Jens Axboe