Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Apr 2023 15:50:20 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Theodore Ts'o <tytso@mit.edu>
Cc:     David Hildenbrand <david@redhat.com>,
        Lorenzo Stoakes <lstoakes@gmail.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Jens Axboe <axboe@kernel.dk>,
        Matthew Wilcox <willy@infradead.org>,
        Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
        Leon Romanovsky <leon@kernel.org>,
        Christian Benvenuti <benve@cisco.com>,
        Nelson Escobar <neescoba@cisco.com>,
        Bernard Metzler <bmt@zurich.ibm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Bjorn Topel <bjorn@kernel.org>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Jonathan Lemon <jonathan.lemon@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Christian Brauner <brauner@kernel.org>,
        Richard Cochran <richardcochran@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        netdev@vger.kernel.org, bpf@vger.kernel.org,
        Oleg Nesterov <oleg@redhat.com>,
        John Hubbard <jhubbard@nvidia.com>, Jan Kara <jack@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Pavel Begunkov <asml.silence@gmail.com>,
        Mika Penttila <mpenttil@redhat.com>,
        David Howells <dhowells@redhat.com>,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v5] mm/gup: disallow GUP writing to file-backed mappings
 by default
Message-ID: <ZEwVbPM2OPSeY21R@nvidia.com>
References: <6b73e692c2929dc4613af711bdf92e2ec1956a66.1682638385.git.lstoakes@gmail.com>
 <afcc124e-7a9b-879c-dfdf-200426b84e24@redhat.com>
 <ZEvZtIb2EDb/WudP@nvidia.com>
 <ZEwPscQu68kx32zF@mit.edu>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZEwPscQu68kx32zF@mit.edu>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lpvvpoMKjBAVQsAiaqFnhK5VqRAC4zmQA4XcTaDvk7USM2JDCCPxndiS5Ik7?=
 =?us-ascii?Q?te0gaYJ6AVTgJJgl+CJTJyb/RcXG4nHUkWRDN6Kjp7HCZQxkXSo8RcMN70gH?=
 =?us-ascii?Q?+wLdoZ7R77YeRCYgR7DzldQ3gDTd8gWPon8eKU+0mNLEooLD7u6rnkf7w5Wm?=
 =?us-ascii?Q?aeobJ8LX27ahq844jK/Di4ZDtn7lcEWe48gjoOnzBTvAZ0eQg/V05vpzPUT1?=
 =?us-ascii?Q?yUmR1jB0sCtHqNIEyS2XOwPN0Bcyu4eQsyhmOkJG1ehsED0kYHJVPM5zE4Hi?=
 =?us-ascii?Q?rIxAh5EKoqUuSKHtWeqy4/tbcf0PdVoDjClZHHnvuEsBF78CTWW6KWN5vd2b?=
 =?us-ascii?Q?k+Z+Vg2KqA3ldElEX+0Dvl/G60V8q6Nlo1BEh3qV9y/egVgyg6IXTwmVx5WN?=
 =?us-ascii?Q?0aXNcIGYPxGJLJooiDo4o24y5vIm3FzSkKMeD6XjFZ3HeVQwLGUEGsOnzNW9?=
 =?us-ascii?Q?mf1ZYDWv7FF5QTKZI+RyqE9My1DppnvGhplerfp92Fly9Jr9gW79YYVYLoPP?=
 =?us-ascii?Q?EIEOv2bVVhjZGazXbmvqUT3CT5gvrtWfGOZ28Fy5/UD4jX5i1s4NEdOuNHu0?=
 =?us-ascii?Q?bQoNKTa+WrVd9hMqvvbK8E+4ewm4bO1Nh0K3c7AoPJzw8DQEh4a09tscHB6E?=
 =?us-ascii?Q?cIimipHy9dLd6HhRfq9K2Ha4ldR+3OfSxZpcIgCP5Zddmwe8Q1ofcQYjn3R3?=
 =?us-ascii?Q?dkPivvDDohnvrPC9+LDA16Cr4KS+Sqnw71gXtAIv616z/00U2Bq2znoZxQge?=
 =?us-ascii?Q?/LEF1N4ShUZGXYXw5iCpZFRAKznKGbBaULN52sewprS/22qB2tTHGE7Mr3j9?=
 =?us-ascii?Q?Sfxu5yAI6K6u495mnm4G+N+PV2s7Txfhu2OIluCLFrde5Kjlwi8EwO0udpQE?=
 =?us-ascii?Q?yoq8AaCYCNn0/8Ds6cpunAohrDF83cbbHYVPqLNuOIlvYIgc/O4fVPZUMRDZ?=
 =?us-ascii?Q?+ltNxNqCtRU7gP9oSJycgXnvoTXdDJxQY3pg4/8G//xV7odcSVIcLJt/Scvy?=
 =?us-ascii?Q?ej7gdAdQS8GJQW5KsTC16Fz0LUWsKbrSg3HQmk90DAZDlxUqJTF1ydclKs8s?=
 =?us-ascii?Q?qpmS+m1dpdn/hCdQpMkMZ72clWgCxaAPeqeTZ2dGfHOKITXh2KT9Ttq+h922?=
 =?us-ascii?Q?1Q/8oUySOEYQJBErLdUGWIHd32GcBIg1Hkhzlcae9K7aosNYcm6+yjibf8qS?=
 =?us-ascii?Q?u/IlufAAHbjVi0uvIZKbZWOFZdHGpMZIW6xeBrTU6USKRArPfTleBEK2TbGn?=
 =?us-ascii?Q?PvgAO6iH+8nPA6WD3UGn/xcCae5u7V0m52Ozo1oHWimU3NuvYYe1huKHEVkn?=
 =?us-ascii?Q?CD9yvcmfzRtmCbfLqpayoFuney72Zf9fh981b+vQ3ek1sREMuBneXfWgUmFl?=
 =?us-ascii?Q?M7oIVIhO8eUIpv+MDZyMgzRfNo1MufrNbxjRV2/iFnZNucMZGHN1oD00aJBV?=
 =?us-ascii?Q?twuUIAH38bH6TbPEGiAjW8cjjWk050ssMSJbUPk8aQoBrF9zahekKPxBxL74?=
 =?us-ascii?Q?evb/lArsjPWDnQWVZmVQmf71VUWYX7jIhXAQvhWaYCYp1OgJmmf5f8SdYpBM?=
 =?us-ascii?Q?ExDBFVfGy8SmkUypSs7vMKqScWjVoNxWeg548P7E?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e1013f1-8066-4797-5481-08db48196aec
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2023 18:50:21.0104
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Sr86pnZuXaKvdhH5BdjB/Vh39hnF0oK/VH2mWXD5+40GyOwTz4E/OW4Wkh0GY31h
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6637
X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 28, 2023 at 02:25:53PM -0400, Theodore Ts'o wrote:
> On Fri, Apr 28, 2023 at 11:35:32AM -0300, Jason Gunthorpe wrote:
> > 
> > It has been years now, I think we need to admit a fix is still years
> > away. Blocking the security problem may even motivate more people to
> > work on a fix.
> 
> Do we think we can still trigger a kernel crash, or maybe even some
> more exciting like an arbitrary buffer overrun, via the
> process_vm_writev(2) system call into a file-backed mmap'ed region?

Jens? You blocked it from io_uring, did you have a specific attack in
mind?

Jason