Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp2624880rwr; Fri, 28 Apr 2023 13:09:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6gPz/5xyeQacTJpWfhx3mUv/stbJr5g2Mp9ED0UYBjGgVco9iRZCDnoeRzeTtdtgNHQ7iZ X-Received: by 2002:a05:6a00:234b:b0:63f:120a:1dc3 with SMTP id j11-20020a056a00234b00b0063f120a1dc3mr9680475pfj.0.1682712564006; Fri, 28 Apr 2023 13:09:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682712563; cv=none; d=google.com; s=arc-20160816; b=hi6YlYrnxVTSedj8QcHpFA+JJTEFGxIxuOtCGP3ZG/NRWDOiSSo4ARfNXqT3HQID3h 1oVoPigYbASCgKmfZkjPCNa7KjFgpebnKybuft1VTbJSz+KRX5TGnmg9KtxIGKCNJNqv vdfnpH5X/D6opMKBaF7reQt2Wv9QSq02C67jGhCoK/E0uhDaheCcdRkmnMYICmhNO1U9 x7NwaQ0Ik323G7LR/v3f5cGGcuC5UEBxLb87ZT3yG6JiwJ9sQAoNxnJp9x4QQz9MbA+q EziOTCQNw4k+XZknFCb9v8oJaTk0R2JlsNnUUezFH+DSzq7UiYg1hCzGXziKoo6Lx2C8 prag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=enCByRO6b0ykPwBxtn+l8VqQuuFD2VtVHiDgiu6XVHo=; b=cV+JTEGNIox6DyjJbKaIP67OOyQl6/lWXmpReJUP7kXvGUrH+UJIiENYafbmXCGxAW BMT5xwKbpw55UCLYMPMjjEZYGTN2GKm/GulkEECsFZgWr8P0r5qO1XQ5D3eIukMGPqQQ Sr7hw11ETbmJ8L14n9m+NgVKihNPXLSw3u1nmAlkTOFeQiMed7telxZ7OdN+0sqnwklo 6y1xYxKdnRSMqL+b5H74zfDnBzn8Egs69Maf1xa9gQxoYoWECqwBBfHJLtpWHGbeq6HO U38VPRiMTNiKXyX2fModGCXiWI1Mna7bJiY2OxOKhKuPTTAU+DPXeT20hcxJXuPwlG4Z b72g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=eWiujVF7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w68-20020a627b47000000b006351cdc5e2fsi22388746pfc.292.2023.04.28.13.08.54; Fri, 28 Apr 2023 13:09:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=eWiujVF7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346081AbjD1UA5 (ORCPT + 99 others); Fri, 28 Apr 2023 16:00:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbjD1UA4 (ORCPT ); Fri, 28 Apr 2023 16:00:56 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3168D211C; Fri, 28 Apr 2023 13:00:55 -0700 (PDT) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33SIwwwU018235; Fri, 28 Apr 2023 20:00:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=qcppdkim1; bh=enCByRO6b0ykPwBxtn+l8VqQuuFD2VtVHiDgiu6XVHo=; b=eWiujVF7bZbcaHy41a19XjWFTl3mRB9mhGmlBFlWkTTKK8Blaoev0rKESG1l+lkF9ncg Ps2yuKq2uJpxQa9fqkjhjFaBoaEk3tYlDtJKGQvICYjhJeaYVssiXUqS/jftBefPMRhS Q8/7MXrDAwmS+30QVzUEJK4NTcdZubn3qhYlZLYcQ/B96ztkQpSR/eJDoPRa2XhKmkn0 2RaczffyC8CWZJkM+qTqGqj7EQRuZ/tZXCL2+g6u5v2lrUKtUbAUncRzOh7OMhN67PnB sU48O40lyqyhPE1GjYFEkinPUf+YkUo3Ybloni0vOm/mkTcPF1xF60/c82xRujyCyhXl MQ== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3q8k0w8813-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 Apr 2023 20:00:46 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 33SK0jRm021856 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 Apr 2023 20:00:45 GMT Received: from abhinavk-linux.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Fri, 28 Apr 2023 13:00:44 -0700 From: Abhinav Kumar To: Rob Clark , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Marijn Suijten CC: Abhinav Kumar , <~postmarketos/upstreaming@lists.sr.ht>, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , "Jami Kettunen" , Jordan Crouse , , , , , Jessica Zhang Subject: Re: (subset) [PATCH v3 0/3] drm/msm/dpu: Drop useless for-loop HW block lookup Date: Fri, 28 Apr 2023 13:00:30 -0700 Message-ID: <168271198315.17728.9108874132629533053.b4-ty@quicinc.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230418-dpu-drop-useless-for-lookup-v3-0-e8d869eea455@somainline.org> References: <20230418-dpu-drop-useless-for-lookup-v3-0-e8d869eea455@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: A-vLA0Ir98ixbOmExFvWTHl_fL94vnIj X-Proofpoint-ORIG-GUID: A-vLA0Ir98ixbOmExFvWTHl_fL94vnIj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-28_06,2023-04-27_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 mlxlogscore=738 clxscore=1015 impostorscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304280163 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Apr 2023 01:11:08 +0200, Marijn Suijten wrote: > Doing a for loop in every DPU HW block driver init to find a catalog > entry matching the given ID is rather useless if the init function > called by RM already has that catalog entry pointer, and uses exactly > its ID to drive this init and for loop. Remove all that machinery to > drop quite some lines of unnecessarily-complicated code, and the > fallibility that comes with it, by simply giving _init() the catalog > entry pointers straight away. > > [...] Applied, thanks! [1/3] drm/msm/dpu: Assign missing writeback log_mask https://gitlab.freedesktop.org/abhinavk/msm/-/commit/a432fc31f03d Best regards, -- Abhinav Kumar