Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230428105453.110254-1-jpanis@baylibre.com> <CAOCHtYgKfJ4cXULvs8YrJ6+-UnrbBWQgXL+d6OMHOOexuj4uiQ@mail.gmail.com>
In-Reply-To: <CAOCHtYgKfJ4cXULvs8YrJ6+-UnrbBWQgXL+d6OMHOOexuj4uiQ@mail.gmail.com>
From:   Robert Nelson <robertcnelson@gmail.com>
Date:   Fri, 28 Apr 2023 15:53:16 -0500
Message-ID: <CAOCHtYgreXmtcuRDRu3UWRhPJ0-k2E+3YYhxp_AaPf-sObuR1Q@mail.gmail.com>
Subject: Re: [PATCH] arm: dts: Add am335x-boneblack-pps.dts
To:     Julien Panis <jpanis@baylibre.com>
Cc:     arnd@arndb.de, olof@lixom.net, soc@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, tony@atomide.com,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Apr 28, 2023 at 9:44=E2=80=AFAM Robert Nelson <robertcnelson@gmail.=
com> wrote:
>
> On Fri, Apr 28, 2023 at 6:00=E2=80=AFAM Julien Panis <jpanis@baylibre.com=
> wrote:
> >
> > From: Lokesh Vutla <lokeshvutla@ti.com>
> >
> > Add a new am335x-boneblack-pps.dts that can be used to configure TIMER7
> > in PWM mode. This PWM signal can be used as a PPS signal when
> > synchronized to PTP clock. Typically this synchronization is done by a
> > userspace program. This PPS signal can be observed on pin P8.8.
> >
> > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> > Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> > Signed-off-by: Adrien Ricciardi <aricciardi@baylibre.com>
> > Signed-off-by: Julien Panis <jpanis@baylibre.com>
> > ---
> >  arch/arm/boot/dts/Makefile                 |  1 +
> >  arch/arm/boot/dts/am335x-boneblack-pps.dts | 25 ++++++++++++++++++++++
> >  2 files changed, 26 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/am335x-boneblack-pps.dts
> >
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index efe4152e5846..d74158aae72d 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -939,6 +939,7 @@ dtb-$(CONFIG_SOC_AM33XX) +=3D \
> >         am335x-base0033.dtb \
> >         am335x-bone.dtb \
> >         am335x-boneblack.dtb \
> > +       am335x-boneblack-pps.dtb \
> >         am335x-boneblack-wireless.dtb \
> >         am335x-boneblue.dtb \
> >         am335x-bonegreen.dtb \
> > diff --git a/arch/arm/boot/dts/am335x-boneblack-pps.dts b/arch/arm/boot=
/dts/am335x-boneblack-pps.dts
> > new file mode 100644
> > index 000000000000..88d2bc3fd759
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/am335x-boneblack-pps.dts
> > @@ -0,0 +1,25 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Copyright (C) 2023 Texas Instruments Incorporated - http://www.ti.c=
om/
> > + */
> > +
> > +#include "am335x-boneblack.dts"
> > +
> > +&am33xx_pinmux {
> > +       pwm7_pins: pinmux_pwm7_pins {
> > +               pinctrl-single,pins =3D <
> > +                       AM33XX_PADCONF(AM335X_PIN_GPMC_OEN_REN, PIN_OUT=
PUT_PULLDOWN, MUX_MODE2)
> > +               >;
> > +       };
> > +};
> > +
> > +/{
> > +       pwm7: dmtimer-pwm7 {
> > +               compatible =3D "ti,omap-dmtimer-pwm";
> > +               pinctrl-names =3D "default";
> > +               pinctrl-0 =3D <&pwm7_pins>;
> > +               #pwm-cells =3D <3>;
> > +               ti,timers =3D <&timer7>;
> > +               ti,clock-source =3D <0x00>; /* timer_sys_ck */
> > +       };
> > +};
>
> I know this commit is pretty small, but mainline now has overlay support:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit=
/?id=3D0fff0e49d72a53c51d8903fbadb2e6a84e531c4a
>
> At what point do we finally merge in the many dozen *BeagleBone*
> overlays, or do we still wait for :
> https://lore.kernel.org/lkml/20220328000915.15041-1-ansuelsmth@gmail.com/

OH SIde note, #2... thanks @Nishanth Menon !

We do have this example:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?=
id=3D8e01fb15b8157a825d309ea2598b494dd81a7b42

So instead of `am335x-boneblack-pps.dtb` it could be: ....
am335x-bone-dmtimer-pwm7.dtbo or even am335x-dmtimer-pwm7.dtbo ?

Thoughts?

--=20
Robert Nelson
https://rcn-ee.com/